Resolves: #53753
Releases: 6.2
Change-Id: I3acb81c71796bc84ada29e6cdf6141be07f69ca3
Reviewed-on: https://review.typo3.org/25503
Reviewed-by: Christian Opitz
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
This reverts commit de27a20afbd8f413f60029afc5622c7b33212322
Change-Id: I078d2f7bbff605c91d83a9853e8feb9c31d57ccc
Reviewed-on: https://review.typo3.org/27792
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
It is faster to compare a string with === '' to find out if it's empty
than to run strlen() on it.
The replacement rules are applied as follows:
* if (strlen($str))
=> if ((string)$str !== '')
* if (!is_string($str) || strlen($str) === 0)
=> if (!is_string($str) || $str === '')
* If it can be seen easily that $str is a string,
the typecast is omitted.
Resolves: #54091
Releases: 6.2
Change-Id: I59c5cbccea4f98b8f282377e6aa67d970859a457
Reviewed-on: https://review.typo3.org/27091
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
This patch replaces most of around 1600 occurrences of
intval() and every (integer) in the whole core.
Additionally it changes GeneralUtility::intExplode to use references
and typecasting as well.
Some occurrences of strstr() together with intval() have been replaced
with strpos() as well.
And some superfluous intval calls have been removed or reduced
to a single one i.e. for protected variables or before loops.
Patch updated after Core CGL decision from 30.01.2014
Resolves: #54265
Releases: 6.2
Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8
Reviewed-on: https://review.typo3.org/26740
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
The frontend editing + admin panel needs some polishing.
Following changes are included:
General
=======
- Reformat code
- Use Sprite API which means using the correct icons
Admin Panel
==============
- Add missing translations
- Show "Simulate usergroup" only if usergroups are available
- Remove "Total page count" in Info Tab as information is wrong
(counting images + document is not the total page size)
Frontend Editing
=================
- Remove "edit_editNoPopup", "forceNoPopup", "editFormsOnPage"
for direct inline editing
- Remove setting "previewBorder" which is not needed and looks just ugly
Releases: 6.2
Resolves: #49640
Change-Id: I35f88bc4e8c138fc21b74c0448b2f3892ab61918
Reviewed-on: https://review.typo3.org/21859
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
The current composer type of system extensions is "typo3cms-framework".
In the composer installer for TYPO3 CMS the composer type of extensions
is "typo3-cms-extension". In order to align our composer type with the
community defined it is changed to "typo3-cms-framework".
Resolves: #52831
Releases: 6.2
Change-Id: I1f43a60bd4cf59b47163123b57c8ba09e35e6526
Reviewed-on: https://review.typo3.org/24780
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Change-Id: Iaf88fc46903400d97f6f1dc3acedb3c9b438e8dd
Releases: 6.2
Resolves: #52740
Related: #47018
Reviewed-on: https://review.typo3.org/24667
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Make use of boolean value TRUE as second parameter in sL function.
Change-Id: I6d77affc4f3ff260f617ca67c773fc4ca2e481ce
Resolves: #51143
Releases: 6.2
Reviewed-on: https://review.typo3.org/23153
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
This catches most old empty class files from ext:cms. The rest
needs to be taken care of in single patches.
The patch also changes all old mentions of the old class names,
mostly comments are affected.
Change-Id: I2b8ebfad178001c7bc8def967c01a56ae113c029
Resolves: #47792
Related: #47756
Releases: 6.2
Reviewed-on: https://review.typo3.org/20381
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
System extensions are shipped with the same version number as the TYPO3 release they belong with. Also the dependency should be sett accordingly to make clear they are not to be used with other releases.
Change-Id: I575e19bb2f2c1d0a6ee27753ec2e05dee1b2e42e
Fixes: #47644
Releases: 6.2
Reviewed-on: https://review.typo3.org/20234
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reduce the severity if an internal flag is set and the a backend user
is logged in.
Resolves: #43735
Related: #43506
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: Ifd78f67d38b87180ab60df05167974705ee90352
Reviewed-on: https://review.typo3.org/17020
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Some core parts still mention t3lib classes after namespaces,
mostly in comments.
Resolves: #47138
Releases: 6.1
Change-Id: I0775fc10f8c901a02533e5bc0fe1c6aa2276758b
Reviewed-on: https://review.typo3.org/19803
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
The core still access xliff language files as .php or .xml,
although the files themselves are converted to .xlf since quite
some time. This could cause confusion.
This is a cleanup taken all .xlf files in the EXT:lang/.xlf
directory and run via a sed script (thanks to Stucki)
Resolves: #46940
Releases: 6.1
Change-Id: I427776b176ba2c23678689029eaf388dff90d0fa
Reviewed-on: https://review.typo3.org/19579
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
The serialized array _md5_values_when_last_written is not
maintained for core extensions since ages and just contains
a long string with outdated information.
It is set to an empty string now.
Change-Id: Iae1de150dd0da4ef9ccd993bdc0e75e5eb4c62c1
Resolves: #46699
Releases: 6.1
Reviewed-on: https://review.typo3.org/19322
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
In this patch are also some fixes for files containing
a interface. Due the namespace change all interfaces
have the curly bracket not on the same line as the
interface name.
Change-Id: I64ba45de73693452d681ce7f018965968b11d2af
Resolves: #46370
Releases: 6.1
Reviewed-on: https://review.typo3.org/18984
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Since #20849, we can specify a reason why we call
GLOBALS['TSFE']->set_no_cache().
Provide a reason for all calls done in core.
Resolves: #43506
Related: #20849
Releases: 6.1
Change-Id: Id786a041ef5d9f1db49d644459a593aaf54b5018
Reviewed-on: http://review.typo3.org/16925
Reviewed-by: Stefan Neufeind
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
The 'old' class files before namespace switch are commented
to be removed with TYPO3 7.0, but they should be scheduled
for removal with 6.2.
Change-Id: I2db757db54410c5764ab21aef90918a7771f2c92
Resolves: #43120
Releases: 6.0
Reviewed-on: http://review.typo3.org/16590
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
With namespaces the @package and @subpackage annotations
do not have a real benefit anymore and can be removed.
Change-Id: Id8f4718db0c1c51ae5143a3353dd5efb42dadf70
Resolves: #43019
Releases: 6.0
Reviewed-on: http://review.typo3.org/16474
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
The class ExtensionManager is actually a utility
to manage extensions. Rename it to better reflect
it's purpose.
Renaming in submodules will be done seperately.
The third step will then be to remove the old
namespaced class name from the class alias map
and raise the submodule pointers
Related: #42661
Releases: 6.0
Change-Id: I0be22f117e9e4121001b6a14118d289834438066
Reviewed-on: http://review.typo3.org/16163
Reviewed-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
* adopt class loader to load the class alias map from a location
Migrations/Code/ClassAliasMap.php in every extensions path
* split up core class alias map into extension class alias maps
* adopt tests to the compound class loader cache
Change-Id: I7102fd5aab7a6364d5bcb5603f011dfcdb859ec9
Resolves: #41012Resolves: #41013
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/15085
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
The text version of edit_showFieldHelp is not supported since 4.5
anymore. This patch removes all references and dead code.
Resolves: #24623
Releases: 6.0
Change-Id: Idb915f4dbaba8ee0690c06fddcace4d0d4ad6813
Reviewed-on: http://review.typo3.org/14950
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reverts the split-up for the extension reedit:
Erroneous extKey was 'fe_edit'.
Also fixes minor CGL.
Change-Id: If727b7ffcefdd1fb917fc15d48b91e549f5b79b9
Releases: 6.0
Fixes: #40174
Related: #40095
Reviewed-on: http://review.typo3.org/14073
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Clean up phpDoc comments for the following classes:
* typo3/sysext/cshmanual/ext_tables.php
* typo3/sysext/extra_page_cm_options/class.tx_extrapagecmoptions.php
* typo3/sysext/extra_page_cm_options/ext_tables.php
* typo3/sysext/feedit/ext_localconf.php
* typo3/sysext/feedit/view/class.tx_feedit_editpanel.php
* typo3/sysext/felogin/ext_localconf.php
* typo3/sysext/felogin/ext_tables.php
* typo3/sysext/felogin/pi1/class.tx_felogin_pi1.php
* typo3/sysext/felogin/tests/tx_feloginTest.php
Clean up provides:
* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
Change-Id: Id09ec3f662b432098eb3b3897008cbeee76e0871
Resolves: #38242
Releases: 6.0
Reviewed-on: http://review.typo3.org/12245
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
There are violations against the CGL rule "InlineCommentWrongStyle " in
ext_emconf.php files.
These will be fixed.
Change-Id: Ic8a83bf8a12246328a4c8fe48ef27fb99c2f3396
Resolves: #37685
Releases: 6.0
Reviewed-on: http://review.typo3.org/11793
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
There were violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/sysext/f*/.
These will be reduced by this commit.
Change-Id: I301a98427a558edbabc62e73e4ca05be546f3482
Resolves: #37512
Releases: 6.0
Reviewed-on: http://review.typo3.org/11652
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
There were a lot spacing CGL violations in /typo3/sysext/.
These will be reduced by this commit.
Change-Id: Iae4dc7bfbca79f5e71446d850eebfceeb20e4a18
Resolves: #37310
Releases: 6.0
Reviewed-on: http://review.typo3.org/11311
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Remove all XCLASS definitions in typo3/ and all system extension
that are not handled as git submodules.
Change-Id: Ib9e1d8db31f91f5f1453deb694f2441ef41130f2
Resolves: #36821
Related: #31893
Releases: 6.0
Reviewed-on: http://review.typo3.org/10981
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
When shipped with TYPO3, system extensions should be stable, have a
version that is at least 1.0.0, have a version that is higher than
in TYPO3 4.5 LTS and should have at least the same basic dependencies
as the Core itself.
Change-Id: I141cd5a2254ae9430d3047a7506b4ae3cf9e7c9e
Resolves: #30853
Releases: 4.6
Reviewed-on: http://review.typo3.org/5743
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
The md5 checksums for all system extensions not integrated as submodule
should be updated.
Change-Id: I845cc4204ca3f6c334fcdb7750ba5a927a9c36f7
Resolves: #30723
Releases: 4.6
Reviewed-on: http://review.typo3.org/5664
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
As testInt, calcPriority and calcParenthesis were moved and renamed to
t3lib_utility_Math we have to change the core usages, too.
Change-Id: Ia828ffbdf92dc72d35a1d3f5919869d043e3bb83
Depends: #28064Resolves: #28096
Reviewed-on: http://review.typo3.org/3260
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
This is part of the t3lib_div refactoring started at T3DD11.
With #28019 these methods have been moved to own utility
classes, now the Core should uses these.
Change-Id: Ib5b0d8f9a4322e5489b148e280993a3579fc21af
Resolves: #28026
Reviewed-on: http://review.typo3.org/3179
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Booleans should be written in uppercase.
Change-Id: Ib29abc6e1e658e3a1b65cd1873a3a3edac7dba57
Resolves: #26346
Releases: 4.6
Reviewed-on: http://review.typo3.org/1790
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Formsonopage-mode raises error: Call to undefined method stdClass::getDynNestedStack.
Thus call initDefaultBEMode() during initialization.
Change-Id: If3ffc4b4fb3aff0dac72f3cbca405cb74d082783
Resolves: #M15553
Reviewed-on: http://review.typo3.org/1078
Reviewed-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>
Tested-by: Andreas Wolf <andreas.wolf@ikt-werk.de>
Reviewed-by: Andreas Wolf <andreas.wolf@ikt-werk.de>
