danielsiepmann/tea
danielsiepmann/tea
1
0
mirror of https://github.com/FriendsOfTYPO3/tea.git synced 2024-11-10 03:56:12 +01:00
Code Activity

[TASK] Change misleading variable names in some tests (#470)

Browse source 
We are not using any "container" class here, and hence the results from
repository find methods should be named `$result` instead of `$container`.
This commit is contained in:
Oliver Klee 2022-06-28 23:52:02 +02:00 committed by GitHub
parent 69f03b0110
commit dc6c0eedeb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
Tests/Functional/Domain/Repository/Product/TeaRepositoryTest.php
View file

@ -53,9 +53,9 @@ class TeaRepositoryTest extends FunctionalTestCase
*/ */
public function findAllForNoRecordsReturnsEmptyContainer(): void public function findAllForNoRecordsReturnsEmptyContainer(): void
{ {
$container = $this->subject->findAll(); $result = $this->subject->findAll();
self::assertCount(0, $container); self::assertCount(0, $result);
} }
/** /**
@ -65,9 +65,9 @@ class TeaRepositoryTest extends FunctionalTestCase
{ {
$this->importDataSet(__DIR__ . '/../Fixtures/Product/Tea.xml'); $this->importDataSet(__DIR__ . '/../Fixtures/Product/Tea.xml');
$container = $this->subject->findAll(); $result = $this->subject->findAll();
self::assertGreaterThanOrEqual(1, \count($container)); self::assertGreaterThanOrEqual(1, \count($result));
} }
/** /**
@ -77,10 +77,10 @@ class TeaRepositoryTest extends FunctionalTestCase
{ {
$this->importDataSet(__DIR__ . '/../Fixtures/Product/Tea.xml'); $this->importDataSet(__DIR__ . '/../Fixtures/Product/Tea.xml');
$container = $this->subject->findAll(); $result = $this->subject->findAll();
$container->rewind(); $result->rewind();
self::assertSame(2, $container->current()->getUid()); self::assertSame(2, $result->current()->getUid());
} }
/** /**