From dc6c0eedeb04c504273e37e570b5f59f18979f11 Mon Sep 17 00:00:00 2001 From: Oliver Klee Date: Tue, 28 Jun 2022 23:52:02 +0200 Subject: [PATCH] [TASK] Change misleading variable names in some tests (#470) We are not using any "container" class here, and hence the results from repository find methods should be named `$result` instead of `$container`. --- .../Repository/Product/TeaRepositoryTest.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Tests/Functional/Domain/Repository/Product/TeaRepositoryTest.php b/Tests/Functional/Domain/Repository/Product/TeaRepositoryTest.php index c4b1aa3..8efaa82 100644 --- a/Tests/Functional/Domain/Repository/Product/TeaRepositoryTest.php +++ b/Tests/Functional/Domain/Repository/Product/TeaRepositoryTest.php @@ -53,9 +53,9 @@ class TeaRepositoryTest extends FunctionalTestCase */ public function findAllForNoRecordsReturnsEmptyContainer(): void { - $container = $this->subject->findAll(); + $result = $this->subject->findAll(); - self::assertCount(0, $container); + self::assertCount(0, $result); } /** @@ -65,9 +65,9 @@ class TeaRepositoryTest extends FunctionalTestCase { $this->importDataSet(__DIR__ . '/../Fixtures/Product/Tea.xml'); - $container = $this->subject->findAll(); + $result = $this->subject->findAll(); - self::assertGreaterThanOrEqual(1, \count($container)); + self::assertGreaterThanOrEqual(1, \count($result)); } /** @@ -77,10 +77,10 @@ class TeaRepositoryTest extends FunctionalTestCase { $this->importDataSet(__DIR__ . '/../Fixtures/Product/Tea.xml'); - $container = $this->subject->findAll(); + $result = $this->subject->findAll(); - $container->rewind(); - self::assertSame(2, $container->current()->getUid()); + $result->rewind(); + self::assertSame(2, $result->current()->getUid()); } /**