Commit graph

221 commits

Author SHA1 Message Date
Georg Ringer
cbdd318a18 [BUGFIX] Include CSS #14 2022-11-17 14:45:25 +01:00
Oliver Hader
52a8c62378
Merge pull request #17 from alexander-nitsche/task-update-docs
[TASK] Align with new TYPO3 documentation standards
2022-04-20 12:40:50 +02:00
Alexander Nitsche
4aaecb36b7 [TASK] Add TER + documentation + repository to composer.json
Add the common extension destinations to composer.json. Packagist
displays them in a prominent place.
2022-04-08 18:20:07 +02:00
Alexander Nitsche
75db0bdbae [DOCS] Clarify difference to EXT:frontend_editing
EXT:feedit is not a true frontend editing solution, but redirects
the user to the appropriate backend form once they have clicked
on a content item in the frontend.
2022-04-05 13:30:32 +02:00
Alexander Nitsche
58201ce398 [TASK] Align with new TYPO3 documentation standards
- align README.md
- align ext_emconf.php, composer.json
- add Settings.cfg, Index.rst, Includes.rst.txt
- add .editorconfig, .gitignore

See https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/GeneralConventions/FileStructure.html for further details.
2022-04-05 12:46:08 +02:00
Benni Mack
135004c782
[RELEASE] Raise to version 10.0.2 2020-09-25 08:32:52 +02:00
Benni Mack
ac3b7cc4a4
Merge pull request #12 from DanielSiepmann/bugfix/handle-js-context
Fix none working backend
2020-09-25 08:31:42 +02:00
3b3f15606a
Fix none working backend
When opening backend, e.g. to edit content, it was broken.
This is due to the reason that context is missing.
The TYPO3 backend expects an existing JS context when an opener exists.
Therefore prevent opener in JS context. That way TYPO3 backend will
initialize itself properly.
2020-09-25 00:30:48 +02:00
Benni Mack
00657f5b15
Merge pull request #9 from DanielSiepmann/bugfix/RequestEnricherInterface-implementation
Fix implementation of RequestEnricherInterface
2020-04-07 23:04:56 +02:00
3450ed6918
Fix implementation of RequestEnricherInterface
The interface was not imported, and no request was returned in method.
2020-04-07 12:14:06 +02:00
Benni Mack
12cf2967d5
[TASK] Streamline README 2020-04-01 12:12:17 +02:00
Benni Mack
9c808d51a4
[RELEASE] Update version to 10.0.1 2020-04-01 12:10:46 +02:00
Benni Mack
85bd05346c
Merge pull request #8 from DanielSiepmann/feature/remove-deprecations
Remove deprecations
2020-04-01 12:07:35 +02:00
bcdfa41703
Remove deprecations
Do not access global lang variable anymore.
Load language file once in constructor.

Do not use deprecated interface, use replacement instead.
2020-04-01 11:55:50 +02:00
Benni Mack
0310e56a01
Merge pull request #7 from DanielSiepmann/feature/4-support-csp
[!!!][FEATURE] Support Content Security Policy
2020-03-18 20:49:51 +01:00
7e2b48aab2
[!!!][FEATURE] Support Content Security Policy
Do not use any inline style or javascript anymore.
Instead js logic is moved to js file.
Information are passed via data attributes.

Some options are not respected anymore. That's why this change is
breaking. Those options can be considered as obsolete anyway for current
state of the art.

Those options are:

TSConfig:

* options.feedit.popupWidth
* options.feedit.popupHeight

TypoScript:

* stdWrap.editIcons.styleAttribute

Resolves: #5
2020-03-17 11:51:04 +01:00
Benni Mack
5013c755a8
[TASK] Streamline composer.json
* Fix replace section
* Use proper require section for core packages
* Add description
2020-03-16 20:28:33 +01:00
Benni Mack
5fbe0e817f
Merge pull request #1 from DanielSiepmann/feature/typo3-10-compat
[TASK] Make extension compatible with current V10 master
2020-03-16 20:25:17 +01:00
Benni Mack
e4e92726e1
Merge pull request #2 from DanielSiepmann/feature/fix-display-of-icon
[BUGFIX] Display edit icons in frontend
2020-03-16 20:24:08 +01:00
Benni Mack
af147cbd9b
Merge pull request #5 from DanielSiepmann/feature/3-keep-context
[FEATURE] Keep context after modifying content elements
2020-03-16 20:23:34 +01:00
733b597943
[FEATURE] Keep context after modifying content elements
Depending on frontend rendering, there is already an anchor in form of
"c<uid>" for each content element. This is added as anchor to the
returnUrls to keep context.

The browser will jump back to the content element that was modified.
This way editors keep their focus.

Resolves: #3
2020-02-09 19:17:34 +01:00
c4efb86393
[TASK] Make extension compatible with current V10 master 2020-01-31 15:36:56 +01:00
a91063ae99
[BUGFIX] Display edit icons in frontend
Do not hide them via inline display none.
Instead provide necessary CSS via static TypoScript.
2020-01-31 13:11:20 +01:00
Christian Kuhn
a4d92d0c5e [TASK] Add feedit specific code from ext:adminpanel 2019-01-20 12:55:15 +01:00
Christian Kuhn
52c17e342e [TASK] Update composer.json and ext_emconf.php 2019-01-20 11:32:56 +01:00
Christian Kuhn
25f1585609 [TASK] Add .gitignore with .idea/ ide folder 2019-01-20 11:29:30 +01:00
Christian Kuhn
506d650495 [TASK] Add README.md 2019-01-20 11:28:47 +01:00
Christian Kuhn
ff8f9195c7 [!!!][TASK] Do not handle 'uploadsfolder' in ext_emconf anymore
With TCA type=group with internal_type=file and
file_reference being dropped, the uploads/ folder
is unused and obsolete.
The patch drops further related code in this area,
especially the ext_emconf.php property uploadsfolder
is obsolete. It is dropped from all ext_emconf.php
files together with its handling in extensionmanager.

Change-Id: I93abc7d614b17adf4d0f2f896e346d3147c49472
Resolves: #87445
Releases: master
Reviewed-on: https://review.typo3.org/59443
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2019-01-15 16:31:50 +01:00
Benni Mack
79ade302fa [!!!][TASK] Remove internal_type=file/file_reference
This drops TCA type=group with internal_type=file and
internal_type=file_reference handling.
This patch is rather huge since detail handling of this
stuff is spread throughout the core. Additionally, some
further methods become unused and oboselete along the way.
Most of them - except DataHandler->process_uploads() - have
been used internally only and can be safetly dropped,
while process_uploads() which has always been part of the
externally called API is substituted with a no-op method.

Resolves: #87428
Releases: master
Change-Id: Ia60b5d0e021b34adf4b4187a5f1fe4475b0070b4
Reviewed-on: https://review.typo3.org/59361
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2019-01-14 14:19:12 +01:00
Benni Mack
f2d64c49f2 [!!!][TASK] Remove deprecated adminpanel/feedit code
The following previously deprecated classes/interfaces have been removed:

* TYPO3\CMS\Adminpanel\View\AdminPanelView
* TYPO3\CMS\Adminpanel\View\AdminPanelViewHookInterface
* TYPO3\CMS\Core\FrontendEditing\FrontendEditingController

The following methods have been removed:
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->initializeAdminPanel()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->initializeFrontendEdit()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->isFrontendEditingActive()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->displayAdminPanel()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->isAdminPanelVisible()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->checkBackendAccessSettingsFromInitPhp()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extPageReadAccess()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extGetTreeList()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extGetLL()

The following public properties have been removed
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extAdmEnabled
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->adminPanel
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->frontendEdit
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extAdminConfig

The following PageTSconfig option has no effect anymore:
* TSFE.frontendEditingController

Resolves: #87231
Releases: master
Change-Id: I88cc3ac18077f054cc8895f5ccfb65291e94defa
Reviewed-on: https://review.typo3.org/59205
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2018-12-19 23:41:07 +01:00
Benni Mack
c1c6951e3f [TASK] Update TYPO3 version to 10.0.0-dev
In order to distinguish between v10-dev / dev-master,
and 9.5, all dependencies are updated to v10.0.0-dev.

For ext_emconf.php the fixed version 10.0.0 is used
as in all other branches.

Resolves: #87159
Releases: master
Change-Id: Ie1f135663527f8c7d1654e085b874d699b677529
Reviewed-on: https://review.typo3.org/59150
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2018-12-14 10:34:22 +01:00
Oliver Hader
74b533fc9e [TASK] Set TYPO3 version to 9.5.4-dev
Change-Id: I99d51f3836de8d062bc5503bcc58e05cdfacb83c
Reviewed-on: https://review.typo3.org/59145
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2018-12-14 09:20:25 +01:00
Oliver Hader
55d129d9a4 [RELEASE] Release of TYPO3 9.5.3
Change-Id: Iee75e14be97ac5018cedf4f7f94664d8d4fe43f0
Reviewed-on: https://review.typo3.org/59144
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2018-12-14 08:28:48 +01:00
Oliver Hader
a3652e787c [TASK] Set TYPO3 version to 9.5.3-dev
Change-Id: If92f54c5a28edba2dc330ca8e32e5dcfda817f6f
Reviewed-on: https://review.typo3.org/59116
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2018-12-11 14:18:47 +01:00
Oliver Hader
04c4e2194f [RELEASE] Release of TYPO3 9.5.2
Change-Id: Ib5214342439fd510cfd599d9880b1612ff9b4cc1
Reviewed-on: https://review.typo3.org/59115
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2018-12-11 13:42:55 +01:00
Oliver Hader
5b686e7588 [TASK] Set TYPO3 version to 9.5.2-dev
Change-Id: If96e59eef0e6be1eac2e58e2d50cf79ba70d6b16
Reviewed-on: https://review.typo3.org/58796
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2018-10-30 12:16:36 +01:00
Oliver Hader
c897307b78 [RELEASE] Release of TYPO3 9.5.1
Change-Id: Ic1c6183af103b9c957b85d046ff2564348f165bc
Reviewed-on: https://review.typo3.org/58794
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2018-10-30 11:45:30 +01:00
Oliver Hader
0b7ef5f3f9 [TASK] Set TYPO3 version to 9.5.1-dev
Change-Id: If916407e7a7d9d54777ecee641bee5a604885ce2
Reviewed-on: https://review.typo3.org/58556
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2018-10-02 11:37:21 +02:00
Oliver Hader
441e63f9ef [RELEASE] Release of TYPO3 9.5.0
Change-Id: Ibacf4ce5d6c2a2e3f7aafb2c17536ab89dff1c15
Reviewed-on: https://review.typo3.org/58555
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2018-10-02 10:10:33 +02:00
Benni Mack
b4d1623437 [TASK] Mark various parts with phpdoc internal
All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.

within
- EXT:felogin
- EXT:feedit
- EXT:filelist
- EXT:frontend
- EXT:fluid_styled_content
- EXT:impexp

All leftover @api methods have been removed.

Resolves: #86508
Releases: master
Change-Id: I97a6964a5f77dc9ee3d90365e9fda3d7d7be6266
Reviewed-on: https://review.typo3.org/58527
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2018-10-01 15:20:41 +02:00
Benni Mack
c79ca8afaf [TASK] Deprecate FrontendEditingController
The class is not in use anymore, only feedit instantiates the class for legacy reasons.

Also FrontendBackendUserAuthentication->frontendEdit which holds an instance of
that, is deprecated.

Resolves: #86110
Releases: master
Change-Id: I3ff2ae529dd920d2abf9908f2ae94ae4c2bf9c15
Reviewed-on: https://review.typo3.org/58067
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2018-09-05 10:03:29 +02:00
Oliver Hader
13a74ad9aa [TASK] Set TYPO3 version to 9.5.0-dev
Change-Id: I96b70e192770b6955f82a8106db386f2044e738b
Reviewed-on: https://review.typo3.org/58181
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2018-09-04 14:22:37 +02:00
Oliver Hader
441099e295 [RELEASE] Release of TYPO3 9.4.0
Change-Id: I10cf279d74af2cfc2964704ba31c6ce2b7be3493
Reviewed-on: https://review.typo3.org/58180
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2018-09-04 14:08:20 +02:00
Christian Kuhn
335d456161 [TASK] Clean up unused / dead code
A series of unused and dead code places are fixed with the patch:
* Switch + return + break -> the break is obsolete
* A couple of 'too many arguments' when calling methods
* Various assignments of variables that are never used

Change-Id: I8472597f73a739bce053cf6de772c111ae7044d7
Resolves: #85993
Releases: master
Reviewed-on: https://review.typo3.org/58047
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2018-08-27 16:36:34 +02:00
Benni Mack
7658f63b28 [TASK] Use proper label shortcut method in adminpanel and feedit
The legacy naming for the shorthand method "extGetLL" was moved
to "getLabel" for both the edit toolbar and the EXT:feedit panel.

Resolves: #85905
Releases: master
Change-Id: I4fdad2127d40cc2850237311f3bc3f56c85ca394
Reviewed-on: https://review.typo3.org/57964
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2018-08-20 17:43:18 +02:00
Benni Mack
88cffd4747 [TASK] Extract Persistence of FrontendEditing in separate class
FrontendEditingController calls up DataHandler if the right
get/post parameters are added. This code is specific for
EXT:feedit and extracted into EXT:feedit, as FrontendEditingController
is mixing concerns (rendering panels and persisting).

Resolves: #85877
Releases: master
Change-Id: Ib39fe8b7ddcf68fb9e93d8a08564ae7f550e95f3
Reviewed-on: https://review.typo3.org/57932
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2018-08-17 12:58:11 +02:00
Benni Mack
ef7fb4a499 [TASK] Clean up FrontendEditing Controller
The FrontendEditingController class in EXT:core does two things:
- persisting incoming GET/POST requests (actually only when EXT:feedit is installed)
- rendering editIcons and editIconPanel

In order to separate these concerns, the first patch extracts some minor functionality into
EXT:feedit, and cleans up code which should have been done long ago.

The next iteration will be to deprecate unused methods and properties, and to move
FrontendEditingController into EXT:feedit, however, using an Interface to
render editIcons and editPanels instead.

Resolves: #85869
Releases: master
Change-Id: I78ed1da9e619099dc56b970961c90c34f8dff1e4
Reviewed-on: https://review.typo3.org/57925
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
2018-08-16 16:21:46 +02:00
Andreas Fernandez
3862ef8057 [TASK] Exclude TypeScript sources in exports
Since the TypeScript sources don't have any impact on the behavior of the
application and are just meant for development purpose, it's safe to
exclude these files in the packaging process.

Resolves: #85674
Releases: master
Change-Id: I599433d68834a3424e5cf7d77612d2478d46510e
Reviewed-on: https://review.typo3.org/57713
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2018-07-29 23:57:45 +02:00
Oliver Hader
5df6be9812 [TASK] Set TYPO3 version to 9.4.0-dev
Change-Id: I0281fd494612837d46966c4cdcbda5ee11c63809
Reviewed-on: https://review.typo3.org/57187
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2018-06-11 19:35:04 +02:00
Oliver Hader
280b6c3ff3 [RELEASE] Release of TYPO3 9.3.0
Change-Id: I4adf71f27e40df89bc77825e6771d5b249cf1ffd
Reviewed-on: https://review.typo3.org/57186
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2018-06-11 19:14:33 +02:00