Do not use any inline style or javascript anymore.
Instead js logic is moved to js file.
Information are passed via data attributes.
Some options are not respected anymore. That's why this change is
breaking. Those options can be considered as obsolete anyway for current
state of the art.
Those options are:
TSConfig:
* options.feedit.popupWidth
* options.feedit.popupHeight
TypoScript:
* stdWrap.editIcons.styleAttribute
Resolves: #5
Depending on frontend rendering, there is already an anchor in form of
"c<uid>" for each content element. This is added as anchor to the
returnUrls to keep context.
The browser will jump back to the content element that was modified.
This way editors keep their focus.
Resolves: #3
All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.
within
- EXT:felogin
- EXT:feedit
- EXT:filelist
- EXT:frontend
- EXT:fluid_styled_content
- EXT:impexp
All leftover @api methods have been removed.
Resolves: #86508
Releases: master
Change-Id: I97a6964a5f77dc9ee3d90365e9fda3d7d7be6266
Reviewed-on: https://review.typo3.org/58527
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
A series of unused and dead code places are fixed with the patch:
* Switch + return + break -> the break is obsolete
* A couple of 'too many arguments' when calling methods
* Various assignments of variables that are never used
Change-Id: I8472597f73a739bce053cf6de772c111ae7044d7
Resolves: #85993
Releases: master
Reviewed-on: https://review.typo3.org/58047
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
The legacy naming for the shorthand method "extGetLL" was moved
to "getLabel" for both the edit toolbar and the EXT:feedit panel.
Resolves: #85905
Releases: master
Change-Id: I4fdad2127d40cc2850237311f3bc3f56c85ca394
Reviewed-on: https://review.typo3.org/57964
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
The patch deprecates BackendUserAuthentication->getTSConfigVal()
and ->getTSConfigProp() and adapts usages to rely on getTSConfig()
without arguments. The array nesting is done directly within
consuming code and is combined with ?? to a fallback value.
Advantages:
* Expensive and recursive string operations within
getTSConfig() are not used anymore.
* The weird 'value' / 'property' based sub array
juggling is gone.
* Full TSconfig path including fallback can be easily
seen within consuming code
* Notice free array access using null coalescence operator
Change-Id: I6d5777ebd533dcfdc6018e0226bfb3e513cfa652
Resolves: #84993
Related: #84982
Releases: master
Reviewed-on: https://review.typo3.org/56953
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
The admin panel has been extracted into an own extension. To enable
users to de-activate the admin panel completely, the hard coupling
between the extension and other parts of the core had to be resolved.
With this change, the initialization of both adminPanel and feedit
were moved into PSR-15 middlewares. Additionally all parameters
related to the adminPanel were removed from the FrontendBackend-
UserAuthentication.
As feedit is tigthly coupled with the adminPanel some changes had
to be made to its initialization, too.
The flow of the adminPanel initialization and rendering were
streamlined to allow modules to make use of the request object.
Due to these changes in the control flow of the application the
two existing tests were removed and new tests will be rewritten
once the API is declared as stable.
Releases: master
Resolves: #84641
Change-Id: I72beefde0d792d3f4295c45aa27204c817d2de7a
Reviewed-on: https://review.typo3.org/56558
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Extract all admin panel code to an own extension to
reduce cross-dependencies and allow clearer scoping.
See Epic / Initiative for background.
Related: #84044Resolves: #84159
Releases: master
Change-Id: I0f6e2643746c94f0e10b87146ca7e86cbf8bc112
Reviewed-on: https://review.typo3.org/56030
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Clicking the close button in a editing popup accesses Close.html in
Resources/Public/Html/ which is a folder accessible by a web user
instead of Resources/Private/Templates/ which lead to a HTTP 403 error
on closing the popup.
Releases: master, 8.7, 7.6
Resolves: #83258
Related: #68108
Change-Id: Ibe7e328936240df436a3c9585e53122f1577dc6e
Reviewed-on: https://review.typo3.org/54983
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
The new PSR-7-based solution since TYPO3 v7 should be used everywhere
instead of "BackendUtility::getModuleUrl()". This is possible because
modules can be addressed via the "route" GET parameter instead of the
"M" parameter since a few months.
The patch changes all occurrences within TYPO3 Core to use the new API.
Resolves: #83172
Releases: master
Change-Id: Iec40e8ae00f1d900d7479b84a3a62827ddba653b
Reviewed-on: https://review.typo3.org/54755
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
The following functionality within this API class is marked as deprecated:
- siteRelPath()
- getExtensionKeyByPrefix()
- removeCacheFiles()
- second parameter of isLoaded()
Additionally, the following more strict rules apply now:
- addNavigationComponent() always requires an $extensionKey
- First parameter of addLLrefForTCAdescr() must not be empty
- addService() requires $serviceType and $info to be non-empty
- addPlugin() always requires an $extensionKey
- addStaticFile() throws exceptions if no extension key or path is set
- addTypoScript() expects $type to be either "setup" or "constants"
This is meant for extension developers using the current API more properly
than before.
Resolves: #82899
Releases: master
Change-Id: Ie5beddd4787da25f05f76ff37c6ec55a92257001
Reviewed-on: https://review.typo3.org/54523
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
The function GeneralUtility::quoteJSvalue is sometimes called
with a second parameter but it does only have on parameter.
Resolves: #79867
Releases: master
Change-Id: I994501574b798026f43a0e463a633e05ffc1cff3
Reviewed-on: https://review.typo3.org/51727
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Change string comparison for string checks. Checks which could lead
to false positives like comparing with '0' or '' are excluded.
RegEx used to find affected places: (?<=\s)((?:!|=)=)(?=[^=]'[^0-9'\n]+')
Resolves: #79540
Resolves: master
Change-Id: I9a04bdd9e0e78cc97036560709bb505097bf48f9
Reviewed-on: https://review.typo3.org/51462
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
All instances of $GLOBALS[TYPO3_DB] in the TYPO3 Core classes
except for certain highly used functionalities have been removed.
The places where the TYPO3 Core is expected to have subclasses
within extensions have been marked for deprecation.
Resolves: #78224
Releases: master
Change-Id: Ie65878264679b93940ac9fb86c4758576d98c550
Reviewed-on: https://review.typo3.org/49824
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
The method ExtensionManagementUtility::extRelPath() is marked
as deprecated, as other solutions (relative to PATH_site, absolute path resolving) should be used
in the future.
Resolves: #78193
Releases: master
Change-Id: I28cf7e1a47cb3fc8a88b0bb54d2c71a369f3d0f2
Reviewed-on: https://review.typo3.org/48915
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
As decided during T3ACME we will use the short
array syntax in master. The 7.6 branch will also be done
to make backporting easier.
Resolves: #77692
Releases: master,7.6
Change-Id: I37e9484b1012fc9161148257a842054c24d162ba
Reviewed-on: https://review.typo3.org/49651
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Use TsConfig to change the width & height of the popup used in the
edit panel of EXT:feedit.
Resolves: #18586
Releases: master
Change-Id: Ifbc7ebae75a3454fbfe9a70f0a2b4b1d95a2c094
Reviewed-on: https://review.typo3.org/48617
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Translated labels containing UTF-8 characters were double-encoded
in frontend editing.
extGetLL() already runs htmlspecialchars() on labels, so we do not have
to do that again in FrontendEditPanel.
This fixes the titles of the admin panel buttons.
Also, since we can expect all pages to be UTF-8 now, we can drop the forced
conversion of UTF-8 characters to XML entities.
This fixes the confirmation popup texts.
Resolves: #63131
Releases: master, 7.6
Change-Id: I49faff20ff4da8434868534d566c0d3da85e30c6
Reviewed-on: https://review.typo3.org/46247
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Christian Weiske <typo3@cweiske.de>
Tested-by: Christian Weiske <typo3@cweiske.de>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
This patch repairs the EditDocumentController when called by FE edit.
The main issue was that JavaScripts depends on global objects in ``top``
which are set by BackendController that is only called when one acts
in the fully bootstrapped backend view.
Resolves: #68819
Releases: master
Change-Id: I5635b32b3dada3a73d7534936e41cd94d3d10b56
Reviewed-on: https://review.typo3.org/44342
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
In our efforts to achieve a better interoperability
with other PHP projects, the PHP code base of the
TYPO3 Core switches to the PHP coding guideline
standard PSR-2.
See http://www.php-fig.org/psr/psr-2/ for more
information.
Resolves: #70515
Releases: master
Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5
Reviewed-on: http://review.typo3.org/43918
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
Deprecate the IconUtility class from EXT:backend and handle its calls
using the new IconFactory from EXT:core.
Kudos to Benjamin Kott, Stephan Großberndt, Andreas Fernandez
and Frans Saris for the great support on this big project.
Resolves: #69057
Releases: master
Change-Id: I27a045b7a3b9d31e6e3e915e1452d44af56b0cee
Reviewed-on: http://review.typo3.org/42613
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Replaces all IconUtility::getSpriteIcon calls for the icon
actions-document-new with the new IconFactory.
Resolves: #68806
Releases: master
Change-Id: Idf7ea308b316101a77c099cdba0fe7d4e8a3ee2a
Reviewed-on: http://review.typo3.org/43193
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Replaces all IconUtility::getSpriteIcon calls for the icon
actions-edit-delete with the new IconFactory.
Resolves: #69670
Releases: master
Change-Id: I719f8d78c0c9c5623f793e9d469f5595cc54127d
Reviewed-on: http://review.typo3.org/43195
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Replaces IconUtility::getSpriteIcon calls for the icon actions-document-open
which have been missed in the initial patchset with the new IconFactory.
Resolves: #68845
Releases: master
Change-Id: I7265c21ec93e1ca15869039329a86fe04e17e940
Reviewed-on: http://review.typo3.org/43192
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Replaces all IconUtility::getSpriteIcon calls for the icon
actions-edit-hide and actions-edit-unhide with the new IconFactory.
Change-Id: If3deb6fb4c6f867c21aaff34796515d933fa90c3
Resolves: #68925
Releases: master
Reviewed-on: http://review.typo3.org/42499
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Replaces all IconUtility::getSpriteIcon calls for the icon
actions-document-new with the new IconFactory.
Resolves: #68806
Releases: master
Change-Id: I6b69742494c2b16f499ce6367ccf5b689f958bad
Reviewed-on: http://review.typo3.org/42360
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
The ancient form_enctype setting was a fallback from the old days
when some hosters decided uploading files in PHP is a bad idea.
The fallback was thought to still allow casual data transfer.
This is dropped now, the setting no longer used and removed from
configuration.
Resolves: #68178
Releases: master
Change-Id: If16db4de44c0654b18efc5b1a9f0e3f46e079687
Reviewed-on: http://review.typo3.org/41314
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
To clean the typo3/ directory we move close.html
to ext:backend.
Resolves: #68108
Releases: master
Change-Id: Ieee52bd3ebea8f5c3f1c7f594d6d565864e07a76
Reviewed-on: http://review.typo3.org/41169
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
This patch replaces a lot occurrences of IconUtility::skinImg with
IconUtility::getSpriteImage or similar.
Thinks that will be ignored in this iteration:
\TYPO3\CMS\Backend\Clipboard\Clipboard::printClipboard
- Here skinImg returns just the path to use in an select option. This
is not possible with getSpriteIcon.
\TYPO3\CMS\Backend\Controller\EditDocumentController::getButtons
- Here skinImg returns just the path to use for input button. This is
not possible with getSpriteIcon.
\TYPO3\CMS\Backend\Controller\LoginController
- There is no sprite icon replacement for the TYPO3 Logo.
\TYPO3\CMS\Backend\Controller\ContentElement\
NewContentElementController::main
- No replacement for icon of content wizard availiable.
\TYPO3\CMS\Backend\Controller\Wizard\TableController
- Here skinImg returns just the path to use for input button.
\TYPO3\CMS\Backend\Form
- I cowardly refuse to touch FormEngine until Lolli is done :-)
\TYPO3\CMS\Backend\History\RecordHistory::linkPage
- No icons for revert actions.
\TYPO3\CMS\Backend\Template\DocumentTemplate::getBackendFavicon
- Here just an URL is returned.
\TYPO3\CMS\Backend\Tree\View\AbstractTreeView::getIcon
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\ElementBrowserPageTreeView::printTree
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\FolderTreeView::PMicon
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\FolderTreeView::
getBrowseableTreeForStorage
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\PagePositionMap::JSimgFunc
- Can be ignored, because this function is not used anywhere else in the
core and will be marked as deprecated within this patch.
\TYPO3\CMS\Backend\Tree\View\PagePositionMap::insertQuadLines
- There is no reasonable replacement for the halfline in the
sprite icons.
\TYPO3\CMS\Backend\View\PageLayoutView::getTable_tt_content
- No representation in sprite icons found.
\TYPO3\CMS\Backend\View\PageLayoutView::pages_getTree
- No representation in sprite icons found.
\TYPO3\CMS\Backend\View\PageTreeView
- Could not find out how to trigger that.
\ext_posMap::wrapRecordHeader (that is in
backend/Modules/Layout/index.php)
- No representation in sprite icons found.
\ext_posMap::wrapRecordHeader (that is in cms/layout/db_layout.php)
- No representation in sprite icons found.
\TYPO3\CMS\Compatibility6\Controller\Wizard\FormsController::getButtons
- Here skinImg returns just the path to use for input button.
\TYPO3\CMS\Core\Database\QueryGenerator::getFormElements
- Here skinImg returns just the path to use for input button.
\TYPO3\CMS\Core\Integrity\DatabaseIntegrityCheck::genTree
\TYPO3\CMS\Core\Integrity\DatabaseIntegrityCheck::genTree_records
- Could not find out how to trigger that.
\TYPO3\CMS\Fluid\ViewHelpers\Be\PageInfoViewHelper::render
- Could not find out how to trigger that.
\TYPO3\CMS\Impexp\ImportExport::addRelations
- This file does not exists.
\TYPO3\CMS\Impexp\LocalPageTree::ext_tree
- Could not find out how to trigger that.
typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php
- There are some dotted tree lines and blinking arrows without replacement.
\TYPO3\CMS\Reports\ViewHelpers\IconViewHelper::render
- Very generic View Helper
\TYPO3\CMS\Rtehtmlarea\BrowseLinks::getUserLinkSelectorHtml
- No representation in sprite icons found.
\TYPO3\CMS\Rtehtmlarea\PageTree::printTree
- No representation in sprite icons found.
\TYPO3\CMS\Rtehtmlarea\Controller\UserElementsController::main_user
- Could not find out how to trigger that.
\TYPO3\CMS\Taskcenter\Controller\TaskModuleController::renderListMenu
- Found no task with an individual icon file for the menu on the left
side. So could not test.
\TYPO3\CMS\Version\View\VersionView::getVersionSelector
- No representation in sprite icons found.
\TYPO3\CMS\WizardCrpages\Controller\
CreatePagesWizardModuleFunctionController::getTypeSelectHtml
- Ignored because we are not able to determain the correct sprite icon
from the TCA at this point of time.
Resolves: #65992
Releases: master
Change-Id: I1071703e8219699353a1d875a6b66a7ed51207b8
Reviewed-on: http://review.typo3.org/38132
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Since Forge issue #66052 frontend editing with feedit is not working anymore.
This is because the URL's for modules have become absolute and feedit is adding
the 'typo3' directory name in front of the module url.
This patch removes the 'typo3' directory
Change-Id: I26d2454240c0de5beb3a55e79d92614810670875
Resolves: #66266
Releases: master
Reviewed-on: http://review.typo3.org/38463
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Upon clicking the feedit edit pencil icon in frontend, the redirect
URL contains two times typo3, what leads to a wrong call to the frontend
Change-Id: I88e2584cc0dff4be6562dbda64d723e9d9bea1d0
Resolves: #66279
Relates: #66052
Releases: master
Reviewed-on: http://review.typo3.org/38490
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
In the approach to remove all occurences of dealing with
relative URL referencing in the TYPO3 Backend, the main mod.php
calls are now always prefixed with "/{possiblesubfolder/}typo3/" so
no backPath parameter and calculations are needed anymore.
The patch thus removes all locations of the JavaScript
variable "top.TS.PATH_typo3" containing the backpath and
makes the "relative" path to BackendUtility::getModuleUrl()
always a absolute prefix relative to the PATH_typo3 structure.
Resolves: #66052
Releases: master
Change-Id: Ie8192f227b8d1715be90efff8746482adf252ac7
Reviewed-on: http://review.typo3.org/38246
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
The used bitmasks of JsConfirmation and Permission are put
into "enums" and their representing constants are used instead
of the raw bitmask values.
Resolves: #65455
Releases: master
Change-Id: I1910bb960b69836ea29c16c91d730ac74c22f929
Reviewed-on: http://review.typo3.org/37455
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
In some cases makeInstance is used with strings instead
of ::class. This patch fix it.
Resolves: #65704
Releases: master
Change-Id: I69afa653f50efbebaa7456acfb5d20f401e639fb
Reviewed-on: http://review.typo3.org/37798
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Use dispatching for db_new.php
Resolves: #65288
Releases: master
Change-Id: Ie3ef5c8e4df8dc0181ed5e85dd780c769c2801ca
Reviewed-on: http://review.typo3.org/37479
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
