The TYPO3 Core currently has no guidline how to handle phpdoc
comments regarding @return annoations related to "void" and "null".
In practice, these annotations have no additional value if no additional
documentation is given.
With this change, the php-cs-fixer will remove any unnecessary linebreaks
within the comments above the @return annotation, as well as remove completely
empty phpdoc comments because the @return annotation is removed.
Please be aware, that once PSR-5 is accepted, this coding standard
within the TYPO3 Core will change again, where there are currently
some further proposal details like inheritance information.
Resolves: #80454
Releases: master
Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04
Reviewed-on: https://review.typo3.org/51686
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
This patch moves frontend-editing intialisation from the
EditDocumentController (EXT:backend) to a signal listener
in EXT:feedit. Step towards extracting EXT:feedit to TER.
Change-Id: I09a7e5a2205e7020e7145023d7d63c61d9be508c
Resolves: #80244
Releases: master
Reviewed-on: https://review.typo3.org/52011
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
The function GeneralUtility::quoteJSvalue is sometimes called
with a second parameter but it does only have on parameter.
Resolves: #79867
Releases: master
Change-Id: I994501574b798026f43a0e463a633e05ffc1cff3
Reviewed-on: https://review.typo3.org/51727
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Change string comparison for string checks. Checks which could lead
to false positives like comparing with '0' or '' are excluded.
RegEx used to find affected places: (?<=\s)((?:!|=)=)(?=[^=]'[^0-9'\n]+')
Resolves: #79540
Resolves: master
Change-Id: I9a04bdd9e0e78cc97036560709bb505097bf48f9
Reviewed-on: https://review.typo3.org/51462
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
All extension icons of all system and test extensions shipped with
the core are now located at EXT:.../Resources/Public/Icons/Extension.*
instead of ext_icon.gif.
This is one further step to make it possible to publish only public
assets of an extension to the htdocs/ folder.
Resolves: #78334
Releases: master
Change-Id: Ic65036bb74d4a156c1a0a9fdfa0c8d4b5a28e9ed
Reviewed-on: https://review.typo3.org/50233
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
All instances of $GLOBALS[TYPO3_DB] in the TYPO3 Core classes
except for certain highly used functionalities have been removed.
The places where the TYPO3 Core is expected to have subclasses
within extensions have been marked for deprecation.
Resolves: #78224
Releases: master
Change-Id: Ie65878264679b93940ac9fb86c4758576d98c550
Reviewed-on: https://review.typo3.org/49824
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
The method ExtensionManagementUtility::extRelPath() is marked
as deprecated, as other solutions (relative to PATH_site, absolute path resolving) should be used
in the future.
Resolves: #78193
Releases: master
Change-Id: I28cf7e1a47cb3fc8a88b0bb54d2c71a369f3d0f2
Reviewed-on: https://review.typo3.org/48915
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
As decided during T3ACME we will use the short
array syntax in master. The 7.6 branch will also be done
to make backporting easier.
Resolves: #77692
Releases: master,7.6
Change-Id: I37e9484b1012fc9161148257a842054c24d162ba
Reviewed-on: https://review.typo3.org/49651
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Use TsConfig to change the width & height of the popup used in the
edit panel of EXT:feedit.
Resolves: #18586
Releases: master
Change-Id: Ifbc7ebae75a3454fbfe9a70f0a2b4b1d95a2c094
Reviewed-on: https://review.typo3.org/48617
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Translated labels containing UTF-8 characters were double-encoded
in frontend editing.
extGetLL() already runs htmlspecialchars() on labels, so we do not have
to do that again in FrontendEditPanel.
This fixes the titles of the admin panel buttons.
Also, since we can expect all pages to be UTF-8 now, we can drop the forced
conversion of UTF-8 characters to XML entities.
This fixes the confirmation popup texts.
Resolves: #63131
Releases: master, 7.6
Change-Id: I49faff20ff4da8434868534d566c0d3da85e30c6
Reviewed-on: https://review.typo3.org/46247
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Christian Weiske <typo3@cweiske.de>
Tested-by: Christian Weiske <typo3@cweiske.de>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
This patch repairs the EditDocumentController when called by FE edit.
The main issue was that JavaScripts depends on global objects in ``top``
which are set by BackendController that is only called when one acts
in the fully bootstrapped backend view.
Resolves: #68819
Releases: master
Change-Id: I5635b32b3dada3a73d7534936e41cd94d3d10b56
Reviewed-on: https://review.typo3.org/44342
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
In our efforts to achieve a better interoperability
with other PHP projects, the PHP code base of the
TYPO3 Core switches to the PHP coding guideline
standard PSR-2.
See http://www.php-fig.org/psr/psr-2/ for more
information.
Resolves: #70515
Releases: master
Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5
Reviewed-on: http://review.typo3.org/43918
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
Since http://typo3.org has been changed to https, adopt all links
in the core as well. Replace some outdated links to newer once
(if it could be replaced).
Resolves: #69989
Releases: master
Change-Id: I5d612b3b01cb75b613483649e8c754336c0fe516
Reviewed-on: http://review.typo3.org/43459
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Josef Glatz <jousch@gmail.com>
Tested-by: Josef Glatz <jousch@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Deprecate the IconUtility class from EXT:backend and handle its calls
using the new IconFactory from EXT:core.
Kudos to Benjamin Kott, Stephan Großberndt, Andreas Fernandez
and Frans Saris for the great support on this big project.
Resolves: #69057
Releases: master
Change-Id: I27a045b7a3b9d31e6e3e915e1452d44af56b0cee
Reviewed-on: http://review.typo3.org/42613
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Replaces all IconUtility::getSpriteIcon calls for the icon
actions-document-new with the new IconFactory.
Resolves: #68806
Releases: master
Change-Id: Idf7ea308b316101a77c099cdba0fe7d4e8a3ee2a
Reviewed-on: http://review.typo3.org/43193
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Replaces all IconUtility::getSpriteIcon calls for the icon
actions-edit-delete with the new IconFactory.
Resolves: #69670
Releases: master
Change-Id: I719f8d78c0c9c5623f793e9d469f5595cc54127d
Reviewed-on: http://review.typo3.org/43195
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Replaces IconUtility::getSpriteIcon calls for the icon actions-document-open
which have been missed in the initial patchset with the new IconFactory.
Resolves: #68845
Releases: master
Change-Id: I7265c21ec93e1ca15869039329a86fe04e17e940
Reviewed-on: http://review.typo3.org/43192
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
This resolves problems with composer dependencies and Extension name /
Composer package name differences.
Resolves: #68700
Releases: master
Change-Id: I07f57f24ef7e9337e7ef8f6ee69538c038f2c0ff
Reviewed-on: http://review.typo3.org/42615
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Replaces all IconUtility::getSpriteIcon calls for the icon
actions-edit-hide and actions-edit-unhide with the new IconFactory.
Change-Id: If3deb6fb4c6f867c21aaff34796515d933fa90c3
Resolves: #68925
Releases: master
Reviewed-on: http://review.typo3.org/42499
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Replaces all IconUtility::getSpriteIcon calls for the icon
actions-document-new with the new IconFactory.
Resolves: #68806
Releases: master
Change-Id: I6b69742494c2b16f499ce6367ccf5b689f958bad
Reviewed-on: http://review.typo3.org/42360
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
The ancient form_enctype setting was a fallback from the old days
when some hosters decided uploading files in PHP is a bad idea.
The fallback was thought to still allow casual data transfer.
This is dropped now, the setting no longer used and removed from
configuration.
Resolves: #68178
Releases: master
Change-Id: If16db4de44c0654b18efc5b1a9f0e3f46e079687
Reviewed-on: http://review.typo3.org/41314
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
To clean the typo3/ directory we move close.html
to ext:backend.
Resolves: #68108
Releases: master
Change-Id: Ieee52bd3ebea8f5c3f1c7f594d6d565864e07a76
Reviewed-on: http://review.typo3.org/41169
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
The md5 value is not handled in core for quite a while
and removed together with some obsolete locallang flags
and further test related ext_emconf settings.
Resolves: #67979
Releases: master
Change-Id: I86804f732f7f32cf94aab7d18dfab79cdf67e458
Reviewed-on: http://review.typo3.org/41005
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
This patch replaces a lot occurrences of IconUtility::skinImg with
IconUtility::getSpriteImage or similar.
Thinks that will be ignored in this iteration:
\TYPO3\CMS\Backend\Clipboard\Clipboard::printClipboard
- Here skinImg returns just the path to use in an select option. This
is not possible with getSpriteIcon.
\TYPO3\CMS\Backend\Controller\EditDocumentController::getButtons
- Here skinImg returns just the path to use for input button. This is
not possible with getSpriteIcon.
\TYPO3\CMS\Backend\Controller\LoginController
- There is no sprite icon replacement for the TYPO3 Logo.
\TYPO3\CMS\Backend\Controller\ContentElement\
NewContentElementController::main
- No replacement for icon of content wizard availiable.
\TYPO3\CMS\Backend\Controller\Wizard\TableController
- Here skinImg returns just the path to use for input button.
\TYPO3\CMS\Backend\Form
- I cowardly refuse to touch FormEngine until Lolli is done :-)
\TYPO3\CMS\Backend\History\RecordHistory::linkPage
- No icons for revert actions.
\TYPO3\CMS\Backend\Template\DocumentTemplate::getBackendFavicon
- Here just an URL is returned.
\TYPO3\CMS\Backend\Tree\View\AbstractTreeView::getIcon
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\ElementBrowserPageTreeView::printTree
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\FolderTreeView::PMicon
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\FolderTreeView::
getBrowseableTreeForStorage
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\PagePositionMap::JSimgFunc
- Can be ignored, because this function is not used anywhere else in the
core and will be marked as deprecated within this patch.
\TYPO3\CMS\Backend\Tree\View\PagePositionMap::insertQuadLines
- There is no reasonable replacement for the halfline in the
sprite icons.
\TYPO3\CMS\Backend\View\PageLayoutView::getTable_tt_content
- No representation in sprite icons found.
\TYPO3\CMS\Backend\View\PageLayoutView::pages_getTree
- No representation in sprite icons found.
\TYPO3\CMS\Backend\View\PageTreeView
- Could not find out how to trigger that.
\ext_posMap::wrapRecordHeader (that is in
backend/Modules/Layout/index.php)
- No representation in sprite icons found.
\ext_posMap::wrapRecordHeader (that is in cms/layout/db_layout.php)
- No representation in sprite icons found.
\TYPO3\CMS\Compatibility6\Controller\Wizard\FormsController::getButtons
- Here skinImg returns just the path to use for input button.
\TYPO3\CMS\Core\Database\QueryGenerator::getFormElements
- Here skinImg returns just the path to use for input button.
\TYPO3\CMS\Core\Integrity\DatabaseIntegrityCheck::genTree
\TYPO3\CMS\Core\Integrity\DatabaseIntegrityCheck::genTree_records
- Could not find out how to trigger that.
\TYPO3\CMS\Fluid\ViewHelpers\Be\PageInfoViewHelper::render
- Could not find out how to trigger that.
\TYPO3\CMS\Impexp\ImportExport::addRelations
- This file does not exists.
\TYPO3\CMS\Impexp\LocalPageTree::ext_tree
- Could not find out how to trigger that.
typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php
- There are some dotted tree lines and blinking arrows without replacement.
\TYPO3\CMS\Reports\ViewHelpers\IconViewHelper::render
- Very generic View Helper
\TYPO3\CMS\Rtehtmlarea\BrowseLinks::getUserLinkSelectorHtml
- No representation in sprite icons found.
\TYPO3\CMS\Rtehtmlarea\PageTree::printTree
- No representation in sprite icons found.
\TYPO3\CMS\Rtehtmlarea\Controller\UserElementsController::main_user
- Could not find out how to trigger that.
\TYPO3\CMS\Taskcenter\Controller\TaskModuleController::renderListMenu
- Found no task with an individual icon file for the menu on the left
side. So could not test.
\TYPO3\CMS\Version\View\VersionView::getVersionSelector
- No representation in sprite icons found.
\TYPO3\CMS\WizardCrpages\Controller\
CreatePagesWizardModuleFunctionController::getTypeSelectHtml
- Ignored because we are not able to determain the correct sprite icon
from the TCA at this point of time.
Resolves: #65992
Releases: master
Change-Id: I1071703e8219699353a1d875a6b66a7ed51207b8
Reviewed-on: http://review.typo3.org/38132
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Since Forge issue #66052 frontend editing with feedit is not working anymore.
This is because the URL's for modules have become absolute and feedit is adding
the 'typo3' directory name in front of the module url.
This patch removes the 'typo3' directory
Change-Id: I26d2454240c0de5beb3a55e79d92614810670875
Resolves: #66266
Releases: master
Reviewed-on: http://review.typo3.org/38463
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Upon clicking the feedit edit pencil icon in frontend, the redirect
URL contains two times typo3, what leads to a wrong call to the frontend
Change-Id: I88e2584cc0dff4be6562dbda64d723e9d9bea1d0
Resolves: #66279
Relates: #66052
Releases: master
Reviewed-on: http://review.typo3.org/38490
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
In the approach to remove all occurences of dealing with
relative URL referencing in the TYPO3 Backend, the main mod.php
calls are now always prefixed with "/{possiblesubfolder/}typo3/" so
no backPath parameter and calculations are needed anymore.
The patch thus removes all locations of the JavaScript
variable "top.TS.PATH_typo3" containing the backpath and
makes the "relative" path to BackendUtility::getModuleUrl()
always a absolute prefix relative to the PATH_typo3 structure.
Resolves: #66052
Releases: master
Change-Id: Ie8192f227b8d1715be90efff8746482adf252ac7
Reviewed-on: http://review.typo3.org/38246
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
The used bitmasks of JsConfirmation and Permission are put
into "enums" and their representing constants are used instead
of the raw bitmask values.
Resolves: #65455
Releases: master
Change-Id: I1910bb960b69836ea29c16c91d730ac74c22f929
Reviewed-on: http://review.typo3.org/37455
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
