The used bitmasks of JsConfirmation and Permission are put
into "enums" and their representing constants are used instead
of the raw bitmask values.
Resolves: #65455
Releases: master
Change-Id: I1910bb960b69836ea29c16c91d730ac74c22f929
Reviewed-on: http://review.typo3.org/37455
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
In some cases makeInstance is used with strings instead
of ::class. This patch fix it.
Resolves: #65704
Releases: master
Change-Id: I69afa653f50efbebaa7456acfb5d20f401e639fb
Reviewed-on: http://review.typo3.org/37798
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Use dispatching for db_new.php
Resolves: #65288
Releases: master
Change-Id: Ie3ef5c8e4df8dc0181ed5e85dd780c769c2801ca
Reviewed-on: http://review.typo3.org/37479
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Refactor the code to go green in PHPStorm.
Main tasks:
* Initialize variables
* Centralize objects in $GLOBALS
Resolves: #62691
Releases: master
Change-Id: Iaf4659bc9ef4cdeffbccd53fde2969a9b4c592c4
Reviewed-on: http://review.typo3.org/33785
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
In order to deliver more information
in custom installations for use with composer,
the namespaces for using the composer
autoloader are added to each composer.json
of all system extensions.
Releases: master, 6.2
Resolves: #64356
Change-Id: Ic0fa9e0969a48f68cce8ceeb77dbef3b75e6e6f1
Reviewed-on: http://review.typo3.org/36076
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
It is faster to compare a string with === '' to find out if it's empty
than to run strlen() on it.
The replacement rules are applied as follows:
* if (strlen($str))
=> if ((string)$str !== '')
* if (!is_string($str) || strlen($str) === 0)
=> if (!is_string($str) || $str === '')
* If it can be seen easily that $str is a string,
the typecast is omitted.
Change-Id: I888d70e42f925bd57ad23b873b72d6a38acb39ef
Resolves: #54091
Releases: master
Reviewed-on: http://review.typo3.org/27794
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
At the moment in some classes you can find an empty line between the
copyright comment and the first use statement. In some (far less) other
classes there is no such empty line.
This commit adds an empty line between those comments if there is no
empty line.
This is not part of the TYPO3 CMS CGL but increases consistency in this
area.
This regular expression was used to add the empty lines:
Search:
( \* The TYPO3 project - inspiring people to share!\n \*/\n)(use )
Replace:
$1\n$2
Resolves: #63829
Releases: master
Change-Id: I4b28a1cfcfc727016ac5d89b3988d236270f37e2
Reviewed-on: http://review.typo3.org/35391
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
This regular expression was used to replace PHPDoc style comments
with ordinary comments:
Search:
/\*\*(\n \* This file is part of the TYPO3 CMS project.)
Replace with:
/*$1
Resolves: #63328
Releases: master
Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8
Reviewed-on: http://review.typo3.org/35103
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
* Restore edit_editNoPopup/forceNoPopup TSConfig options removed in #49640
* Initialize frontend editing when displayFieldEditIcons is set
Releases: master, 6.2
Resolves: #61095
Related: #43447
Related: #49640
Change-Id: I900a62b447a1a67265ce22cd73e150646344e090
Reviewed-on: http://review.typo3.org/32279
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
(part for extensions starting with "d" to "v")
Use name-resolution with ...::class instead of strings where
possible.
(needs PHP 5.5, which is meanwhile required for master)
Change-set Iedbb896607adddce2b23ab67f990fa2296c0d1bb
first introduced usage of ::class in master. We now add it
in various more places.
Change-Id: Idd4dbb32c5e7be1fc566a65cb729a684de003056
Resolves: #63477
Releases: master
Reviewed-on: http://review.typo3.org/34872
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
The classAliasMaps in all the extension starting from extension manager
to workspace have being moved into compatibility6 extension.
Resolves: #62990
Related: #62013
Releases: master
Change-Id: If057396eae493e7345c31d2e7f7da6061f1a6e81
Reviewed-on: http://review.typo3.org/34238
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Since PHP 5.5 is a requirement, calls to GeneralUtility::makeInstance()
should use the ::class construct instead of a string argument.
Releases: master
Resolves: #61788
Change-Id: Ia2efc5a4cb7ecea80b8a1c8e5ff7b5d6fa9a07ce
Reviewed-on: http://review.typo3.org/32913
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
* Use bool in @return
* Use int in @return
* Use bool in @param
* Use int in @param
* Remove extra tabs and spaces in @param
Resolves: #62506
Releases: master
Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2
Reviewed-on: http://review.typo3.org/33577
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Update version number of all sysext and dependency definitions.
Resolves: #62341
Releases: master
Change-Id: Ic8b1b8ead08432917a28b226bbb43347dac42087
Reviewed-on: http://review.typo3.org/33395
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
The "do not touch me" comment header in ext_emconf.php files
of system extensions are misleading since we are editing those
files manually for years now. Remove those headers.
Change-Id: I27f6253effa54dae7f92170175e7705cc706d03a
Resolves: #60129
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31405
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Quite some keys in ext_emconf are obsolete and can be removed.
See related issue for a list of keys.
Change-Id: Id12c2e3d61569cc1e84226ef75120ae4261922fb
Resolves: #60128
Related: #58365
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31397
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Several classes include unused use statements. This patch removes those
statements or uses them in their code.
Resolves: #59997
Releases: 6.3
Change-Id: I5890a80bcee96976e3c35d967db8c53a9c11b002
Reviewed-on: https://review.typo3.org/31245
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.
This is a multi-part commit due to the huge number of changed files.
See issue #59781 for further details.
Resolves: #59781
Releases: 6.3, 6.2
Change-Id: I7429b8e9c507a4833215750268d1975402679828
Reviewed-on: https://review.typo3.org/31026
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein
This patch changes the file permissions, so we need to work
some more on it.
This reverts commit 03cf03b28f7f37cab14f2467f6ad1c3134ae5fa4
Change-Id: I21343c8273db1e5173d6b8211cc2fed510e9810e
Reviewed-on: https://review.typo3.org/29828
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reduce the file size without losing quality.
This reduces total typo3 directory size by ~2 MB.
Resolves: #58110
Releases: 6.2
Change-Id: I2062cead3939d93b847f1be741ef8a26bfb0edd8
Reviewed-on: https://review.typo3.org/29617
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Tested-by: Nadir S.
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
The historical option "wide document" can
be safely removed, as the wide screen options
from 10 years ago are default by now.
Resolves: #57295
Releases: 6.2
Change-Id: I0e5c81046733f4ddd10cc7d084f0ef7b952c3cb0
Reviewed-on: https://review.typo3.org/28769
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
As TYPO3 is loading all ext_localconf.php on each call,
the existing code can be cleaned up by removing
old information, putting BE-only functionality in
TYPO3_MODE == 'BE' and install-tool only
in Install only mode.
Also, some hardcoded require_once statements are
removed.
Benefits are that FE does not need to load everything
all the time.
I haven't noticed any side-effects so far, but please
test extensively.
Resolves: #55593
Releases: 6.2
Change-Id: Ibc37e84cb2af05ddb6b227290330aad31037a018
Reviewed-on: https://review.typo3.org/27286
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Use native PHP-functionality provided by htmlspecialchars()
with a parameter since PHP 5.2.3 to prevent double-encoding
instead of calling deHSCentities().
Change-Id: I2863181259046f16b554770a3f1ed8b03112fedf
Resolves: #50449
Releases: 6.2
Reviewed-on: https://review.typo3.org/22580
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Pascal Dürsteler
Reviewed-by: Stefan Froemken
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
A large number of files were stored with executable permissions. This
may be a (minor) security risk and can be confusing. The patch removes
the executable permissions on all files but:
* typo3/cli_dispatch.phpsh
* typo3/cleaner_check.sh
* typo3/cleaner_fix.sh
Resolves: #56571
Releases: 6.2
Change-Id: Ib6a9fb19fe716d7d5405d5a7120b50269bdbf5f8
Reviewed-on: https://review.typo3.org/28072
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Resolves: #53753
Releases: 6.2
Change-Id: I3acb81c71796bc84ada29e6cdf6141be07f69ca3
Reviewed-on: https://review.typo3.org/25503
Reviewed-by: Christian Opitz
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
This reverts commit de27a20afbd8f413f60029afc5622c7b33212322
Change-Id: I078d2f7bbff605c91d83a9853e8feb9c31d57ccc
Reviewed-on: https://review.typo3.org/27792
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
It is faster to compare a string with === '' to find out if it's empty
than to run strlen() on it.
The replacement rules are applied as follows:
* if (strlen($str))
=> if ((string)$str !== '')
* if (!is_string($str) || strlen($str) === 0)
=> if (!is_string($str) || $str === '')
* If it can be seen easily that $str is a string,
the typecast is omitted.
Resolves: #54091
Releases: 6.2
Change-Id: I59c5cbccea4f98b8f282377e6aa67d970859a457
Reviewed-on: https://review.typo3.org/27091
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
This patch replaces most of around 1600 occurrences of
intval() and every (integer) in the whole core.
Additionally it changes GeneralUtility::intExplode to use references
and typecasting as well.
Some occurrences of strstr() together with intval() have been replaced
with strpos() as well.
And some superfluous intval calls have been removed or reduced
to a single one i.e. for protected variables or before loops.
Patch updated after Core CGL decision from 30.01.2014
Resolves: #54265
Releases: 6.2
Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8
Reviewed-on: https://review.typo3.org/26740
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
The frontend editing + admin panel needs some polishing.
Following changes are included:
General
=======
- Reformat code
- Use Sprite API which means using the correct icons
Admin Panel
==============
- Add missing translations
- Show "Simulate usergroup" only if usergroups are available
- Remove "Total page count" in Info Tab as information is wrong
(counting images + document is not the total page size)
Frontend Editing
=================
- Remove "edit_editNoPopup", "forceNoPopup", "editFormsOnPage"
for direct inline editing
- Remove setting "previewBorder" which is not needed and looks just ugly
Releases: 6.2
Resolves: #49640
Change-Id: I35f88bc4e8c138fc21b74c0448b2f3892ab61918
Reviewed-on: https://review.typo3.org/21859
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
The current composer type of system extensions is "typo3cms-framework".
In the composer installer for TYPO3 CMS the composer type of extensions
is "typo3-cms-extension". In order to align our composer type with the
community defined it is changed to "typo3-cms-framework".
Resolves: #52831
Releases: 6.2
Change-Id: I1f43a60bd4cf59b47163123b57c8ba09e35e6526
Reviewed-on: https://review.typo3.org/24780
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Change-Id: Iaf88fc46903400d97f6f1dc3acedb3c9b438e8dd
Releases: 6.2
Resolves: #52740
Related: #47018
Reviewed-on: https://review.typo3.org/24667
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Make use of boolean value TRUE as second parameter in sL function.
Change-Id: I6d77affc4f3ff260f617ca67c773fc4ca2e481ce
Resolves: #51143
Releases: 6.2
Reviewed-on: https://review.typo3.org/23153
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
This catches most old empty class files from ext:cms. The rest
needs to be taken care of in single patches.
The patch also changes all old mentions of the old class names,
mostly comments are affected.
Change-Id: I2b8ebfad178001c7bc8def967c01a56ae113c029
Resolves: #47792
Related: #47756
Releases: 6.2
Reviewed-on: https://review.typo3.org/20381
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
System extensions are shipped with the same version number as the TYPO3 release they belong with. Also the dependency should be sett accordingly to make clear they are not to be used with other releases.
Change-Id: I575e19bb2f2c1d0a6ee27753ec2e05dee1b2e42e
Fixes: #47644
Releases: 6.2
Reviewed-on: https://review.typo3.org/20234
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reduce the severity if an internal flag is set and the a backend user
is logged in.
Resolves: #43735
Related: #43506
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: Ifd78f67d38b87180ab60df05167974705ee90352
Reviewed-on: https://review.typo3.org/17020
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Some core parts still mention t3lib classes after namespaces,
mostly in comments.
Resolves: #47138
Releases: 6.1
Change-Id: I0775fc10f8c901a02533e5bc0fe1c6aa2276758b
Reviewed-on: https://review.typo3.org/19803
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
The core still access xliff language files as .php or .xml,
although the files themselves are converted to .xlf since quite
some time. This could cause confusion.
This is a cleanup taken all .xlf files in the EXT:lang/.xlf
directory and run via a sed script (thanks to Stucki)
Resolves: #46940
Releases: 6.1
Change-Id: I427776b176ba2c23678689029eaf388dff90d0fa
Reviewed-on: https://review.typo3.org/19579
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
The serialized array _md5_values_when_last_written is not
maintained for core extensions since ages and just contains
a long string with outdated information.
It is set to an empty string now.
Change-Id: Iae1de150dd0da4ef9ccd993bdc0e75e5eb4c62c1
Resolves: #46699
Releases: 6.1
Reviewed-on: https://review.typo3.org/19322
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
In this patch are also some fixes for files containing
a interface. Due the namespace change all interfaces
have the curly bracket not on the same line as the
interface name.
Change-Id: I64ba45de73693452d681ce7f018965968b11d2af
Resolves: #46370
Releases: 6.1
Reviewed-on: https://review.typo3.org/18984
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
