Commit graph

18 commits

Author SHA1 Message Date
Markus Klein
36db0437f7 [CLEANUP] Replace strlen() with === for zero length check
It is faster to compare a string with === '' to find out if it's empty
than to run strlen() on it.

The replacement rules are applied as follows:
 *    if (strlen($str))
   => if ((string)$str !== '')
 *    if (!is_string($str) || strlen($str) === 0)
   => if (!is_string($str) || $str === '')
 * If it can be seen easily that $str is a string,
   the typecast is omitted.

Resolves: #54091
Releases: 6.2
Change-Id: I59c5cbccea4f98b8f282377e6aa67d970859a457
Reviewed-on: https://review.typo3.org/27091
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
2014-02-23 11:24:30 +01:00
Jo Hasenau
7e04633b0d [TASK] Use (int) instead of intval() or (integer)
This patch replaces most of around 1600 occurrences of
intval() and every (integer) in the whole core.
Additionally it changes GeneralUtility::intExplode to use references
and typecasting as well.
Some occurrences of strstr() together with intval() have been replaced
with strpos() as well.
And some superfluous intval calls have been removed or reduced
to a single one i.e. for protected variables or before loops.
Patch updated after Core CGL decision from 30.01.2014

Resolves: #54265
Releases: 6.2
Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8
Reviewed-on: https://review.typo3.org/26740
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
2014-02-01 22:13:21 +01:00
Roland Waldner
1bdc11c091 [TASK] Fix typo in copyright notice
"textfile" will be replaced by "text file"

Resolves: #54893
Releases: 6.2
Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b
Reviewed-on: https://review.typo3.org/26736
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
2014-01-13 22:19:00 +01:00
Georg Ringer
bfa7649317 [TASK] Improve feedit
The frontend editing + admin panel needs some polishing.
Following changes are included:

General
=======
- Reformat code
- Use Sprite API which means using the correct icons

Admin Panel
==============
- Add missing translations
- Show "Simulate usergroup" only if usergroups are available
- Remove "Total page count" in Info Tab as information is wrong
  (counting images + document is not the total page size)

Frontend Editing
=================
- Remove "edit_editNoPopup", "forceNoPopup", "editFormsOnPage"
  for direct inline editing
- Remove setting "previewBorder" which is not needed and looks just ugly

Releases: 6.2
Resolves: #49640
Change-Id: I35f88bc4e8c138fc21b74c0448b2f3892ab61918
Reviewed-on: https://review.typo3.org/21859
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
2014-01-09 19:56:56 +01:00
Christian Kuhn
8e70861212 [TASK] Remove closing PHP tags
Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b
Resolves: #52360
Releases: 6.2
Reviewed-on: https://review.typo3.org/24212
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
2013-10-01 15:15:19 +02:00
Wouter Wolters
3e97a5544d [TASK] Use real boolean value for sL second param
Make use of boolean value TRUE as second parameter in sL function.

Change-Id: I6d77affc4f3ff260f617ca67c773fc4ca2e481ce
Resolves: #51143
Releases: 6.2
Reviewed-on: https://review.typo3.org/23153
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
2013-08-18 14:21:10 +02:00
Stefan Neufeind
50e13164be [TASK] Namespacing: Use-statement for common classes like GeneralUtility
Change-Id: I43d6ef559b0b46e6302ea891b4d39501a99423a6
Resolves: #49745
Releases: 6.2
Reviewed-on: https://review.typo3.org/22041
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
2013-07-07 02:07:53 +02:00
Christian Kuhn
87efbbf63b [TASK] Remove dummy files from ext:cms
This catches most old empty class files from ext:cms. The rest
needs to be taken care of in single patches.
The patch also changes all old mentions of the old class names,
mostly comments are affected.

Change-Id: I2b8ebfad178001c7bc8def967c01a56ae113c029
Resolves: #47792
Related: #47756
Releases: 6.2
Reviewed-on: https://review.typo3.org/20381
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
2013-05-01 19:46:02 +02:00
Georg Ringer
ab7c33b3a5 [TASK] Reduce severity for set_no_cache() from core
Reduce the severity if an internal flag is set and the a backend user
is logged in.

Resolves: #43735
Related: #43506
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: Ifd78f67d38b87180ab60df05167974705ee90352
Reviewed-on: https://review.typo3.org/17020
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
2013-04-24 20:42:52 +02:00
Christian Kuhn
08b211a800 [TASK] Update t3lib mentions
Some core parts still mention t3lib classes after namespaces,
mostly in comments.

Resolves: #47138
Releases: 6.1

Change-Id: I0775fc10f8c901a02533e5bc0fe1c6aa2276758b
Reviewed-on: https://review.typo3.org/19803
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
2013-04-11 20:38:21 +02:00
Benjamin Mack
1c9c5af29e [TASK] XLF core locallang files are still referenced with .php/.xml
The core still access xliff language files as .php or .xml,
although the files themselves are converted to .xlf since quite
some time. This could cause confusion.

This is a cleanup taken all .xlf files in the EXT:lang/.xlf
directory and run via a sed script (thanks to Stucki)

Resolves: #46940
Releases: 6.1
Change-Id: I427776b176ba2c23678689029eaf388dff90d0fa
Reviewed-on: https://review.typo3.org/19579
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
2013-04-06 20:40:27 +02:00
Wouter Wolters
94ee1b13c8 [TASK] Update copyright year to 2013
In this patch are also some fixes for files containing
a interface. Due the namespace change all interfaces
have the curly bracket not on the same line as the
interface name.

Change-Id: I64ba45de73693452d681ce7f018965968b11d2af
Resolves: #46370
Releases: 6.1
Reviewed-on: https://review.typo3.org/18984
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
2013-03-19 02:28:14 +01:00
Wouter Wolters
13474e3455 [TASK] Cleanup feedit
Change-Id: I8eca6524c69ee71973411b4b791ee7b33bdcda82
Resolves: #45116
Releases: 6.1
Reviewed-on: https://review.typo3.org/17985
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
2013-02-04 13:35:31 +01:00
Philipp Gampe
948dd11478 [TASK] Provide a reason if set_no_cache() is called
Since #20849, we can specify a reason why we call
GLOBALS['TSFE']->set_no_cache().

Provide a reason for all calls done in core.

Resolves: #43506
Related: #20849
Releases: 6.1

Change-Id: Id786a041ef5d9f1db49d644459a593aaf54b5018
Reviewed-on: http://review.typo3.org/16925
Reviewed-by: Stefan Neufeind
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
2012-12-07 09:34:58 +01:00
Christian Kuhn
05ca4e2563 [TASK] Remove @package and @subpackage annotations
With namespaces the @package and @subpackage annotations
do not have a real benefit anymore and can be removed.

Change-Id: Id8f4718db0c1c51ae5143a3353dd5efb42dadf70
Resolves: #43019
Releases: 6.0
Reviewed-on: http://review.typo3.org/16474
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
2012-11-16 13:01:03 +01:00
Markus Klein
f264beb6e3 [CLEANUP] Remove all occurrences of edit_showFieldHelp == 'text'
The text version of edit_showFieldHelp is not supported since 4.5
anymore. This patch removes all references and dead code.

Resolves: #24623
Releases: 6.0

Change-Id: Idb915f4dbaba8ee0690c06fddcace4d0d4ad6813
Reviewed-on: http://review.typo3.org/14950
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
2012-09-23 00:15:01 +02:00
Arvid Jakobsson
0dcb973b0f [TASK] Remove superfluous parens in sysexts css_styled_content - feedit
Removes superfluous parenthesis in sysexts "css_styled_content",
"extensionmanager", "extra_page_cm_options" and "feedit".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I9ec62d6b2782e349cef447c7a9c87f4a4fbc2585
Resolves: #40964
Related: #40095
Reviewed-on: http://review.typo3.org/14623
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
2012-09-17 21:57:04 +02:00
Felix Kopp
adfd45134d [BUGFIX] Namespace: Revert extension split-up: feedit
Reverts the split-up for the extension reedit:
Erroneous extKey was 'fe_edit'.

Also fixes minor CGL.

Change-Id: If727b7ffcefdd1fb917fc15d48b91e549f5b79b9
Releases: 6.0
Fixes: #40174
Related: #40095
Reviewed-on: http://review.typo3.org/14073
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
2012-08-25 16:12:15 +02:00