Commit graph

212 commits

Author SHA1 Message Date
Frank Nägler
12c9393fad [TASK] Call explicit render() on icon objects
Resolves: #70417
Releases: master
Change-Id: Ie855b996636b749562acf3baa67b1756c2ad3db2
Reviewed-on: http://review.typo3.org/43826
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2015-10-05 21:39:39 +02:00
Wouter Wolters
f6adbf7145 [TASK] Update TYPO3 version to TYPO3 7.6-dev
Releases: master
Change-Id: Ic9608e3c91abe435beefc595a33f537f777f4446
Reviewed-on: http://review.typo3.org/43626
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2015-09-29 14:53:17 +02:00
Josef Glatz
35617cc998 [TASK] Change typo3.org links to https
Since http://typo3.org has been changed to https, adopt all links
in the core as well. Replace some outdated links to newer once
(if it could be replaced).

Resolves: #69989
Releases: master
Change-Id: I5d612b3b01cb75b613483649e8c754336c0fe516
Reviewed-on: http://review.typo3.org/43459
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Josef Glatz <jousch@gmail.com>
Tested-by: Josef Glatz <jousch@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2015-09-23 16:17:06 +02:00
Frank Nägler
04220f5d9f [!!!][TASK] Deprecate IconUtility
Deprecate the IconUtility class from EXT:backend and handle its calls
using the new IconFactory from EXT:core.

Kudos to Benjamin Kott, Stephan Großberndt, Andreas Fernandez
and Frans Saris for the great support on this big project.

Resolves: #69057
Releases: master
Change-Id: I27a045b7a3b9d31e6e3e915e1452d44af56b0cee
Reviewed-on: http://review.typo3.org/42613
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2015-09-22 16:23:15 +02:00
Morton Jonuschat
7ee2b77c46 [FOLLOWUP][TASK] Replace sprite icon "actions-document-new" with the new IconFactory
Replaces all IconUtility::getSpriteIcon calls for the icon
actions-document-new with the new IconFactory.

Resolves: #68806
Releases: master
Change-Id: Idf7ea308b316101a77c099cdba0fe7d4e8a3ee2a
Reviewed-on: http://review.typo3.org/43193
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2015-09-11 16:40:52 +02:00
Morton Jonuschat
03e3d4dd8e [FOLLOWUP][TASK] Replace sprite icon "actions-edit-delete" with the new IconFactory
Replaces all IconUtility::getSpriteIcon calls for the icon
actions-edit-delete with the new IconFactory.

Resolves: #69670
Releases: master
Change-Id: I719f8d78c0c9c5623f793e9d469f5595cc54127d
Reviewed-on: http://review.typo3.org/43195
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2015-09-11 16:40:29 +02:00
Morton Jonuschat
7fbb9d73e0 [FOLLOWUP][TASK] Replace sprite icon "actions-document-open" with IconFactory
Replaces IconUtility::getSpriteIcon calls for the icon actions-document-open
which have been missed in the initial patchset with the new IconFactory.

Resolves: #68845
Releases: master
Change-Id: I7265c21ec93e1ca15869039329a86fe04e17e940
Reviewed-on: http://review.typo3.org/43192
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2015-09-11 16:35:13 +02:00
Helmut Hummel
5ac25867ff [TASK] Ignore composer.json dependencies for TYPO3 Extensions
This resolves problems with composer dependencies and Extension name /
Composer package name differences.

Resolves: #68700
Releases: master
Change-Id: I07f57f24ef7e9337e7ef8f6ee69538c038f2c0ff
Reviewed-on: http://review.typo3.org/42615
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
2015-09-10 15:40:41 +02:00
Benjamin Kott
d16e47e1f0 [TASK] Replace icon by IconFactory: actions-page-new
Resolves: #69569
Releases: master
Change-Id: I11e6434c9bb4007924dd309af5c6c1739222685e
Reviewed-on: http://review.typo3.org/43076
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2015-09-07 20:55:17 +02:00
Frank Nägler
d1e548c91c [TASK] Replaced icon with IconFactory: actions-move-*
Resolves: #69587
Releases: master
Change-Id: Ife2606f2c663a0b3df4bd7e140d5344043d5357d
Reviewed-on: http://review.typo3.org/43090
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2015-09-07 20:01:35 +02:00
Markus Guenther
854b563742 [TASK] Replace sprite icon for visibility with IconFactory
Replaces all IconUtility::getSpriteIcon calls for the icon
actions-edit-hide and actions-edit-unhide with the new IconFactory.

Change-Id: If3deb6fb4c6f867c21aaff34796515d933fa90c3
Resolves: #68925
Releases: master
Reviewed-on: http://review.typo3.org/42499
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2015-09-02 22:22:38 +02:00
Markus Guenther
5db2d786a9 [TASK] Replace sprite icon "actions-document-new" with the new IconFactory
Replaces all IconUtility::getSpriteIcon calls for the icon
actions-document-new with the new IconFactory.

Resolves: #68806
Releases: master
Change-Id: I6b69742494c2b16f499ce6367ccf5b689f958bad
Reviewed-on: http://review.typo3.org/42360
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2015-08-07 12:17:24 +02:00
Wouter Wolters
25aff9ce5e [TASK] Update TYPO3 version to TYPO3 7.5-dev
Releases: master
Change-Id: I4e245c825571869d93052e8f759e40e85ff6c140
Reviewed-on: http://review.typo3.org/42251
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2015-08-04 17:17:26 +02:00
Christian Kuhn
804e8fc96c [!!!][TASK] Drop TYPO3_CONF_VARS['SYS]['form_enctype']
The ancient form_enctype setting was a fallback from the old days
when some hosters decided uploading files in PHP is a bad idea.
The fallback was thought to still allow casual data transfer.
This is dropped now, the setting no longer used and removed from
configuration.

Resolves: #68178
Releases: master
Change-Id: If16db4de44c0654b18efc5b1a9f0e3f46e079687
Reviewed-on: http://review.typo3.org/41314
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2015-07-15 20:15:17 +02:00
Wouter Wolters
275d73f016 [TASK] Move close.html to ext:backend
To clean the typo3/ directory we move close.html
to ext:backend.

Resolves: #68108
Releases: master
Change-Id: Ieee52bd3ebea8f5c3f1c7f594d6d565864e07a76
Reviewed-on: http://review.typo3.org/41169
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2015-07-14 13:27:37 +02:00
Christian Kuhn
84856e0973 [TASK] Clean up ext_emconf files
The md5 value is not handled in core for quite a while
and removed together with some obsolete locallang flags
and further test related ext_emconf settings.

Resolves: #67979
Releases: master
Change-Id: I86804f732f7f32cf94aab7d18dfab79cdf67e458
Reviewed-on: http://review.typo3.org/41005
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2015-07-08 20:49:47 +02:00
Wouter Wolters
ed41ac89eb [TASK] Update TYPO3 version in ext_emconf.php and composer.json
Resolves: #67478
Releases: master
Change-Id: I49cebb422ff87d245d757f7736a3b8b969e8b243
Reviewed-on: http://review.typo3.org/40273
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
2015-06-16 09:47:38 +02:00
Benjamin Mack
2c2e6f3dfd [TASK] Set TYPO3 version to 7.3-dev
Change-Id: Ie9edd14d2d55c1731f69d6f6b15e04e9528efc28
Reviewed-on: http://review.typo3.org/38993
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
2015-04-28 13:58:18 +02:00
Jan Helke
2c311356b1 [TASK] Replace IconUtility::skinImg with IconUtility::getSpriteImage Part 1
This patch replaces a lot occurrences of IconUtility::skinImg with
IconUtility::getSpriteImage or similar.

Thinks that will be ignored in this iteration:

\TYPO3\CMS\Backend\Clipboard\Clipboard::printClipboard
- Here skinImg returns just the path to use in an select option. This
  is not possible with getSpriteIcon.
\TYPO3\CMS\Backend\Controller\EditDocumentController::getButtons
- Here skinImg returns just the path to use for input button. This is
  not possible with getSpriteIcon.
\TYPO3\CMS\Backend\Controller\LoginController
- There is no sprite icon replacement for the TYPO3 Logo.
\TYPO3\CMS\Backend\Controller\ContentElement\
NewContentElementController::main
- No replacement for icon of content wizard availiable.
\TYPO3\CMS\Backend\Controller\Wizard\TableController
- Here skinImg returns just the path to use for input button.
\TYPO3\CMS\Backend\Form
- I cowardly refuse to touch FormEngine until Lolli is done :-)
\TYPO3\CMS\Backend\History\RecordHistory::linkPage
- No icons for revert actions.
\TYPO3\CMS\Backend\Template\DocumentTemplate::getBackendFavicon
- Here just an URL is returned.
\TYPO3\CMS\Backend\Tree\View\AbstractTreeView::getIcon
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\ElementBrowserPageTreeView::printTree
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\FolderTreeView::PMicon
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\FolderTreeView::
getBrowseableTreeForStorage
- Could not find out how to trigger that.
\TYPO3\CMS\Backend\Tree\View\PagePositionMap::JSimgFunc
- Can be ignored, because this function is not used anywhere else in the
  core and will be marked as deprecated within this patch.
\TYPO3\CMS\Backend\Tree\View\PagePositionMap::insertQuadLines
- There is no reasonable replacement for the halfline in the
  sprite icons.
\TYPO3\CMS\Backend\View\PageLayoutView::getTable_tt_content
- No representation in sprite icons found.
\TYPO3\CMS\Backend\View\PageLayoutView::pages_getTree
- No representation in sprite icons found.
\TYPO3\CMS\Backend\View\PageTreeView
- Could not find out how to trigger that.
\ext_posMap::wrapRecordHeader (that is in
backend/Modules/Layout/index.php)
- No representation in sprite icons found.
\ext_posMap::wrapRecordHeader (that is in cms/layout/db_layout.php)
- No representation in sprite icons found.
\TYPO3\CMS\Compatibility6\Controller\Wizard\FormsController::getButtons
- Here skinImg returns just the path to use for input button.
\TYPO3\CMS\Core\Database\QueryGenerator::getFormElements
- Here skinImg returns just the path to use for input button.
\TYPO3\CMS\Core\Integrity\DatabaseIntegrityCheck::genTree
\TYPO3\CMS\Core\Integrity\DatabaseIntegrityCheck::genTree_records
- Could not find out how to trigger that.
\TYPO3\CMS\Fluid\ViewHelpers\Be\PageInfoViewHelper::render
- Could not find out how to trigger that.
\TYPO3\CMS\Impexp\ImportExport::addRelations
- This file does not exists.
\TYPO3\CMS\Impexp\LocalPageTree::ext_tree
- Could not find out how to trigger that.
typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php
- There are some dotted tree lines and blinking arrows without replacement.
\TYPO3\CMS\Reports\ViewHelpers\IconViewHelper::render
- Very generic View Helper
\TYPO3\CMS\Rtehtmlarea\BrowseLinks::getUserLinkSelectorHtml
- No representation in sprite icons found.
\TYPO3\CMS\Rtehtmlarea\PageTree::printTree
- No representation in sprite icons found.
\TYPO3\CMS\Rtehtmlarea\Controller\UserElementsController::main_user
- Could not find out how to trigger that.
\TYPO3\CMS\Taskcenter\Controller\TaskModuleController::renderListMenu
- Found no task with an individual icon file for the menu on the left
  side. So could not test.
\TYPO3\CMS\Version\View\VersionView::getVersionSelector
- No representation in sprite icons found.
\TYPO3\CMS\WizardCrpages\Controller\
CreatePagesWizardModuleFunctionController::getTypeSelectHtml
- Ignored because we are not able to determain the correct sprite icon
  from the TCA at this point of time.

Resolves: #65992
Releases: master
Change-Id: I1071703e8219699353a1d875a6b66a7ed51207b8
Reviewed-on: http://review.typo3.org/38132
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
2015-04-13 07:21:33 +02:00
Patrick Broens
b3d7771550 [BUGFIX] Wrong url for frontend editing popup
Since Forge issue #66052 frontend editing with feedit is not working anymore.
This is because the URL's for modules have become absolute and feedit is adding
the 'typo3' directory name in front of the module url.

This patch removes the 'typo3' directory

Change-Id: I26d2454240c0de5beb3a55e79d92614810670875
Resolves: #66266
Releases: master
Reviewed-on: http://review.typo3.org/38463
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
2015-04-10 00:51:39 +02:00
Anja Leichsenring
b64e7af5bb [BUGFIX] Path to feedit edit action is wrong
Upon clicking the feedit edit pencil icon in frontend, the redirect
URL contains two times typo3, what leads to a wrong call to the frontend

Change-Id: I88e2584cc0dff4be6562dbda64d723e9d9bea1d0
Resolves: #66279
Relates: #66052
Releases: master
Reviewed-on: http://review.typo3.org/38490
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
2015-04-05 18:10:41 +02:00
Benjamin Mack
58abaf0821 [TASK] Make Backend Module URLs absolute
In the approach to remove all occurences of dealing with
relative URL referencing in the TYPO3 Backend, the main mod.php
calls are now always prefixed with "/{possiblesubfolder/}typo3/" so
no backPath parameter and calculations are needed anymore.

The patch thus removes all locations of the JavaScript
variable "top.TS.PATH_typo3" containing the backpath and
makes the "relative" path to BackendUtility::getModuleUrl()
always a absolute prefix relative to the PATH_typo3 structure.

Resolves: #66052
Releases: master
Change-Id: Ie8192f227b8d1715be90efff8746482adf252ac7
Reviewed-on: http://review.typo3.org/38246
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
2015-03-28 00:14:17 +01:00
Benjamin Mack
bf7c27ede4 [TASK] Make alt_doc.php dispatched
Resolves: #65292
Releases: master
Change-Id: Ib94e59bf5d9896186aa6923eab50a2236308bd6a
Reviewed-on: http://review.typo3.org/38113
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2015-03-26 10:48:50 +01:00
Andreas Fernandez
98e65abe0f [TASK] Use constants instead of raw bitmask values
The used bitmasks of JsConfirmation and Permission are put
into "enums" and their representing constants are used instead
of the raw bitmask values.

Resolves: #65455
Releases: master
Change-Id: I1910bb960b69836ea29c16c91d730ac74c22f929
Reviewed-on: http://review.typo3.org/37455
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
2015-03-15 18:38:18 +01:00
Frank Nägler
c819ea0633 [TASK] Use ::class instead of strings
In some cases makeInstance is used with strings instead
of ::class. This patch fix it.

Resolves: #65704
Releases: master
Change-Id: I69afa653f50efbebaa7456acfb5d20f401e639fb
Reviewed-on: http://review.typo3.org/37798
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
2015-03-15 16:40:58 +01:00
Wouter Wolters
b6b1157f6c [TASK] Make db_new.php dispatched
Use dispatching for db_new.php

Resolves: #65288
Releases: master
Change-Id: Ie3ef5c8e4df8dc0181ed5e85dd780c769c2801ca
Reviewed-on: http://review.typo3.org/37479
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
2015-03-06 11:49:41 +01:00
Wouter Wolters
8c89786c67 [TASK] Set extension version and dependencies to 7.2
Resolves: #65286
Releases: master
Change-Id: I7c8576ebb76bb02582396e1345e253ba0e9a1623
Reviewed-on: http://review.typo3.org/37189
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2015-02-24 22:25:58 +01:00
Felix Kopp
c8c3e100db [TASK] Adapt extension icons to App icon
Bring new extension icons based on the alredy existing App icons.

Resovles: #63099
Releases: master
Change-Id: Ie423ccd15aadecc4968556ad8fb71229f3e241d9
Reviewed-on: http://review.typo3.org/34393
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2015-02-01 16:08:12 +01:00
Mathias Schreiber
2b5fa80be7 [CLEANUP] Code Cleanup EXT:feedit
Refactor the code to go green in PHPStorm.
Main tasks:
* Initialize variables
* Centralize objects in $GLOBALS

Resolves: #62691
Releases: master
Change-Id: Iaf4659bc9ef4cdeffbccd53fde2969a9b4c592c4
Reviewed-on: http://review.typo3.org/33785
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2015-01-30 18:02:17 +01:00
Benjamin Mack
3e4e23ba52 [TASK] Add PSR composer definition to all sysexts
In order to deliver more information
in custom installations for use with composer,
the namespaces for using the composer
autoloader are added to each composer.json
of all system extensions.

Releases: master, 6.2
Resolves: #64356
Change-Id: Ic0fa9e0969a48f68cce8ceeb77dbef3b75e6e6f1
Reviewed-on: http://review.typo3.org/36076
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2015-01-19 16:32:57 +01:00
Markus Klein
9449d24ef8 [CLEANUP] Replace strlen() with === for zero length check
It is faster to compare a string with === '' to find out if it's empty
than to run strlen() on it.

The replacement rules are applied as follows:
 *    if (strlen($str))
   => if ((string)$str !== '')
 *    if (!is_string($str) || strlen($str) === 0)
   => if (!is_string($str) || $str === '')
 * If it can be seen easily that $str is a string,
   the typecast is omitted.

Change-Id: I888d70e42f925bd57ad23b873b72d6a38acb39ef
Resolves: #54091
Releases: master
Reviewed-on: http://review.typo3.org/27794
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2015-01-18 14:37:46 +01:00
Roland Waldner
f370d50390 [CLEANUP] Add missing empty lines after copyright comments II
At the moment in some classes you can find an empty line between the
copyright comment and the first use statement. In some (far less) other
classes there is no such empty line.

This commit adds an empty line between those comments if there is no
empty line.

This is not part of the TYPO3 CMS CGL but increases consistency in this
area.

This regular expression was used to add the empty lines:

Search:
( \* The TYPO3 project - inspiring people to share!\n \*/\n)(use )

Replace:
$1\n$2

Resolves: #63829
Releases: master
Change-Id: I4b28a1cfcfc727016ac5d89b3988d236270f37e2
Reviewed-on: http://review.typo3.org/35391
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2014-12-13 20:32:41 +01:00
Roland Waldner
92e10a9cc2 [CLEANUP] Use comments not PHPDoc style comments in copyright block
This regular expression was used to replace PHPDoc style comments
with ordinary comments:

Search:
/\*\*(\n \* This file is part of the TYPO3 CMS project.)

Replace with:
/*$1

Resolves: #63328
Releases: master
Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8
Reviewed-on: http://review.typo3.org/35103
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
2014-12-13 14:21:13 +01:00
Paul Golmann
d67fa03411 [TASK] feedit: Bring back editNoPopup
* Restore edit_editNoPopup/forceNoPopup TSConfig options removed in #49640
* Initialize frontend editing when displayFieldEditIcons is set

Releases: master, 6.2
Resolves: #61095
Related: #43447
Related: #49640
Change-Id: I900a62b447a1a67265ce22cd73e150646344e090
Reviewed-on: http://review.typo3.org/32279
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
2014-12-08 01:20:06 +01:00
Stefan Neufeind
89a74a38f6 [TASK] Use name-resolution instead of strings where possible: 16
(part for extensions starting with "d" to "v")

Use name-resolution with ...::class instead of strings where
possible.
(needs PHP 5.5, which is meanwhile required for master)

Change-set Iedbb896607adddce2b23ab67f990fa2296c0d1bb
first introduced usage of ::class in master. We now add it
in various more places.

Change-Id: Idd4dbb32c5e7be1fc566a65cb729a684de003056
Resolves: #63477
Releases: master
Reviewed-on: http://review.typo3.org/34872
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2014-12-03 20:08:00 +01:00
Alexander Opitz
b7c907c8ea [TASK] Set TYPO3 version to 7.1.0-dev
Resolves: #63547
Releases: master
Change-Id: I8f48df6de186b416e6a960e8f176afddabb5614d
Reviewed-on: http://review.typo3.org/34971
Reviewed-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Tested-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2014-12-03 16:20:12 +01:00
Felix Kopp
6c8745d29a [TASK] Move classAliasMaps into compatibility6 extension part 6
The classAliasMaps in all the extension starting from extension manager
to workspace have being moved into compatibility6 extension.

Resolves: #62990
Related: #62013
Releases: master
Change-Id: If057396eae493e7345c31d2e7f7da6061f1a6e81
Reviewed-on: http://review.typo3.org/34238
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2014-11-17 22:12:42 +01:00
Xavier Perseguers
88463e21bf [TASK] Use fully qualified name resolution in PHP 5.5
Since PHP 5.5 is a requirement, calls to GeneralUtility::makeInstance()
should use the ::class construct instead of a string argument.

Releases: master
Resolves: #61788
Change-Id: Ia2efc5a4cb7ecea80b8a1c8e5ff7b5d6fa9a07ce
Reviewed-on: http://review.typo3.org/32913
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
2014-11-13 15:03:22 +01:00
Wouter Wolters
65a6aeee40 [TASK] Cleanup phpDoc to match CGL
* Use bool in @return
* Use int in @return
* Use bool in @param
* Use int in @param
* Remove extra tabs and spaces in @param

Resolves: #62506
Releases: master
Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2
Reviewed-on: http://review.typo3.org/33577
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
2014-10-28 16:43:38 +01:00
Wouter Wolters
f84e8db897 [TASK] Use "int" in @param notation
Resolves: #62467
Releases: master
Change-Id: I927a16b0fa89c5b859b56a7549548102ac04037f
Reviewed-on: http://review.typo3.org/33522
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
2014-10-25 21:48:32 +02:00
Markus Klein
7a7d6c8069 [TASK] Update version number for master to 7
Update version number of all sysext and dependency definitions.

Resolves: #62341
Releases: master
Change-Id: Ic8b1b8ead08432917a28b226bbb43347dac42087
Reviewed-on: http://review.typo3.org/33395
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2014-10-20 12:07:40 +02:00
Christian Kuhn
95c11059a0 [CLEANUP] Remove comment header in ext_emconf
The "do not touch me" comment header in ext_emconf.php files
of system extensions are misleading since we are editing those
files manually for years now. Remove those headers.

Change-Id: I27f6253effa54dae7f92170175e7705cc706d03a
Resolves: #60129
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31405
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
2014-07-06 19:02:40 +02:00
Christian Kuhn
48a93ab0d8 [CLEANUP] ext_emconf files
Quite some keys in ext_emconf are obsolete and can be removed.
See related issue for a list of keys.

Change-Id: Id12c2e3d61569cc1e84226ef75120ae4261922fb
Resolves: #60128
Related: #58365
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31397
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
2014-07-06 17:56:25 +02:00
Wouter Wolters
e54315fbff [TASK] Change check for TYPO3_MODE
Change check for TYPO3_MODE:

if (!defined('TYPO3_MODE')) {
	die('Access denied.');
}

to

defined('TYPO3_MODE') or die();

Resolves: #60112
Releases: 6.3
Change-Id: I2b4493509c912f620a993dc4ba69c4449fcac04d
Reviewed-on: https://review.typo3.org/31338
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
2014-07-05 17:09:12 +02:00
Nicole Cordes
32239ee71a [TASK] Remove unused use statements
Several classes include unused use statements. This patch removes those
statements or uses them in their code.

Resolves: #59997
Releases: 6.3
Change-Id: I5890a80bcee96976e3c35d967db8c53a9c11b002
Reviewed-on: https://review.typo3.org/31245
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
2014-07-01 20:02:18 +02:00
Michael Schams
5c1d2cd3c9 [TASK] Re-work/simplify copyright header in PHP files - Part 5
This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59781 for further details.

Resolves: #59781
Releases: 6.3, 6.2
Change-Id: I7429b8e9c507a4833215750268d1975402679828
Reviewed-on: https://review.typo3.org/31026
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein
2014-06-22 13:19:06 +02:00
Robert van Kammen
39fb1c31a6 [TASK] Update all extension versions to 6.3.0
Resolves: #59742
Releases: 6.3
Change-Id: Id6c05025873bdbdeebd74585f9bd4093657999e0
Reviewed-on: https://review.typo3.org/30965
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
2014-06-21 16:02:37 +02:00
Anja Leichsenring
5dd8d6e874 Revert "[TASK] Reduce file size of core images"
This patch changes the file permissions, so we need to work
some more on it.

This reverts commit 03cf03b28f7f37cab14f2467f6ad1c3134ae5fa4

Change-Id: I21343c8273db1e5173d6b8211cc2fed510e9810e
Reviewed-on: https://review.typo3.org/29828
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
2014-05-03 22:42:02 +02:00
Christian Kuhn
a7021efe50 [TASK] Reduce file size of core images
Reduce the file size without losing quality.
This reduces total typo3 directory size by ~2 MB.

Resolves: #58110
Releases: 6.2
Change-Id: I2062cead3939d93b847f1be741ef8a26bfb0edd8
Reviewed-on: https://review.typo3.org/29617
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Tested-by: Nadir S.
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
2014-05-03 22:02:15 +02:00
Benjamin Mack
ad384349cb [CLEANUP] Remove option "edit_wideDocument"
The historical option "wide document" can
be safely removed, as the wide screen options
from 10 years ago are default by now.

Resolves: #57295
Releases: 6.2
Change-Id: I0e5c81046733f4ddd10cc7d084f0ef7b952c3cb0
Reviewed-on: https://review.typo3.org/28769
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
2014-04-02 11:18:59 +02:00