danielsiepmann/feedit
danielsiepmann/feedit
1
0
mirror of https://github.com/FriendsOfTYPO3/feedit.git synced 2024-11-22 14:36:08 +01:00
Code Issues Releases Wiki Activity

[!!!][TASK] Remove deprecated adminpanel/feedit code

Browse source 
The following previously deprecated classes/interfaces have been removed:

* TYPO3\CMS\Adminpanel\View\AdminPanelView
* TYPO3\CMS\Adminpanel\View\AdminPanelViewHookInterface
* TYPO3\CMS\Core\FrontendEditing\FrontendEditingController

The following methods have been removed:
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->initializeAdminPanel()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->initializeFrontendEdit()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->isFrontendEditingActive()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->displayAdminPanel()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->isAdminPanelVisible()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->checkBackendAccessSettingsFromInitPhp()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extPageReadAccess()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extGetTreeList()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extGetLL()

The following public properties have been removed
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extAdmEnabled
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->adminPanel
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->frontendEdit
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extAdminConfig

The following PageTSconfig option has no effect anymore:
* TSFE.frontendEditingController

Resolves: #87231
Releases: master
Change-Id: I88cc3ac18077f054cc8895f5ccfb65291e94defa
Reviewed-on: https://review.typo3.org/59205
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
This commit is contained in:
Benni Mack 2018-12-19 09:59:28 +01:00 committed by Anja Leichsenring
parent c1c6951e3f
commit f2d64c49f2
2 changed files with 4 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Classes/DataHandling/FrontendEditDataHandler.php
View file

@ -16,7 +16,9 @@ namespace TYPO3\CMS\Feedit\DataHandling;
* The TYPO3 project - inspiring people to share! * The TYPO3 project - inspiring people to share!
*/ */
use TYPO3\CMS\Adminpanel\Utility\StateUtility;
use TYPO3\CMS\Backend\FrontendBackendUserAuthentication; use TYPO3\CMS\Backend\FrontendBackendUserAuthentication;
use TYPO3\CMS\Core\Context\Context;
use TYPO3\CMS\Core\Database\ConnectionPool; use TYPO3\CMS\Core\Database\ConnectionPool;
use TYPO3\CMS\Core\Database\Query\Restriction\EndTimeRestriction; use TYPO3\CMS\Core\Database\Query\Restriction\EndTimeRestriction;
use TYPO3\CMS\Core\Database\Query\Restriction\FrontendGroupRestriction; use TYPO3\CMS\Core\Database\Query\Restriction\FrontendGroupRestriction;
@ -24,7 +26,6 @@ use TYPO3\CMS\Core\Database\Query\Restriction\HiddenRestriction;
use TYPO3\CMS\Core\Database\Query\Restriction\StartTimeRestriction; use TYPO3\CMS\Core\Database\Query\Restriction\StartTimeRestriction;
use TYPO3\CMS\Core\DataHandling\DataHandler; use TYPO3\CMS\Core\DataHandling\DataHandler;
use TYPO3\CMS\Core\Utility\GeneralUtility; use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Frontend\View\AdminPanelView;
/** /**
* Calls DataHandler and stores data * Calls DataHandler and stores data
@ -208,7 +209,7 @@ class FrontendEditDataHandler
->setMaxResults(2); ->setMaxResults(2);
// Disable the default restrictions (but not all) if the admin panel is in preview mode // Disable the default restrictions (but not all) if the admin panel is in preview mode
if ($this->user->adminPanel instanceof AdminPanelView && $this->user->adminPanel->extGetFeAdminValue('preview')) { if (StateUtility::isActivatedForUser() && GeneralUtility::makeInstance(Context::class)->getPropertyFromAspect('visibility', 'includeHiddenContent')) {
$queryBuilder->getRestrictions() $queryBuilder->getRestrictions()
->removeByType(StartTimeRestriction::class) ->removeByType(StartTimeRestriction::class)
->removeByType(EndTimeRestriction::class) ->removeByType(EndTimeRestriction::class)

20
Classes/Middleware/FrontendEditInitiator.php
View file

@ -23,7 +23,6 @@ use Psr\Http\Server\RequestHandlerInterface;
use TYPO3\CMS\Backend\FrontendBackendUserAuthentication; use TYPO3\CMS\Backend\FrontendBackendUserAuthentication;
use TYPO3\CMS\Core\Utility\GeneralUtility; use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Feedit\DataHandling\FrontendEditDataHandler; use TYPO3\CMS\Feedit\DataHandling\FrontendEditDataHandler;
use TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController;
/** /**
* PSR-15 middleware initializing frontend editing * PSR-15 middleware initializing frontend editing
@ -51,24 +50,7 @@ class FrontendEditInitiator implements MiddlewareInterface
foreach ($config['enable.'] as $value) { foreach ($config['enable.'] as $value) {
if ($value) { if ($value) {
$parameters = $request->getParsedBody()['TSFE_EDIT'] ?? $request->getQueryParams()['TSFE_EDIT'] ?? null; $parameters = $request->getParsedBody()['TSFE_EDIT'] ?? $request->getQueryParams()['TSFE_EDIT'] ?? null;
$isValidEditAction = $this->isValidEditAction($parameters); if ($this->isValidEditAction($parameters)) {
if ($GLOBALS['TSFE'] instanceof TypoScriptFrontendController) {
// Grab the Page TSConfig property that determines which controller to use.
$pageTSConfig = $GLOBALS['TSFE']->getPagesTSconfig();
$controllerKey = $pageTSConfig['TSFE.']['frontendEditingController'] ?? 'default';
} else {
$controllerKey = 'default';
}
/** @deprecated will be removed in TYPO3 v10.0. */
$controllerClassName = $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tsfebeuserauth.php']['frontendEditingController'][$controllerKey] ?? \TYPO3\CMS\Core\FrontendEditing\FrontendEditingController::class;
if (!empty($controllerClassName)) {
/** @deprecated will be removed in TYPO3 v10.0. */
$GLOBALS['BE_USER']->frontendEdit = GeneralUtility::makeInstance(
$controllerClassName,
$parameters
);
}
if ($isValidEditAction) {
GeneralUtility::makeInstance(FrontendEditDataHandler::class, $parameters)->editAction(); GeneralUtility::makeInstance(FrontendEditDataHandler::class, $parameters)->editAction();
} }
break; break;