Commit graph

198 commits

Author SHA1 Message Date
Daniel Siepmann f5c609e57b
Merge remote-tracking branch 'origin/develop' into feature/44-add-checks-for-deprecated-removed-extensions 2017-05-18 08:39:04 +02:00
Daniel Siepmann 87cf3a3195
TASK: Do not check all classname parts for extension name
* As discussed in PR, fetch possible extension names and lookup only
  them, not all parts of class name.

Relates: #44, !70
2017-05-18 08:33:10 +02:00
Daniel Siepmann 41d5ec0dff
Merge remote-tracking branch 'origin/develop' into feature/44-add-checks-for-deprecated-removed-extensions 2017-05-16 16:29:14 +02:00
Daniel Siepmann 180a8a77c2
Merge branch 'develop' into feature/77-globals 2017-05-16 16:24:33 +02:00
Daniel Hürtgen 0c91d7b22c Merge branch 'feature/15-check-all-possible-occurences-of-class' into 'develop'
FEATURE: Detect classes in strings

Closes #15 and #43

See merge request !84
2017-05-16 15:32:55 +02:00
Daniel Hürtgen 6be0de28d3 Update StringSniff.php 2017-05-16 15:05:54 +02:00
Daniel Hürtgen ec7a4634c9 Merge branch 'hotfix/allow-phpdoc-to-substitute-all-classnames' into 'develop'
BUGFIX: Allow PhpDocCommentSniff to work find all classnames in comment

See merge request !92
2017-05-16 14:44:56 +02:00
Daniel Hürtgen 8d93512b20 Merge branch 'feature/improve-namespaces' into 'develop'
FEATURE: Improve namespace migration

See merge request !91
2017-05-16 14:42:46 +02:00
Daniel Hürtgen 5aac278ba9 Merge branch 'feature/66-ts-structure' into 'develop'
FEATURE: Add FQObjectIdentifier to TypoScript tokens

Closes #66

See merge request !83
2017-05-16 14:39:57 +02:00
Daniel Hürtgen c8f6917b38 TASK: CS fixes 2017-05-16 14:31:47 +02:00
Daniel Hürtgen 06a45a528a TASK: Added missing variable name in phpdoc 2017-05-16 14:28:26 +02:00
Daniel Siepmann f723d9a28b
TASK: Add missing mapping 2017-05-16 10:47:26 +02:00
Daniel Siepmann 2d3165e8f4
BUGFIX: Also allow to fix validator classnames 2017-05-16 10:36:27 +02:00
Daniel Siepmann f2910b02b2
BUGFIX: Allow PhpDocCommentSniff to work find all classnames in comment
* Before only the first classname was returned.
* All class names are returned now.
* This allows to fix Extbase type annotations for relations.
2017-05-11 11:17:46 +02:00
Daniel Siepmann 53d727fa4b
FEATURE: Make sure namespaces are only applied for Tx_ class definitions
* E.g. prevent migration for ux_ classes which do not follow the
  convention.
* Add test to make sure it works as expected.
2017-05-11 08:59:37 +02:00
Daniel Siepmann 40be6732af
FEATURE: Already save classname alias while searching
* To improve report results even during searching.
* By moving namespace mapping to search from fixing.
2017-05-11 08:58:35 +02:00
Daniel Siepmann 4ac34503d1
FEATURE: Check removed globals
* Add feature, tests and configuration.
* Refactor to follow DRY, move prepareStructure to abstract.

Resolves: #77
2017-05-09 14:48:44 +02:00
Daniel Siepmann 640f85af7d
TASK: Update InheritanceSniff tests to reflect added removed extension
Relates: #44
2017-05-09 13:20:20 +02:00
Daniel Siepmann e3dd6013ba
BUGFIX: Look for argument only in current statement
* Just check T_STRING as this are all function calls.
* Remove unused line of code.
* Limit position to current statement to not return later classname
  multiple times.

Relates: #44
2017-05-09 12:05:54 +02:00
Daniel Siepmann d38ce3dc41
BUGFIX: Fix identifier for removed extension
* Due to copy and paste the identifier was not indicating a removed
  extension.
* Identifier and tests were adjusted accordingly.

Relates: #44
2017-05-09 11:33:55 +02:00
Daniel Siepmann af50ddfd99
TASK: Update StaticCallSniff tests to reflect added removed extension
* Also update getBefore method of AbstractClassnameChecker to make
  lookups before, like in StaticCallSniff work.

Relates: #44
2017-05-09 11:20:45 +02:00
Daniel Siepmann fda1921d50
TASK: Refactor sniffs
* Move generic logic to abstract class.
* As not only UseSniff but also all others have the same logic, if
  method is not overwritten.
* Therefore all other sniffs should work with new feature of removed
  extension.

Relates: #44
2017-05-09 10:54:17 +02:00
Daniel Siepmann 3034f3fec4
FEATURE: Add removed extension to type hint sniff
* Integrate feature and adjust code as needed.
* We need to find the class names inside of type hints more accurate.
* Also tests need to cover the new feature.

Relates: #44
2017-05-09 10:34:58 +02:00
Daniel Siepmann 633a714043
FEATURE: Implement removed extension into use sniff.
* Detect removed extensions in use statements.

Relates: #44
2017-05-09 08:41:38 +02:00
Daniel Siepmann 5adbac1a25
TASK: Implement basic structure
* Adjust to latest develop state of project.
* Provide basic implementation.

Relates: #44
2017-05-04 16:43:09 +02:00
Daniel Siepmann c7112c0fae
Merge remote-tracking branch 'origin/develop' into feature/44-add-checks-for-deprecated-removed-extensions 2017-05-04 16:04:51 +02:00
Daniel Siepmann 7a16dac529
FEATURE: Allow auto migration of classes in strings
* We now check class names case sensitive in strings.
* This will prevent issues with stuff like TCA, as class names mathing
  table names are written in lower case.
* Also add further tests and fix issues.
* Extend test to check that lower version is not replaced but mentioned
  as warning.
* Expected class names in Tx_ format are reported as fixable error.

Resolves: #15
2017-05-04 13:35:02 +02:00
Daniel Siepmann b69c262288
TASK: Improve tests and fix issues
* Configure code coverage for new tested class.
* Fix usage of class with new insensitivity lookup.
* Add further tests.
2017-05-04 12:46:39 +02:00
Daniel Siepmann 666bbdb26a
TASK: Add tests for mapping class
* Add minimum phpdoc.
* Add tests.
* Fix issue in class.
* Fix phpmd issues.
2017-05-04 11:58:49 +02:00
Daniel Siepmann 8db7a8bb1f
TASK: Split legacy mapping into two files
* One files is provided by us for TYPO3 mappings.
* Second one keeps as is and contains the generated mappings.

Relates: #43
2017-05-04 10:44:49 +02:00
Daniel Siepmann 34bf941a21 Merge branch 'develop' into feature/15-check-all-possible-occurences-of-class 2017-05-04 08:21:37 +02:00
Daniel Siepmann e5d7f5ac01
Merge branch 'develop' into feature/66-ts-structure 2017-05-04 08:21:11 +02:00
Daniel Hürtgen dcc0c13dd8 Merge branch 'develop' into 'feature/45-removed-signals'
# Conflicts:
#   Documentation/source/features.rst
2017-05-02 22:15:52 +02:00
Daniel Hürtgen 95da568935 Merge branch 'develop' into 'feature/74-check-removed-typoscript-constants'
# Conflicts:
#   Documentation/source/features.rst
2017-05-02 22:12:23 +02:00
Daniel Hürtgen 475e38e3fc Merge branch 'develop' into 'feature/41-check-removed-classes'
# Conflicts:
#   Documentation/source/features.rst
2017-05-02 22:06:02 +02:00
Daniel Siepmann 8312ac3ec6
TASK: Add all hooks
Resolves: #45
2017-05-02 15:50:28 +02:00
Daniel Siepmann 4d77e99026
BUGFIX: Fix syntax issue in yaml file
* Ass missing colon.
2017-05-02 15:44:54 +02:00
Daniel Siepmann 4d7aeea5ae
FEATURE: Implement removed hook sniff.
* Update docs, add sniff and test.
* Add first configuration.

Relates: #45
2017-05-02 15:43:29 +02:00
Daniel Siepmann 91ab7e3424
TASK: Configure removed or changed signals
Relates: #45
2017-05-02 14:34:52 +02:00
Daniel Siepmann 83239ddeee
FEATURE: Add check for removed signals
* Add docs, sniff, tests.
* Add first configuration.

Relates: #45
2017-05-02 14:24:59 +02:00
Daniel Siepmann 299c33a075
FEATURE: Add warning for removed TypoScript Constants
* Configure removed constants in TYPO3 7.x.
* Add code / sniff.
* Add test.
* Update docs.

Resolves: #74
2017-05-02 12:44:04 +02:00
Daniel Siepmann afd6f78196
FEATURE: Detect classes in strings
* Detect class names in strings.
* Attach feature to new detection.
* Only add warnings for classes in strings, they might be table names.

Closes: #15
2017-05-02 11:52:42 +02:00
Daniel Siepmann 3126004854
TASK: Remove unnecessary method call 2017-05-02 10:54:22 +02:00
Daniel Siepmann 31d66c17d0
TASK: Fix cgl
* Fix phpcs and phpmd issues.
2017-05-02 10:52:53 +02:00
Daniel Siepmann dffcac2bd5
FEATURE: Add FQObjectIdentifier to TypoScript tokens
* To make later checks easier, add the fully qualified object
  identifier, to all object identifier tokens while tokenizing
  TypoScript.
* Adjust tests accordingly.
* Add necessary autoloading.

Closes: #66
2017-05-02 10:48:43 +02:00
Daniel Siepmann 9e3f7ac1e5
TASK: Fix MR issues
* Remove construct from interface.
* Fix wrong type hints.
* Keep naming of variable in sync.
* Also keep conditions format in sync.

Relates: #71
2017-05-02 08:09:10 +02:00
Daniel Siepmann 4fdc15d715
TASK: Add removed classes for TYPO3 7.5
Relates: #41
2017-04-27 16:41:22 +02:00
Daniel Siepmann cfdf58f7d4
TASK: Add removed classes for TYPO3 7.5
Relates: #41
2017-04-27 16:33:55 +02:00
Daniel Siepmann 3663af3755
TASK: Add removed classes for TYPO3 7.3
Relates: #41
2017-04-27 16:33:36 +02:00
Daniel Siepmann 98b9331652
TASK: Add removed classes for TYPO3 7.3
Relates: #41
2017-04-27 16:20:14 +02:00