danielsiepmann/automated-typo3-update
1
0
Code Issues

TASK: Update InheritanceSniff tests to reflect added removed extension

Browse source 
Relates: #44
This commit is contained in:
Daniel Siepmann 2017-05-09 13:20:20 +02:00
parent 84e4c426ef
commit 640f85af7d
Signed by: Daniel Siepmann
GPG key ID: 33D6629915560EF4
3 changed files with 48 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/Standards/Typo3Update/Sniffs/Classname/InheritanceSniff.php
View file

@ -72,11 +72,19 @@ class Typo3Update_Sniffs_Classname_InheritanceSniff extends AbstractClassnameChe
return;
}
$lastPosition = $phpcsFile->findNext(T_OPEN_CURLY_BRACKET, $stackPtr);
foreach ($interfaces as $interface) {
$position = $phpcsFile->findNext(T_STRING, $stackPtr, null, false, $interface);
if ($position === false) {
continue;
}
$interface = trim($interface, '\\');
$position = $stackPtr;
do {
try {
list($position, $classname) = $this->getAfter($phpcsFile, $position + 1);
} catch (\UnexpectedValueException $e) {
continue 2;
}
} while ($classname !== $interface && $position <= $lastPosition);
$this->processFeatures($phpcsFile, $position, $interface);
}

31
tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InheritanceSniff/Expected.json
View file

@ -56,14 +56,41 @@
"severity": 5,
"source": "Typo3Update.Classname.Inheritance.legacyClassname",
"type": "ERROR"
},
{
"column": 35,
"fixable": false,
"line": 34,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5,
"source": "Typo3Update.Classname.Inheritance.RemovedExtension.perm",
"type": "WARNING"
},
{
"column": 6,
"fixable": false,
"line": 35,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5,
"source": "Typo3Update.Classname.Inheritance.RemovedExtension.perm",
"type": "WARNING"
},
{
"column": 5,
"fixable": false,
"line": 36,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5,
"source": "Typo3Update.Classname.Inheritance.RemovedExtension.perm",
"type": "WARNING"
}
],
"warnings": 0
"warnings": 3
}
},
"totals": {
"errors": 6,
"fixable": 6,
"warnings": 0
"warnings": 3
}
}

7
tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InheritanceSniff/InputFileForIssues.php
View file

@ -30,3 +30,10 @@ class InputFileForIssues extends Tx_Extbase_Configuration_Configurationmanager i
{
}
class InputFileForIssues extends \TYPO3\CMS\Perm\Controller\PermissionAjaxController implements
\TYPO3\CMS\Perm\Controller\PermissionAjaxController,
TYPO3\CMS\Perm\Controller\PermissionModuleController
{
}