mirror of https://github.com/FriendsOfTYPO3/tea.git synced 2024-11-21 22:16:13 +01:00

Compare commits

...

3 commits

Author SHA1 Message Date
Oliver Klee
57a2639edf
[TASK] Rework how we solicate feedback (#1501)
We have decided to no longer ask users to create GitHub issues for
feedback as this doesn't work well with how we work.

- drop the issue template for technical feedback
- in the README, link to GitHub discussions instead of issues

Fixes #1500
2024-10-29 16:55:43 +01:00
Oliver Klee
8a7bd78df1
[DOCS] Add comment for controller unit tests (#1502)
Explain that those tests are not best practice anymore, and that we're
in the process of migrating them to functional tests.

Fixes #1499
2024-10-29 16:54:53 +01:00
Oliver Klee
fdf4f53d8e
[TASK] Configure Dependabot to create specific commit messages (#1503)
We want to be able to easily recognize PRs/commits created by
Dependabot.

Fixes #1498
2024-10-29 16:53:20 +01:00
5 changed files with 10 additions and 18 deletions

View file

@ -1,14 +0,0 @@
---
name: Technical Feedback
about: Provide technical feedback to help us improve
title: "Technical Feedback: Please add a speaking title"
labels: 'feedback'
assignees: ''
---
**Describe the area**
A short introduction to the area, e.g. a decision regarding file formats, location, etc.
**Feedback**
Your feedback, e.g. what would you do instead, what are pros and cons of the different ways in doing things.

View file

@ -9,7 +9,7 @@ updates:
# adjust this number according to your own milestones if used. # adjust this number according to your own milestones if used.
milestone: 12 milestone: 12
commit-message: commit-message:
prefix: "[TASK] " prefix: "[TASK][Dependabot] "
- package-ecosystem: "composer" - package-ecosystem: "composer"
directory: "/" directory: "/"
@ -30,7 +30,7 @@ updates:
# adjust this number according to your own milestones if used. # adjust this number according to your own milestones if used.
milestone: 12 milestone: 12
commit-message: commit-message:
prefix: "[TASK] " prefix: "[TASK][Dependabot] "
- package-ecosystem: "npm" - package-ecosystem: "npm"
directory: "/" directory: "/"
@ -40,4 +40,4 @@ updates:
# adjust this number according to your own milestones if used. # adjust this number according to your own milestones if used.
milestone: 12 milestone: 12
commit-message: commit-message:
prefix: "[TASK] " prefix: "[TASK][Dependabot] "

View file

@ -26,7 +26,7 @@ You can also use this extension to manage your collection of delicious teas.
We value and welcome feedback of all kinds, including discussions. We value and welcome feedback of all kinds, including discussions.
Feedback can be sent via TYPO3 slack within [our channel](https://app.slack.com/client/T024TUMLZ/CSQ8T0VS5) or via direct massages to the team members. Feedback can be sent via TYPO3 slack within [our channel](https://app.slack.com/client/T024TUMLZ/CSQ8T0VS5) or via direct massages to the team members.
We also welcome email. All the contact information is available at our [typo3.org team page](https://typo3.org/community/teams/best-practices). We also welcome email. All the contact information is available at our [typo3.org team page](https://typo3.org/community/teams/best-practices).
Another way is to open an [issue on GitHub](https://github.com/FriendsOfTYPO3/tea/issues/new/choose). Another way is to create a [discussion on GitHub](https://github.com/FriendsOfTYPO3/tea/discussions).
## Philosophies ## Philosophies

View file

@ -22,6 +22,9 @@ use TYPO3\TestingFramework\Core\AccessibleObjectInterface;
use TYPO3\TestingFramework\Core\Unit\UnitTestCase; use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
/** /**
* Note: Unit tests for controllers are not considered best practice anymore. Instead, functional tests should be used.
* We're currently in the process of migrating all controller tests to functional tests.
*
* @covers \TTN\Tea\Controller\FrontEndEditorController * @covers \TTN\Tea\Controller\FrontEndEditorController
*/ */
final class FrontEndEditorControllerTest extends UnitTestCase final class FrontEndEditorControllerTest extends UnitTestCase

View file

@ -17,6 +17,9 @@ use TYPO3\TestingFramework\Core\AccessibleObjectInterface;
use TYPO3\TestingFramework\Core\Unit\UnitTestCase; use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
/** /**
* Note: Unit tests for controllers are not considered best practice anymore. Instead, functional tests should be used.
* We're currently in the process of migrating all controller tests to functional tests.
*
* @covers \TTN\Tea\Controller\TeaController * @covers \TTN\Tea\Controller\TeaController
*/ */
final class TeaControllerTest extends UnitTestCase final class TeaControllerTest extends UnitTestCase