The delete action is triggered using a form with a submit button,
causing a POST request to be sent instead of a GET request.
This is because GET requests should not modify (or delete) data,
but only read it and be idempotent. Also, the request then
is guaranteed to not get cached.
From a usability perspective, a button instead of a link also
is semantically more correct: A link is expected to bring you
to some place, whereas a button is expected to trigger some
action.
Closes#871
Now dependency updates by Dependabot will be automerged if/when all
required checks are green.
This will reduce the repetetive work of merging all these update
PRs, and we have been heavily relying on our CI pipeline to check
if a depenceny update is safe to merge anyway.
Attaching any of the labels `wip` or `blocked` to a PR will block the
automerging.
The Prophecy project is basically dead, and our Prophecy dependency
currently prevents installations on PHP 8.2 without having to resort
to fiddling with Composer's platform options.
Case-insensitive filesystems cannot distinguish properly for
file and folder names with different casings. This leads to
unforseeable issues on these systems, like default partition
on MacOS devices from apple or eventually Windows systems.
This change configure phpcoverall and the chain explicitly to
use folders for the files which differs from the default of
`build/*` to avoid conflicts on case-insensitve filesystems
and prepare for introduction of the upcoming implementation
of TYPO3 core recommended `Build/` structure.
Co-authored-by: Stefan Bürk <stefan.buerk@impactmedia.de>
JetBrains created a new product named "Fleet" as
lightweight editor. This tool tends to write it's
config files to `.fleet/` folders, like all of the
IntellJ based IDE's like PHPStorm uses the `.idea`
folder.
This change adds this config folder to `.gitignore`
to avoid adding this folder to a patch if Fleet
is used to create a patch.
This change raises the minimum versions for TYPO3 core packages up
to 11.5.4 as minimum version, which contains needed fixes directly
or through raised core package dependencies to avoid corresponding
php deprecation and return type hint issues with symfony/routing
during composer minimum tests with PHP8.1. Beside this, we need at
least this version as core ships with QueryBuilder forward combat
methods `executeQuery()` and `executeStatement()` only since this
version.
See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72430Fixes#635
We should wait with marking this extension TYPO3-12-compatible
until an installation with TYPO3 12 is actually possible
(i.e., until all development dependencies actually allow this),
as an installation with TYPO3 12 will require changes to the
PHPStan annotations.
Otherwise, we will get PHPStan errors for the first build
after all dependencies allow an installation with TYPO3 12.
This reverts commit 639e414512.
* [FEATURE] Allow installations with TYPO3 12LTS
Part of #519
* Update CHANGELOG.md
Co-authored-by: Chris Müller <2566282+brotkrueml@users.noreply.github.com>
Co-authored-by: Chris Müller <2566282+brotkrueml@users.noreply.github.com>
* [TASK] Upgrade to the testing framework V7
This is required to also run the tests on TYPO3 12LTS.
* Update CHANGELOG.md
Co-authored-by: Lina Wolf <48202465+linawolf@users.noreply.github.com>
Co-authored-by: Chris Müller <2566282+brotkrueml@users.noreply.github.com>
Also sync the test matrices of the `predefined` CI jobs with those
from the Composer-script-driven CI jobs.
This change does not add any 7.4-only PHP language features.
Fixes#577
The `typo3/minimal` package is not maintained very much, and currently
cannot be used as a requirement to install the latest TYPO3 development
version (as it still depends on `dev-master`, not on `dev-main`).
In addition, not depending on it will allow us to find any missing
dependencies in our requirements that so far have been masked by
the `typo3/minimal` dependencies.
(This is the same as #520, but for GitLab CI.)
The acceptance tests have not been testing the extension itself,
have not been maintained for quite some time, and do not serve
as a good example anymore.
Until we have a proper set of example acceptance tests, we should
remove them.
Also drop the now-unused dependency on Codeception.
For non-Composer installations, all extension dependencies that are in
the `composer.json` should also be in the `ext_emconf.php`.
Even for extensions that are always installed (like frontend or fluid),
it is good practice to always make these dependencies explicit.
PHPUnit has dropped its dependency on Prophecy. In order to keep using
Prophecy in our tests, we need to add it as an explicit (development)
dependency.
Also, relying on transitive dependencies is bad practice anyway.
- Move npm tools and config to default places
- Remove now unnecessary config file parameter from npm scripts
- editorconfig and eslint config contradict, adapt editorconfig
- switch JS indent linting to TYPO3 coding standard of 2 spaces
- adapt composer scripts for new npm location
