mirror of https://github.com/FriendsOfTYPO3/tea.git synced 2024-11-25 14:56:12 +01:00
Commit graph

136 commits

Author SHA1 Message Date
Oliver Klee
4537d5fca9
[CLEANUP] Drop some redundant PHPDoc type annotations (#611) 2022-10-06 17:51:04 +02:00
Lina Wolf
8be6d02315
[TASK] Convert functional test fixtures to CSV (#601)
Fixes #600

Co-authored-by: lina.wolf <lwolf@w-commerce.de>
2022-10-03 19:10:08 +02:00
Lina Wolf
e469041db7
[CLEANUP] Use typed properties instead of @var annotations (#599)
The `@var` annotations where left where it is not possible yet to replace them in PHP 7.4.

Fixes #550

Co-authored-by: lina.wolf <lwolf@w-commerce.de>
2022-10-03 19:00:55 +02:00
Lina Wolf
5d3fcee00e
[TASK] Return ResponseInterface in controller actions (#597)
Co-authored-by: lina.wolf <lwolf@w-commerce.de>
2022-10-03 16:02:32 +02:00
Oliver Klee
e360b1ea5a
[TASK] Also mock redirectToUri in the controller unit test (#554)
Now all methods that conceptually should not be part of a controller
(and that hence must never be executed in a unit test)
are mocked for consistency.

Also sort the method names.

Fixes #446
2022-09-06 15:26:47 +02:00
Oliver Klee
be838adde5
[TASK] Remove the ancient acceptance tests (#512)
The acceptance tests have not been testing the extension itself,
have not been maintained for quite some time, and do not serve
as a good example anymore.

Until we have a proper set of example acceptance tests, we should
remove them.

Also drop the now-unused dependency on Codeception.
2022-08-28 09:33:50 +02:00
Oliver Klee
dc6c0eedeb
[TASK] Change misleading variable names in some tests (#470)
We are not using any "container" class here, and hence the results from
repository find methods should be named `$result` instead of `$container`.
2022-06-28 23:52:02 +02:00
Oliver Klee
569fad3626
[CLEANUP] Remove type annotations for fields from the testing framework (#453)
As in these cases the type annotations from the base class are used,
we can avoid PHPStan warnings about discrepancies between our annotations
and the annotations from the testing framework for the corresponding
fields in the superclass.
2022-06-01 15:26:47 +02:00
Oliver Klee
71a08a1c20
[BUGFIX] Mark the repository test as also covering the model (#436)
We currently can only test the lazy loading of the model image
with a functional test that retrieves a model from the database
via the repository.

So the functional test for the repository also needs to be marked as
covering the model class to make our code coverage correct.
2022-04-29 14:54:41 +02:00
Oliver Klee
f1a0fbef04
[CLEANUP] Use prepared statements for SQL queries in the tests (#443)
Also add another type check to help with debugging failed queries.
2022-04-29 14:27:47 +02:00
Oliver Klee
62e8c21596
[CLEANUP] Make a type annotation in a unit test more specific (#435)
This helps static code analysis.
2022-04-20 15:05:45 +02:00
Mathias Bolt Lesniak
3ca00b78e4
[BUGFIX] Use executeQuery() in functional test example (#422)
This avoids potential false results in the tests because it doesn't add additional restrictions for starttime, endtime, deleted, and hidden.

Fixes #421
2022-04-11 14:15:43 +02:00
Oliver Klee
345e01e381
[CLEANUP] Drop an unnecessary field in a test (#413) 2022-04-03 02:25:42 +02:00
Oliver Klee
869f348ce8
[CLEANUP] Make a type annotation more specific (#415) 2022-03-30 12:14:04 +02:00
Oliver Klee
a1a84a511f
[BUGFIX] Configure DI and avoid using ObjectManager in TYPO3 11LTS (#399)
`ObjectManager` is deprecated in V11.

Fixes #387
2022-03-02 02:07:25 +01:00
Oliver Klee
934f43572f
[CLEANUP] Use generics for Prophecy type annotations (#398) 2022-02-28 17:58:06 +01:00
Oliver Klee
4f2c813d7f
[TASK] Switch to the core testing framework (#361)
The TYPO3 core testing framework has more person-power for maintenance
behind it compared to the nimut testing framework. So we should use that.
2022-02-20 15:18:46 +01:00
Łukasz Uznański
822bc5561e
[TASK] Drop TeaController functional test (#379)
Co-authored-by: Łukasz Uznański <l.uznanski@macopedia.pl>
2022-02-11 21:11:30 +01:00
Oliver Klee
8520b55898
[CLEANUP] Remove code specific to TYPO3 9LTS (#367) 2022-01-13 03:26:30 +01:00
Oliver Klee
074ecf6cbd
[TASK] Upgrade PHPStan & friends (#357)
Also re-generate the baseline, and update a type annotation to match
what the current version of jangregor/phpstan-prophecy now recognizes.
2021-12-25 02:39:48 +01:00
Łukasz Uznański
f0127b3b64
[TASK] Fix php cs related to official configuration (#341)
Co-authored-by: Łukasz Uznański <l.uznanski@macopedia.com>
2021-11-17 13:14:43 +01:00
Oliver Klee
6616f79634
[TASK] Upgrade to PHPUnit 8.5 (#328)
Also upgrade to nimut/testing-framework 6.0.

This removes another blocker for running the tests with TYPO3 11LTS.

Fixes #326
2021-11-03 01:15:21 +01:00
Oliver Klee
ca9a8e4e15
[TASK] Always use @covers annotations in the tests (#298) 2021-09-15 02:11:15 +02:00
Oliver Klee
6e927a8656
[CLEANUP] Fix the Prophecy-related type annotations (#299) 2021-09-15 02:09:37 +02:00
Łukasz Uznański
4bde411dd8
[TASK] Remove author annotations (#294)
Co-authored-by: Łukasz Uznański <l.uznanski@macopedia.com>
2021-09-07 08:51:11 +02:00
Łukasz Uznański
46e598e7e1
[TASK] Enable tests in t3 v10 (#77)
Co-authored-by: Łukasz Uznański <l.uznanski@macopedia.pl>
2020-07-23 12:41:27 +02:00
Oliver Klee
a9f64159ec [TASK] Switch the code sniffing from PSR-2 to PSR-12 (#35)
Also update the corresponding packages and autoformat the code again.

Fixes #3
2019-12-07 17:44:32 +01:00
Andreas Wolf
3f3c9285d9 [CLEANUP] Fix PHP_Codesniffer issues
Resolves: #21
2019-12-07 12:13:32 +01:00
Andreas Wolf
445dae3129 [TASK] Rename TS files to .typoscript (#19)
Resolves: #8
2019-12-07 11:27:29 +01:00
Oliver Klee
29bf7ccae5
[TASK] Convert the PHP namespaces to "TTN" (#9)
Fixes #1
2019-12-01 12:16:06 +01:00
Oliver Klee
b519583431
[CLEANUP] Fix code inspection warnings (#57) 2019-08-12 17:43:02 +02:00
Oliver Klee
3401e32a84
[FEATURE] Add PHP-CS-Fixer (#53)
Also run the fixer on all classes and tests.
2019-08-12 17:25:59 +02:00
Oliver Klee
023698729b
[FEATURE] Add PHP_CodeSniffer to the Travis CI build (#44) 2019-08-12 13:49:05 +02:00
Oliver Klee
fd3f73af13
[FEATURE] Example acceptance tests with Codeception (#31) 2018-05-31 23:48:38 +02:00
Oliver Klee
3e1fd7416f
[FEATURE] Tea single view (#26) 2018-05-28 17:05:39 +02:00
Oliver Klee
3e4d10cc12
[FEATURE] Add tests using the database abstraction (#25) 2018-05-28 15:17:19 +02:00
Oliver Klee
a4089e04e9
[FEATURE] Functional tests for the tea controller (#21) 2018-05-27 00:28:13 +02:00
Oliver Klee
dd1ea7868d
[FOLLOWUP] Fix copy'n'paste error in view class in annotation (#20)
[ci skip]
2018-05-26 21:13:02 +02:00
Oliver Klee
436a10b9d6
[FEATURE] Tea plugin with TeaController and index action (#19) 2018-05-26 20:46:55 +02:00
Oliver Klee
09dc1281ca
[FEATURE] Add Tea.image as a FAL example (#15) 2018-05-25 22:39:33 +02:00
Oliver Klee
9b10334c0d
[FEATURE] Add default sorting by title to the TeaRepository (#14) 2018-05-25 17:38:51 +02:00
Oliver Klee
e2f39033c0
[FEATURE] Tea model and repository (#10) 2018-05-25 16:19:12 +02:00
Oliver Klee
bbb6f8e5f0
[TASK] Add the default directory structure (#7)
Also use spaces for indentation in the .htaccess files.
2018-01-27 15:54:51 +01:00
Oliver Klee
4b7ffe0546 [CLEANUP] Empty out the extensions 2017-12-22 22:20:43 +01:00
Oliver Klee
a2b322d53c [CLEANUP] Use a dedicated inject method
This will improve performance.
2017-12-09 17:41:35 +01:00
Oliver Klee
cb62d0c28b [CLEANUP] Use assertStringEqualsFile 2017-09-08 18:06:02 +02:00
Oliver Klee
563f4befbf [CLEANUP] Use strict types, scalar type hinting and return types 2017-09-08 18:04:28 +02:00
Oliver Klee
3cc3fd09b1 [TASK] Switch the functional tests to nimut/testing-framework 2017-09-08 16:09:51 +02:00
Oliver Klee
a8b687a656 [TASK] Switch the unit tests to nimut/testing-framework 2017-09-07 16:22:21 +02:00
Oliver Klee
7b9511edaa [TASK] Switch to expectException 2017-09-07 12:30:59 +02:00
Oliver Klee
1c1f846858 [CLEANUP] Switch to Prophecy 2017-05-05 19:12:44 +02:00
Oliver Klee
bc58abde55 [TASK] Make the extension compatible with TYPO3 CMS 7.6 2016-07-16 21:39:04 +02:00
Oliver Klee
31b1044fb5 [CLEANUP] Rework tests to match the TDD examples 2016-05-08 14:57:07 +02:00
Oliver Klee
d0871fb5f8 [CLEANUP] Use the short array syntax 2016-05-07 21:56:27 +02:00
Oliver Klee
b6bb92d0da [CLEANUP] Reformat the code as PSR-2 2016-05-07 21:43:25 +02:00
Oliver Klee
3664458d51 [CLEANUP] Use @inject and the magic inject method 2015-10-27 22:46:01 +01:00
Oliver Klee
a4721b0d1c [FEATURE] Add a DBUnit example
This is the functional test for the TeaBeverageRepository.
2015-10-26 23:37:57 +01:00
Oliver Klee
6dfa56f78e [BUGFIX] Fix the repository functional test namespace 2015-10-26 23:01:49 +01:00
Oliver Klee
1c3031597b [FEATURE] Add examples for using the Testing Framework 2015-10-26 22:59:12 +01:00
Oliver Klee
12c69e81b0 [BUGFIX] Fix a casing typo in a test name 2015-10-26 22:04:42 +01:00
Oliver Klee
f529e4a688 [CLEANUP] Use ::class and imports 2015-10-25 12:01:33 +01:00
Oliver Klee
ee8a8f903c [FEATURE] Add an example for vfsStream 2015-10-24 01:18:23 +02:00
Oliver Klee
e286cfd8a2 [CLEANUP] Lowercase null, false and true 2015-10-20 18:15:08 +02:00
Oliver Klee
2595b63847 [CLEANUP] Move the test to the correct namespaces 2015-06-14 13:07:29 +02:00
Oliver Klee
c065531f26 [CLEANUP] Import/use ObjectStorage to avoid duplication 2015-06-14 11:31:29 +02:00
Oliver Klee
8073f83c8f [CLEANUP] Drop the @test from the test methods 2015-06-14 11:27:58 +02:00
Oliver Klee
662026c630 [CLEANUP] Call static PHPUnit methods using self:: 2015-06-14 11:16:54 +02:00
Oliver Klee
3db3e7af04 [CLEANUP] Drop the unset from tearDown() 2014-12-14 21:34:16 +01:00
Oliver Klee
cb2d55f4b8 [CLEANUP] Make setUp and tearDown protected 2014-12-14 21:20:53 +01:00
Oliver Klee
7696a7b97e [BUGFIX] Fix types in @var and @param. 2014-12-11 14:16:47 +01:00
Oliver Klee
31dd57d52c [TASK] Set TYPO3 compatibility to 6.2-7.0 2014-12-11 14:14:18 +01:00
Oliver Klee
b8f233e065 [CLEANUP] Use the new TYPO3 copyright headers. 2014-12-10 21:18:45 +01:00
mostwanted
9343053ab6 Add @return void annotation to test methods 2014-01-02 00:04:01 +01:00
mostwanted
64303b35b2 Add @return void annotation to test methods 2014-01-02 00:03:30 +01:00
mostwanted
e2732e2533 Add @return void annotation to test methods 2014-01-02 00:03:12 +01:00
mostwanted
a64094be3d Add @return void annotation to test methods 2014-01-02 00:02:47 +01:00
mostwanted
956e8b5a09 Add @return void annotation to test methods 2014-01-02 00:01:54 +01:00
mostwanted
bb52944347 Add @return void annotation to test methods 2014-01-02 00:00:34 +01:00
mostwanted
dec404a5f0 Add @return void annotation to test methods (PoC)
Missing @return void annotation in phpdoc block of test methods lead to php codesniffer (phpcs) errors when using the TYPO3 CMS coding guidelines:

This function must always have a return value.
(TYPO3SniffPool.Scope.AlwaysReturn.AlwaysReturnStatement)

I suggest to add @return void annotations. Do you agree?
2014-01-01 21:18:39 +01:00
Oliver Klee
f8a77f270f [CLEANUP] Drop closing PHP tags and do some more minor cleanup. 2013-12-23 13:24:40 +01:00
Oliver Klee
4f245f1944 [CLEANUP] Replace "fixture" with "subject" in the unit tests. 2013-11-11 11:50:25 +01:00
Oliver Klee
ee93fac2b7 [FEATURE] Add missing files for indexAction. 2013-11-05 12:41:20 +01:00
Oliver Klee
d9ddc7bae5 [FEATURE] Add a Testimonial model and a relation to it. 2013-11-01 22:03:14 +01:00
Oliver Klee
e8d19e41c8 [FEATURE] Add an Addition model an a relation to it. 2013-11-01 21:21:03 +01:00
Oliver Klee
c74c26029a [FEATURE] Add a TeaType model and a relation to it. 2013-11-01 20:51:53 +01:00
Oliver Klee
c51c06715d [FEATURE] Add the TeaBeverage model and repository. 2013-11-01 20:11:03 +01:00