Oliver Klee
8a7bd78df1
[DOCS] Add comment for controller unit tests ( #1502 )
...
Explain that those tests are not best practice anymore, and that we're
in the process of migrating them to functional tests.
Fixes #1499
2024-10-29 16:54:53 +01:00
Oliver Klee
9446d14b77
[TASK] Move a repository test from unit to functional ( #1484 )
...
Unit tests for repositories are quite a hassle as we then need to
set up all dependencies in `setUp()` ourselves.
So convert the test to a functional tests where we can rely on the
container to create and initialize the subject for us.
2024-10-06 20:50:24 +02:00
Oliver Klee
d65598e8fa
[TASK] Use unique and more realistic test data in the unit tests ( #1206 )
...
Fixes #1204
2024-04-02 07:19:31 +02:00
Oliver Klee
2ab2a6c0aa
[TASK] Avoid unnecessary FQCN ( #1135 )
2024-01-23 20:39:13 +01:00
Oliver Klee
eeda862e77
[!!!][TASK] Drop additional namespace segment for the Tea model ( #1025 )
...
The `Product` namespace segment in the domain model namespace
`TTN\Tea\Domain\Model` currently serves no purpose and only adds
confusion. So let's simplify the extension structure accordingly.
(I intended to use this to demonstrate DDD contexts, but never
built enough models in the Tea extension for this to actually
make sense.)
Fixes #1008
2024-01-16 15:21:21 +01:00
Oliver Klee
7fe2758291
[TASK] Move the PHPUnit configuration files to Configuration/ ( #1108 )
...
The `Tests/` directory should only include test code, but not the
configuration files.
Fixes #1082
2024-01-08 00:41:08 +01:00
Oliver Klee
0ff0f83edd
[TASK] Add coverage configuration for functional tests ( #1092 )
...
We already had this for unit tests, but it was missing for
functional tests.
Also, we do not need to provide a path in this configuration - it
suffices to have this node present in the configuration files.
Closes #1078
2024-01-02 22:34:49 +01:00
Oliver Klee
8e3cc5b6a1
[CLEANUP] Sort the PHPUnit configuration options ( #1091 )
2023-12-19 12:29:19 +01:00
Oliver Klee
2c972eb11a
[CLEANUP] Autoformat the PHPUnit configuration files ( #1084 )
...
This avoids unrelated formatting changes in functional changes.
2023-12-19 12:17:04 +01:00
Oliver Klee
450905287c
[CLEANUP] Use more stubs instead of mocks ( #995 )
...
This makes the purpose of the test doubles more clear to the reader.
Fixes #986
2023-11-18 06:48:56 +01:00
Oliver Klee
fddd50da3e
[CLEANUP] Convert one more mock to a stub ( #977 )
...
This makes the purpose of the mock/stub more explicit.
2023-11-05 22:46:37 +01:00
Oliver Klee
286aa05073
[TASK] Use more stubs in the unit tests ( #962 )
...
This way, the purpose of the stub/mock is more explicit.
Fixes #870
2023-11-01 21:15:42 +01:00
Oliver Klee
350fe8abb2
[CLEANUP] Simplify the mock building in the unit tests ( #963 )
2023-11-01 19:59:07 +00:00
Oliver Klee
a444e2266c
[CLEANUP] Make the TYPO3 version switches more consistent ( #964 )
...
Also reduce the cognitive load as these switches are between
V12 and pre-V12.
2023-11-01 19:56:10 +00:00
Łukasz Uznański
bc64aedb38
[TASK] Use own configuration files for tests ( #952 )
...
Resolves : #902
2023-10-25 19:08:36 +02:00
Oliver Klee
b4c93d8dea
[TASK] Switch the TeaController to construtor injection ( #881 )
...
Fixes #869
2023-07-03 14:26:21 +02:00
Oliver Klee
cda38af84b
[FEATURE] Add a delete functionality for the Tea FE editor ( #876 )
...
The delete action is triggered using a form with a submit button,
causing a POST request to be sent instead of a GET request.
This is because GET requests should not modify (or delete) data,
but only read it and be idempotent. Also, the request then
is guaranteed to not get cached.
From a usability perspective, a button instead of a link also
is semantically more correct: A link is expected to bring you
to some place, whereas a button is expected to trigger some
action.
Closes #871
2023-06-23 11:55:19 +02:00
Oliver Klee
82e7e95487
[FEATURE] Allow creating a new tea in the FE ( #874 )
...
Part of #871
2023-06-22 20:30:12 +02:00
Oliver Klee
ad460b20b3
[FEATURE] Add FE editing for existing tea records ( #872 )
...
Part of #871
2023-06-22 14:20:14 +02:00
Oliver Klee
1f263d8839
[FEATURE] Add a list view for the FE tea editor ( #864 )
...
This is one more part of building CRUD functionality.
2023-06-22 11:17:51 +00:00
Oliver Klee
8fe9307b37
[BUGFIX] Allow ActionController::redirect in tests again ( #865 )
...
In TYPO3 12LTS, this method still exists. So we are still able
to mock it.
2023-06-22 11:49:12 +02:00
Oliver Klee
bbe469169b
[FEATURE] Add Tea.ownerUid ( #860 )
...
This is a pre-patch for adding a CRUD plugin for tea records.
This property contains only the UID of the owner FE user, but not
a relation to a FE user model. This is because we neither have nor
need a FE user model for the purposes of the CRUD plugin.
2023-06-21 09:16:13 +02:00
Oliver Klee
2ab50201fa
[TASK] Make the controller tests more fine-grained ( #856 )
...
Tests should only test one thing (if possible).
2023-06-20 07:19:57 +00:00
68372cc850
[TASK] Make all test cases final ( #801 )
...
Resolves : #797
2023-04-06 14:34:15 +00:00
4d2bbced74
[BUGFIX] Do not mock unavailable methods ( #799 )
2023-04-06 14:32:05 +02:00
Oliver Klee
14b8628483
[TASK] Stop using Prophecy ( #676 )
...
The Prophecy project is basically dead, and our Prophecy dependency
currently prevents installations on PHP 8.2 without having to resort
to fiddling with Composer's platform options.
2022-11-05 17:08:32 +01:00
Oliver Klee
6b957de595
[FEATURE] Allow installations on TYPO3 12 ( #652 )
2022-10-19 09:06:36 +02:00
Oliver Klee
b3f0eb3f3d
[CLEANUP] Use more native property types in the tests ( #628 )
2022-10-10 16:05:06 +02:00
Oliver Klee
0a1a00dd22
[CLEANUP] Drop usages of ObjectManager whereever possible ( #616 )
...
Fixes #596
2022-10-10 02:15:33 +02:00
Oliver Klee
f6af430180
[TASK] Upgrade to PHPUnit 9 ( #610 )
...
Also upgrade PHPCOV to match the used PHPUnit version
Fixes #586
Fixes #542
2022-10-09 06:19:32 +02:00
Oliver Klee
bb7e6d2670
[CLEANUP] Add more native type annotations in the tests ( #612 )
2022-10-06 17:51:41 +02:00
Lina Wolf
e469041db7
[CLEANUP] Use typed properties instead of @var annotations ( #599 )
...
The `@var` annotations where left where it is not possible yet to replace them in PHP 7.4.
Fixes #550
Co-authored-by: lina.wolf <lwolf@w-commerce.de>
2022-10-03 19:00:55 +02:00
Lina Wolf
5d3fcee00e
[TASK] Return ResponseInterface in controller actions ( #597 )
...
Co-authored-by: lina.wolf <lwolf@w-commerce.de>
2022-10-03 16:02:32 +02:00
Oliver Klee
e360b1ea5a
[TASK] Also mock redirectToUri in the controller unit test ( #554 )
...
Now all methods that conceptually should not be part of a controller
(and that hence must never be executed in a unit test)
are mocked for consistency.
Also sort the method names.
Fixes #446
2022-09-06 15:26:47 +02:00
Oliver Klee
62e8c21596
[CLEANUP] Make a type annotation in a unit test more specific ( #435 )
...
This helps static code analysis.
2022-04-20 15:05:45 +02:00
Oliver Klee
345e01e381
[CLEANUP] Drop an unnecessary field in a test ( #413 )
2022-04-03 02:25:42 +02:00
Oliver Klee
934f43572f
[CLEANUP] Use generics for Prophecy type annotations ( #398 )
2022-02-28 17:58:06 +01:00
Oliver Klee
4f2c813d7f
[TASK] Switch to the core testing framework ( #361 )
...
The TYPO3 core testing framework has more person-power for maintenance
behind it compared to the nimut testing framework. So we should use that.
2022-02-20 15:18:46 +01:00
Oliver Klee
074ecf6cbd
[TASK] Upgrade PHPStan & friends ( #357 )
...
Also re-generate the baseline, and update a type annotation to match
what the current version of jangregor/phpstan-prophecy now recognizes.
2021-12-25 02:39:48 +01:00
Łukasz Uznański
f0127b3b64
[TASK] Fix php cs related to official configuration ( #341 )
...
Co-authored-by: Łukasz Uznański <l.uznanski@macopedia.com>
2021-11-17 13:14:43 +01:00
Oliver Klee
ca9a8e4e15
[TASK] Always use @covers annotations in the tests ( #298 )
2021-09-15 02:11:15 +02:00
Oliver Klee
6e927a8656
[CLEANUP] Fix the Prophecy-related type annotations ( #299 )
2021-09-15 02:09:37 +02:00
Łukasz Uznański
4bde411dd8
[TASK] Remove author annotations ( #294 )
...
Co-authored-by: Łukasz Uznański <l.uznanski@macopedia.com>
2021-09-07 08:51:11 +02:00
Oliver Klee
a9f64159ec
[TASK] Switch the code sniffing from PSR-2 to PSR-12 ( #35 )
...
Also update the corresponding packages and autoformat the code again.
Fixes #3
2019-12-07 17:44:32 +01:00
Andreas Wolf
3f3c9285d9
[CLEANUP] Fix PHP_Codesniffer issues
...
Resolves : #21
2019-12-07 12:13:32 +01:00
Oliver Klee
29bf7ccae5
[TASK] Convert the PHP namespaces to "TTN" ( #9 )
...
Fixes #1
2019-12-01 12:16:06 +01:00
Oliver Klee
b519583431
[CLEANUP] Fix code inspection warnings ( #57 )
2019-08-12 17:43:02 +02:00
Oliver Klee
3401e32a84
[FEATURE] Add PHP-CS-Fixer ( #53 )
...
Also run the fixer on all classes and tests.
2019-08-12 17:25:59 +02:00
Oliver Klee
3e1fd7416f
[FEATURE] Tea single view ( #26 )
2018-05-28 17:05:39 +02:00
Oliver Klee
dd1ea7868d
[FOLLOWUP] Fix copy'n'paste error in view class in annotation ( #20 )
...
[ci skip]
2018-05-26 21:13:02 +02:00
