danielsiepmann/tea
danielsiepmann/tea
1
0
mirror of https://github.com/FriendsOfTYPO3/tea.git synced 2024-11-23 06:36:13 +01:00
Code Activity
1132 commits 14 branches 6 tags 10 MiB
Commit graph

54 commits

Author SHA1 Message Date
Oliver Klee
f8ff931431
[TASK] Narrow down a type in the controller (#1270) 
This fixes the last PHPStan level 9 warning.
 2024-05-06 14:46:54 +02:00
Oliver Klee
7f21991fa5
[TASK] Improve the type annotations for TeaRepository (#1266) 
This fixes the last remaining PHPStan level 6 warning.
 2024-05-06 12:35:12 +02:00
Oliver Klee
248c759206
[TASK][!!!] Require a storage PID for the tea list (#1223) 
Fixes #1024
Supersedes #1024
 2024-04-15 11:13:57 +02:00
Oliver Klee
eeda862e77
[!!!][TASK] Drop additional namespace segment for the Tea model (#1025) 
The `Product` namespace segment in the domain model namespace
`TTN\Tea\Domain\Model` currently serves no purpose and only adds
confusion. So let's simplify the extension structure accordingly.

(I intended to use this to demonstrate DDD contexts, but never
built enough models in the Tea extension for this to actually
make sense.)

Fixes #1008
 2024-01-16 15:21:21 +01:00
Oliver Klee
b4c93d8dea
[TASK] Switch the TeaController to construtor injection (#881) 
Fixes #869
 2023-07-03 14:26:21 +02:00
Oliver Klee
a6869c6fee
[BUGFIX] Skip validation where validation makes no sense (#877) 
When creating a new tea record in the FE, or when editing one,
the tea model provided to the form is not necessarily valid
(and we need to accept invalid models if the following action
rejects the model due to a valiation error).
 2023-06-23 12:07:54 +02:00
Oliver Klee
cda38af84b
[FEATURE] Add a delete functionality for the Tea FE editor (#876) 
The delete action is triggered using a form with a submit button,
causing a POST request to be sent instead of a GET request.
This is because GET requests should not modify (or delete) data,
but only read it and be idempotent. Also, the request then
is guaranteed to not get cached.

From a usability perspective, a button instead of a link also
is semantically more correct: A link is expected to bring you
to some place, whereas a button is expected to trigger some
action.

Closes #871
 2023-06-23 11:55:19 +02:00
Oliver Klee
82e7e95487
[FEATURE] Allow creating a new tea in the FE (#874) 
Part of #871
 2023-06-22 20:30:12 +02:00
Oliver Klee
ad460b20b3
[FEATURE] Add FE editing for existing tea records (#872) 
Part of #871
 2023-06-22 14:20:14 +02:00
Oliver Klee
1f263d8839
[FEATURE] Add a list view for the FE tea editor (#864) 
This is one more part of building CRUD functionality.
 2023-06-22 11:17:51 +00:00
Oliver Klee
6415f7fd85
[FEATURE] Add validation to the FE-editable tea properties (#866) 
The maximum length of the string fields ensures that the contents
fit within the limits of the corresponding DB columns.
 2023-06-21 20:40:51 +02:00
Oliver Klee
bbe469169b
[FEATURE] Add Tea.ownerUid (#860) 
This is a pre-patch for adding a CRUD plugin for tea records.

This property contains only the UID of the owner FE user, but not
a relation to a FE user model. This is because we neither have nor
need a FE user model for the purposes of the CRUD plugin.
 2023-06-21 09:16:13 +02:00
Oliver Klee
1a5b7c40c6
[CLEANUP] Reorder the type annotations for better readability (#819) 
Apart from this small polish, there is nothing to change in order
to be consistent with the latest decision on type annotations as
described here:

https://decisions.typo3.org/t/phpstan-specific-phpdoc-annotations-in-the-core-code-base/807

Fixes #794
 2023-04-22 18:40:06 +02:00
Oliver Klee
90a256f49e
[CLEANUP] Use short class references in the domain model annotations (#669) 
Starting with TYPO3 10LTS, it is no longer necessary to use FQCNs
for domain property annotations for Extbase.
 2022-11-01 21:44:37 +01:00
Łukasz Uznański
19b8c4ef47
[TASK] Stop injecting query settings (#650) 2022-10-18 23:21:20 +02:00
Oliver Klee
0a1a00dd22
[CLEANUP] Drop usages of ObjectManager whereever possible (#616) 
Fixes #596
 2022-10-10 02:15:33 +02:00
Lina Wolf
e469041db7
[CLEANUP] Use typed properties instead of @var annotations (#599) 
The `@var` annotations where left where it is not possible yet to replace them in PHP 7.4.

Fixes #550

Co-authored-by: lina.wolf <lwolf@w-commerce.de>
 2022-10-03 19:00:55 +02:00
Lina Wolf
5d3fcee00e
[TASK] Return ResponseInterface in controller actions (#597) 
Co-authored-by: lina.wolf <lwolf@w-commerce.de>
 2022-10-03 16:02:32 +02:00
Oliver Klee
29eec0cb75
[BUGFIX] Do not overwrite type annotations from parent classes (#480) 
This avoids PHPStan warnings in a case where our type annotations are
not up to date anymore with the latest change in the Core.
 2022-07-13 18:21:01 +02:00
Oliver Klee
bd3731934f
[CLEANUP] Add generics annotation to the Tea repository (#414) 
This helps static code analysis determine for which models the
repository is responsible.
 2022-04-03 02:24:55 +02:00
Oliver Klee
a1a84a511f
[BUGFIX] Configure DI and avoid using ObjectManager in TYPO3 11LTS (#399) 
`ObjectManager` is deprecated in V11.

Fixes #387
 2022-03-02 02:07:25 +01:00
Łukasz Uznański
f0127b3b64
[TASK] Fix php cs related to official configuration (#341) 
Co-authored-by: Łukasz Uznański <l.uznanski@macopedia.com>
 2021-11-17 13:14:43 +01:00
Oliver Klee
0816fad65b
[CLEANUP] Make lazy-loading proxies visible via type annotations (#310) 
Relates to #291
 2021-09-22 22:34:58 +02:00
Łukasz Uznański
4bde411dd8
[TASK] Remove author annotations (#294) 
Co-authored-by: Łukasz Uznański <l.uznanski@macopedia.com>
 2021-09-07 08:51:11 +02:00
Andreas Wolf
3f3c9285d9 [CLEANUP] Fix PHP_Codesniffer issues 
Resolves: #21
 2019-12-07 12:13:32 +01:00
Oliver Thiele
5b8aaf47fb [TASK] Added extbase relevant directories (#20) 
Resolves: #18
 2019-12-07 11:29:50 +01:00
Oliver Klee
29bf7ccae5
[TASK] Convert the PHP namespaces to "TTN" (#9) 
Fixes #1
 2019-12-01 12:16:06 +01:00
Oliver Klee
b519583431
[CLEANUP] Fix code inspection warnings (#57) 2019-08-12 17:43:02 +02:00
Oliver Klee
3401e32a84
[FEATURE] Add PHP-CS-Fixer (#53) 
Also run the fixer on all classes and tests.
 2019-08-12 17:25:59 +02:00
Oliver Klee
eac6593a9d
[BUGFIX] Use the new annotations for lazy loading (#54) 2019-08-12 16:23:28 +02:00
Oliver Klee
3e1fd7416f
[FEATURE] Tea single view (#26) 2018-05-28 17:05:39 +02:00
Oliver Klee
436a10b9d6
[FEATURE] Tea plugin with TeaController and index action (#19) 2018-05-26 20:46:55 +02:00
Oliver Klee
09dc1281ca
[FEATURE] Add Tea.image as a FAL example (#15) 2018-05-25 22:39:33 +02:00
Oliver Klee
9b10334c0d
[FEATURE] Add default sorting by title to the TeaRepository (#14) 2018-05-25 17:38:51 +02:00
Oliver Klee
e2f39033c0
[FEATURE] Tea model and repository (#10) 2018-05-25 16:19:12 +02:00
Oliver Klee
4b7ffe0546 [CLEANUP] Empty out the extensions 2017-12-22 22:20:43 +01:00
Oliver Klee
5335064e80 [CLEANUP] PHP strict mode 2017-12-09 18:34:15 +01:00
Oliver Klee
f4d5287239 [FEATURE] Testimonial showAction 2017-12-09 18:05:05 +01:00
Oliver Klee
a2b322d53c [CLEANUP] Use a dedicated inject method 
This will improve performance.
 2017-12-09 17:41:35 +01:00
Oliver Klee
563f4befbf [CLEANUP] Use strict types, scalar type hinting and return types 2017-09-08 18:04:28 +02:00
Oliver Klee
229ab85f0b [CLEANUP] Code autoformat 2016-05-08 14:28:38 +02:00
Oliver Klee
b6bb92d0da [CLEANUP] Reformat the code as PSR-2 2016-05-07 21:43:25 +02:00
Oliver Klee
3664458d51 [CLEANUP] Use @inject and the magic inject method 2015-10-27 22:46:01 +01:00
Oliver Klee
ee8a8f903c [FEATURE] Add an example for vfsStream 2015-10-24 01:18:23 +02:00
Oliver Klee
e286cfd8a2 [CLEANUP] Lowercase null, false and true 2015-10-20 18:15:08 +02:00
Oliver Klee
f3b26e35ee [CLEANUP] boolean -> bool, integer -> int 2014-12-14 16:17:44 +01:00
Oliver Klee
7696a7b97e [BUGFIX] Fix types in @var and @param. 2014-12-11 14:16:47 +01:00
Oliver Klee
b8f233e065 [CLEANUP] Use the new TYPO3 copyright headers. 2014-12-10 21:18:45 +01:00
Oliver Klee
f8a77f270f [CLEANUP] Drop closing PHP tags and do some more minor cleanup. 2013-12-23 13:24:40 +01:00
Oliver Klee
ee93fac2b7 [FEATURE] Add missing files for indexAction. 2013-11-05 12:41:20 +01:00