[CLEANUP] Use typed properties instead of @var annotations (#599)

The `@var` annotations where left where it is not possible yet to replace them in PHP 7.4.

Fixes #550

Co-authored-by: lina.wolf <lwolf@w-commerce.de>

CHANGELOG.md

@@ -8,6 +8,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
 ### Added
 
 ### Changed
+- Use typed properties instead of `@var` annotations (#599)
 - Return `ResponseInterface` in controller actions (#597)
 - Replace switchable controller actions with separate plugins (#575)
 

Classes/Controller/TeaController.php

@@ -14,10 +14,7 @@ use TYPO3\CMS\Extbase\Mvc\Controller\ActionController;
  */
 class TeaController extends ActionController
 {
-    /**
+    private TeaRepository $teaRepository;
-     * @var TeaRepository
-     */
-    private $teaRepository;
 
     public function injectTeaRepository(TeaRepository $teaRepository): void
     {

Classes/Domain/Model/Product/Tea.php

@@ -14,15 +14,9 @@ use TYPO3\CMS\Extbase\Persistence\Generic\LazyLoadingProxy;
  */
 class Tea extends AbstractEntity
 {
-    /**
+    protected string $title = '';
-     * @var string
-     */
-    protected $title = '';
 
-    /**
+    protected string $description = '';
-     * @var string
-     */
-    protected $description = '';
 
     /**
      * @phpstan-var \TYPO3\CMS\Extbase\Domain\Model\FileReference|LazyLoadingProxy|null

Classes/Domain/Repository/Traits/StoragePageAgnosticTrait.php

@@ -14,10 +14,7 @@ use TYPO3\CMS\Extbase\Persistence\Generic\QuerySettingsInterface;
  */
 trait StoragePageAgnosticTrait
 {
-    /**
+    private QuerySettingsInterface $querySettings;
-     * @var QuerySettingsInterface
-     */
-    private $querySettings;
 
     public function injectQuerySettings(QuerySettingsInterface $querySettings): void
     {

Tests/Functional/Domain/Repository/Product/TeaRepositoryTest.php

@@ -21,15 +21,9 @@ class TeaRepositoryTest extends FunctionalTestCase
 {
     protected $testExtensionsToLoad = ['typo3conf/ext/tea'];
 
-    /**
+    private TeaRepository $subject;
-     * @var TeaRepository
-     */
-    private $subject;
 
-    /**
+    private PersistenceManager $persistenceManager;
-     * @var PersistenceManager
-     */
-    private $persistenceManager;
 
     protected function setUp(): void
     {

Tests/Unit/Domain/Model/Product/TeaTest.php

@@ -14,10 +14,7 @@ use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
  */
 class TeaTest extends UnitTestCase
 {
-    /**
+    private Tea $subject;
-     * @var Tea
-     */
-    private $subject;
 
     protected function setUp(): void
     {

Tests/Unit/Domain/Repository/Product/TeaRepositoryTest.php

@@ -14,10 +14,7 @@ use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
  */
 class TeaRepositoryTest extends UnitTestCase
 {
-    /**
+    private TeaRepository $subject;
-     * @var TeaRepository
-     */
-    private $subject;
 
     protected function setUp(): void
     {