danielsiepmann/tea
danielsiepmann/tea
1
0
mirror of https://github.com/FriendsOfTYPO3/tea.git synced 2024-11-22 15:16:13 +01:00
Code Activity

Add @return void annotation to test methods (PoC)

Browse source 
Missing @return void annotation in phpdoc block of test methods lead to php codesniffer (phpcs) errors when using the TYPO3 CMS coding guidelines:

This function must always have a return value.
(TYPO3SniffPool.Scope.AlwaysReturn.AlwaysReturnStatement)

I suggest to add @return void annotations. Do you agree?
This commit is contained in:
mostwanted 2014-01-01 21:18:39 +01:00
parent f8a77f270f
commit dec404a5f0
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Tests/Unit/Domain/Model/TeaTypeTest.php
View file

@ -46,6 +46,7 @@ class TeaTypeTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase {
/** /**
* @test * @test
* @return void
*/ */
public function getTitleInitiallyReturnsEmptyString() { public function getTitleInitiallyReturnsEmptyString() {
$this->assertSame( $this->assertSame(
@ -56,6 +57,7 @@ class TeaTypeTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase {
/** /**
* @test * @test
* @return void
*/ */
public function setTitleSetsTitle() { public function setTitleSetsTitle() {
$this->subject->setTitle('foo bar'); $this->subject->setTitle('foo bar');
@ -68,6 +70,7 @@ class TeaTypeTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase {
/** /**
* @test * @test
* @return void
*/ */
public function getCaffeinatedInitiallyReturnsFalse() { public function getCaffeinatedInitiallyReturnsFalse() {
$this->assertSame( $this->assertSame(
@ -78,6 +81,7 @@ class TeaTypeTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase {
/** /**
* @test * @test
* @return void
*/ */
public function setCaffeinatedSetsCaffeinated() { public function setCaffeinatedSetsCaffeinated() {
$this->subject->setCaffeinated(TRUE); $this->subject->setCaffeinated(TRUE);
@ -86,4 +90,4 @@ class TeaTypeTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase {
$this->subject->getCaffeinated() $this->subject->getCaffeinated()
); );
} }
} }