danielsiepmann/tea
danielsiepmann/tea
1
0
mirror of https://github.com/FriendsOfTYPO3/tea.git synced 2024-11-22 14:16:12 +01:00
Code Activity

[TASK] Avoid race condition on case-insensitive filesystems (#657)

Browse source 
Case-insensitive filesystems cannot distinguish properly for
file and folder names with different casings. This leads to
unforseeable issues on these systems, like default partition
on MacOS devices from apple or eventually Windows systems.

This change configure phpcoverall and the chain explicitly to
use folders for the files which differs from the default of
`build/*` to avoid conflicts on case-insensitve filesystems
and prepare for introduction of the upcoming implementation
of TYPO3 core recommended `Build/` structure.

Co-authored-by: Stefan Bürk <stefan.buerk@impactmedia.de>
This commit is contained in:
Oliver Klee 2022-10-24 18:26:02 +02:00 committed by GitHub
parent dbe29a2f58
commit d0c819d3a6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/codecoverage.yml vendored
View file

@ -70,7 +70,7 @@ jobs:
- name: "Upload coverage results to Coveralls" - name: "Upload coverage results to Coveralls"
env: env:
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: ./.Build/vendor/bin/php-coveralls --coverage_clover=build/logs/clover.xml -v run: ./.Build/vendor/bin/php-coveralls --coverage_clover=./.Build/logs/clover.xml --json_path=./.Build/logs/coveralls-upload.json -v
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:

1
.gitignore vendored
View file

@ -4,7 +4,6 @@
/.php-cs-fixer.cache /.php-cs-fixer.cache
/.phpunit.result.cache /.phpunit.result.cache
/Documentation-GENERATED-temp/ /Documentation-GENERATED-temp/
/build
/clover.xml /clover.xml
/composer.lock /composer.lock
/nbproject /nbproject

1
CHANGELOG.md
View file

@ -14,6 +14,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
### Removed ### Removed
### Fixed ### Fixed
- Avoid race condition on case-insensitive filesystems (#657)
## 3.0.0 ## 3.0.0

4
composer.json
View file

@ -116,7 +116,7 @@
], ],
"ci:coverage:merge": [ "ci:coverage:merge": [
"@coverage:create-directories", "@coverage:create-directories",
"@php tools/phpcov merge --clover=./build/logs/clover.xml ./.Build/coverage/" "@php tools/phpcov merge --clover=./.Build/logs/clover.xml ./.Build/coverage/"
], ],
"ci:coverage:unit": [ "ci:coverage:unit": [
"@coverage:create-directories", "@coverage:create-directories",
@ -157,7 +157,7 @@
"ci:tests:unit": ".Build/vendor/bin/phpunit -c .Build/vendor/typo3/testing-framework/Resources/Core/Build/UnitTests.xml Tests/Unit", "ci:tests:unit": ".Build/vendor/bin/phpunit -c .Build/vendor/typo3/testing-framework/Resources/Core/Build/UnitTests.xml Tests/Unit",
"ci:ts:lint": "typoscript-lint -c Configuration/TsLint.yml --ansi -n --fail-on-warnings -vvv Configuration/TypoScript", "ci:ts:lint": "typoscript-lint -c Configuration/TsLint.yml --ansi -n --fail-on-warnings -vvv Configuration/TypoScript",
"ci:yaml:lint": "find . ! -path '*.Build/*' ! -path '*node_modules/*' -regextype egrep -regex '.*.ya?ml$' | xargs -r php ./.Build/vendor/bin/yaml-lint", "ci:yaml:lint": "find . ! -path '*.Build/*' ! -path '*node_modules/*' -regextype egrep -regex '.*.ya?ml$' | xargs -r php ./.Build/vendor/bin/yaml-lint",
"coverage:create-directories": "mkdir -p build/logs .Build/coverage", "coverage:create-directories": "mkdir -p .Build/logs .Build/coverage",
"docs:generate": [ "docs:generate": [
"docker run --rm t3docs/render-documentation show-shell-commands > tempfile.sh; echo 'dockrun_t3rd makehtml' >> tempfile.sh; bash tempfile.sh; rm tempfile.sh" "docker run --rm t3docs/render-documentation show-shell-commands > tempfile.sh; echo 'dockrun_t3rd makehtml' >> tempfile.sh; bash tempfile.sh; rm tempfile.sh"
], ],