mirror of https://github.com/FriendsOfTYPO3/tea.git synced 2024-11-22 17:56:12 +01:00

[CLEANUP] Inline some variables in the tests (#997)

This makes the tests more concise while still keeping them readable.
This commit is contained in:
Oliver Klee 2023-11-18 06:44:40 +01:00 committed by GitHub
parent 2a763a2398
commit 3cdf8df7a0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -73,8 +73,7 @@ final class TeaRepositoryTest extends FunctionalTestCase
{ {
$this->importCSVDataSet(__DIR__ . '/../Fixtures/Product/Tea.csv'); $this->importCSVDataSet(__DIR__ . '/../Fixtures/Product/Tea.csv');
$uid = 1; $model = $this->subject->findByUid(1);
$model = $this->subject->findByUid($uid);
self::assertInstanceOf(Tea::class, $model); self::assertInstanceOf(Tea::class, $model);
} }
@ -86,8 +85,7 @@ final class TeaRepositoryTest extends FunctionalTestCase
{ {
$this->importCSVDataSet(__DIR__ . '/../Fixtures/Product/Tea.csv'); $this->importCSVDataSet(__DIR__ . '/../Fixtures/Product/Tea.csv');
$uid = 1; $model = $this->subject->findByUid(1);
$model = $this->subject->findByUid($uid);
self::assertInstanceOf(Tea::class, $model); self::assertInstanceOf(Tea::class, $model);
self::assertSame('Earl Grey', $model->getTitle()); self::assertSame('Earl Grey', $model->getTitle());
@ -102,8 +100,7 @@ final class TeaRepositoryTest extends FunctionalTestCase
{ {
$this->importCSVDataSet(__DIR__ . '/../Fixtures/Product/Tea.csv'); $this->importCSVDataSet(__DIR__ . '/../Fixtures/Product/Tea.csv');
$uid = 3; $model = $this->subject->findByUid(3);
$model = $this->subject->findByUid($uid);
$image = $model->getImage(); $image = $model->getImage();
self::assertInstanceOf(FileReference::class, $image); self::assertInstanceOf(FileReference::class, $image);