[TASK] Move the PHPStan configuration files to Build/ (#1634)

.gitattributes

@@ -14,8 +14,6 @@
 /package-lock.json export-ignore
 /package.json export-ignore
 /phive.xml export-ignore
-/phpstan-baseline.neon export-ignore
-/phpstan.neon export-ignore
 /rector.php export-ignore
 /stylelint.config.js export-ignore
 /tools/ export-ignore binary

Build/Scripts/runTests.sh

@@ -333,7 +333,7 @@ NETWORK="typo3-best-practices-tea-${SUFFIX}"
 CI_PARAMS="${CI_PARAMS:-}"
 CONTAINER_HOST="host.docker.internal"
 # shellcheck disable=SC2034 # This variable will be needed when we try to clean up the root folder
-PHPSTAN_CONFIG_FILE="phpstan.neon"
+PHPSTAN_CONFIG_FILE="Build/phpstan/phpstan.neon"
 IS_CORE_CI=0
 
 # Option parsing updates above default vars

Build/phpstan/phpstan.neon

@@ -1,9 +1,9 @@
 includes:
   - phpstan-baseline.neon
-  - .Build/vendor/spaze/phpstan-disallowed-calls/disallowed-dangerous-calls.neon
-  - .Build/vendor/spaze/phpstan-disallowed-calls/disallowed-execution-calls.neon
-  - .Build/vendor/spaze/phpstan-disallowed-calls/disallowed-insecure-calls.neon
-  - .Build/vendor/spaze/phpstan-disallowed-calls/disallowed-loose-calls.neon
+  - ../../.Build/vendor/spaze/phpstan-disallowed-calls/disallowed-dangerous-calls.neon
+  - ../../.Build/vendor/spaze/phpstan-disallowed-calls/disallowed-execution-calls.neon
+  - ../../.Build/vendor/spaze/phpstan-disallowed-calls/disallowed-insecure-calls.neon
+  - ../../.Build/vendor/spaze/phpstan-disallowed-calls/disallowed-loose-calls.neon
 
 parameters:
   phpVersion: 80100
@@ -15,10 +15,10 @@ parameters:
   level: 9
 
   paths:
-    - Classes
-    - Configuration
-    - Tests
-    - ext_localconf.php
+    - ../../Classes
+    - ../../Configuration
+    - ../../Tests
+    - ../../ext_localconf.php
 
   # Allow instanceof checks, particularly in tests
   checkAlwaysTrueCheckTypeFunctionCall: false
@@ -69,4 +69,4 @@ parameters:
   ignoreErrors:
     -
       message: '#Out of 1 possible constant types#'
-      path: Tests/Functional/Command/CreateTestDataCommandTest.php
+      path: ../../Tests/Functional/Command/CreateTestDataCommandTest.php

composer.json

@@ -148,7 +148,7 @@
 		"ci:php:lint": "parallel-lint *.php Build Classes Configuration Tests",
 		"ci:php:mess": "phpmd Classes text Build/phpmd/phpmd.xml",
 		"ci:php:rector": "rector --dry-run",
-		"ci:php:stan": "phpstan --no-progress -v",
+		"ci:php:stan": "phpstan --no-progress -v --configuration=Build/phpstan/phpstan.neon",
 		"ci:static": [
 			"@ci:composer:normalize",
 			"@ci:composer:unused",
@@ -183,7 +183,7 @@
 		],
 		"fix:php:cs": "php-cs-fixer fix --config ./Build/php-cs-fixer/php-cs-fixer.php",
 		"fix:php:rector": "rector",
-		"phpstan:baseline": "phpstan --generate-baseline --allow-empty-baseline",
+		"phpstan:baseline": "phpstan --generate-baseline --allow-empty-baseline --configuration=Build/phpstan/phpstan.neon",
 		"prepare-release": [
 			"rm -rf .Build",
 			"rm -rf .ddev",
@@ -203,8 +203,6 @@
 			"rm package-lock.json",
 			"rm package.json",
 			"rm phive.xml",
-			"rm phpstan-baseline.neon",
-			"rm phpstan.neon",
 			"rm rector.php",
 			"rm stylelint.config.js"
 		]