mirror of https://github.com/FriendsOfTYPO3/tea.git synced 2024-11-10 01:16:12 +01:00

[TASK] Remove security checker (#111)

Resolves: #110
This commit is contained in:
Łukasz Uznański 2020-10-07 14:10:44 +02:00 committed by GitHub
parent 38641babb1
commit 0338647e34
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 27 deletions

View file

@ -197,28 +197,3 @@ jobs:
typo3-version:
- ^9.5
- ^10.4
security-test:
name: "PHP Security test"
runs-on: ubuntu-latest
strategy:
matrix:
php-version:
- 7.4
steps:
- name: Checkout
uses: actions/checkout@v2
- name: "Install PHP"
uses: shivammathur/setup-php@v2
with:
php-version: "${{ matrix.php-version }}"
- name: "Cache dependencies installed with composer"
uses: actions/cache@v1
with:
key: "php${{ matrix.php-version }}
-composer-${{ hashFiles('**/composer.json') }}"
path: ~/.composer/cache
restore-keys: "php${{ matrix.php-version }}-composer-\n"
- name: "Install Composer dependencies"
run: "composer install --no-progress"
- name: "Run PHP Security test"
run: "composer ci:security"

View file

@ -79,6 +79,15 @@ For creating new extensions, I recommend taking
[Helmut Hummel's extension skeleton](https://github.com/helhum/ext_scaffold)
as a starting point.
## Security
Libraries and extensions do not need the security check as they should not have
any restrictions concerning the other libraries they are installed alongside with
(unless those would create breakage), and they also do not have a `composer.lock`
which usually is the source for security checks.
Instead, the projects (i.e., for TYPO3 installations) need to have the security checks.
## More Documentation
* [Handout to my workshops on test-driven development (TDD)](https://github.com/oliverklee/tdd-reader)

View file

@ -42,7 +42,6 @@
"typo3/cms-fluid-styled-content": "^9.5 || ^10.4",
"seld/jsonlint": "^1.8",
"phpdocumentor/reflection-docblock": "<= 5.1 || > 5.2",
"sensiolabs/security-checker": "^6.0",
"j13k/yaml-lint": "1.1.x-dev"
},
"replace": {
@ -75,7 +74,6 @@
"ci:ts:lint": ".Build/vendor/bin/typoscript-lint -c Configuration/TsLint.yml --ansi -n --fail-on-warnings -vvv Configuration/TypoScript",
"ci:tests:unit": ".Build/vendor/bin/phpunit -c .Build/vendor/nimut/testing-framework/res/Configuration/UnitTests.xml Tests/Unit",
"ci:tests:functional": "find 'Tests/Functional' -wholename '*Test.php' | parallel --gnu 'echo; echo \"Running functional test suite {}\"; .Build/vendor/bin/phpunit -c .Build/vendor/nimut/testing-framework/res/Configuration/FunctionalTests.xml {}';",
"ci:security": ".Build/vendor/bin/security-checker security:check",
"ci:tests": [
"@ci:tests:unit",
"@ci:tests:functional"