Commit graph

371 commits

Author SHA1 Message Date
Daniel Siepmann b9bdd5dd3b
TASK: Migrate RemovedClassFeature
* Also migrate RemovedClassFeature to new structure with
  AbstractYamlRemovedUsage

Relates: #71
2017-04-27 14:05:05 +02:00
Daniel Siepmann bcbd1f96bc
TASK: Migrate GenericConstantUsageSniff
* Migrate GenericConstantUsageSniff to new architecture.
* Move non common functionality from AbstractGenericPhpUsage to concrete
  classes.

Relates: #71
2017-04-27 13:33:28 +02:00
Daniel Siepmann 84dd380a3c
TASK: Migrate GenericFunctionCallSniff
* Migrate GenericFunctionCallSniff to new architecture.
* Provide new abstract class for php removed functions and constants.
* Fix TypoScriptSniff not always returning array.
* Adjust warnings in Expected.json

Relates: #71
2017-04-27 13:23:51 +02:00
Daniel Siepmann 5704351d22
TASK: Adjust to PHP 7.1
* As PHP 7.1 is required, document and adjust tests in CI.

Relates: #71
2017-04-27 12:53:07 +02:00
Daniel Siepmann 2659066e21
WIP|TASK: Migrate Typo3Update_Sniffs_Removed_TypoScriptSniff
* Refactor yaml based removed check architecture.
* Migrate TypoScriptSniff to new architecture.

Relates: #71
2017-04-27 12:51:16 +02:00
Daniel Siepmann fad2a4e498
FEATURE: Allow empty feature yaml files
* Handle empty yaml files for features in options class.
2017-04-27 11:48:59 +02:00
Daniel Siepmann f972533e04 WIP|FEATURE: Check for removed php classes.
* Add feature to existing code base and logic, see #72 .
* Add first removed classes for TYPO3 7.0 as example.
* Adjust first test to make sure basic implementation works.

Relates: #41
2017-04-27 11:23:29 +02:00
Daniel Hürtgen 01af1eaf4b Merge branch 'feature/54-add-checks-for-typoscript' into 'develop'
Feature/54 add checks for typoscript

Closes #54

See merge request !74
2017-04-27 10:45:13 +02:00
Daniel Hürtgen b1b86a8ece Merge branch 'feature/72-refactor-sniff-architecture' into 'develop'
Feature/72 refactor sniff architecture

Closes #72

See merge request !78
2017-04-27 10:34:30 +02:00
Daniel Hürtgen 7398caa099 TASK: Simplfy “features" iterator 2017-04-27 10:23:02 +02:00
Daniel Hürtgen cecfe983e0 TASK: Simplfy feature support trait 2017-04-27 10:17:05 +02:00
Daniel Siepmann e4f26abe71
TASK: Add test case
* Also test that we don't modify working parts
2017-04-25 16:36:41 +02:00
Daniel Siepmann 370015e7c0
TASK: Refactor code
* Reduce indentation.
* Provide internal API to add new feature with necessary checks.
2017-04-25 16:36:12 +02:00
Daniel Siepmann 7f7a7aa38d
TASK: Add missing docs 2017-04-25 16:35:54 +02:00
Daniel Siepmann 69bb97ad94
Merge branch 'feature/72-refactor-sniff-architecture' into feature/54-add-checks-for-typoscript 2017-04-25 15:50:04 +02:00
Daniel Siepmann 27997c8445
TASK: Link to configuration in docs. 2017-04-25 15:37:16 +02:00
Daniel Siepmann add747d0be
TASK: Fix type of headline in docs 2017-04-25 15:37:01 +02:00
Daniel Siepmann 5428b3805f
TASK: Document new feature in docs 2017-04-25 15:36:47 +02:00
Daniel Siepmann 28329844b8
TASK: Update docs
* To keep naming in sync with code, to make examples work.
2017-04-25 15:36:20 +02:00
Daniel Siepmann 22d50486cf
TASK: Remove unused intersphinx
* As long as we don't make use of intersphinx disable it to speed up
  rendering of documentation.
2017-04-25 15:35:24 +02:00
Daniel Siepmann 2cc21fdafa
TASK: Cleanup code
* Remove unnecessary documentation.
* Remove unused code.
* Add missing documentation.

Relates: #72
2017-04-25 15:20:35 +02:00
Daniel Siepmann 21cf62b949
TASK: migrate InheritanceSniff
Relates: #72
2017-04-25 15:09:32 +02:00
Daniel Siepmann 14c82e4a10 TASK: Migrate IsACallSniff
* Add further tests with quotes.
* Handle prefix in strings.
* Remove old originalTokenContent which is no longer in use, as we use
  str_replace, introduced in earlier commit.

Relates: #72
2017-04-25 14:36:19 +02:00
Daniel Siepmann d12990f6e1
TASK: Streamline test output on error 2017-04-25 14:16:59 +02:00
Daniel Siepmann efd5d9114f
TASK: Migrate MissingNamespaceSniff
* Make MissingNamespaceSniff work again.
* Move to old namespace as it's a custom sniff, not a general one.
* Do not use new feature here, implement logic internal.
* Remove message from ruleset, use it directly.

Relates: #72
2017-04-25 14:11:40 +02:00
Daniel Siepmann d3b612790c
TASK: Make inline replacements work again
* As sometimes not the whole token should be replaces, but only the
  classname within the token, we replace them always this way.
* Before the refactoring, that was done in the concrete sniffs.
* Affected are e.g. php doc comments.

Relates: #72
2017-04-25 13:45:46 +02:00
Daniel Siepmann 8572740fd1
TASK: Shorten test output
* Remove unnecessary information to shorten output.
* This should make it easier to get the actual issue.
2017-04-25 13:41:36 +02:00
Daniel Siepmann c91dc8065f
TASK: Make TypeHintCatchExceptionSniff work again
* Fix wrong class name, to allow features to match.

Relates: #72
2017-04-25 13:33:56 +02:00
Daniel Siepmann 0c6bb133a1
TASK: Make some tests pass again
* All tests where only file name in diff was wrong are working again.

Relates: #72
2017-04-25 13:28:09 +02:00
Daniel Siepmann c4c8faacd2
WIP: Fix TypeHintSniff
* Make TypeHintSniff tests pass again.
* Fix typo in class name preventing new feature mechanism from matching.

Relates: #72
2017-04-25 13:25:48 +02:00
Daniel Siepmann 94df1f2ad1
WIP: Fix use sniff
* Make use sniff tests pass again.

Relates: #72
2017-04-25 13:16:58 +02:00
Daniel Siepmann 2b1a1a0f19
WIP: Fix broken MissingVendorForPluginsAndModulesSniff tests
Relates: #72
2017-04-25 13:05:48 +02:00
Daniel Siepmann cc0be4a5b4
WIP: Move features to own namespace
* Have all feature related classes in a single namespace.

Relates: #72
2017-04-25 13:03:36 +02:00
Daniel Siepmann 2f6dc2304a
WIP: Refactor code to new architecture
* Migrate class names.
* Add new architecture of "Features".
* Configure old assignments for new features.
* Rename necessary parts.

Relates: #72
2017-04-25 12:58:19 +02:00
Daniel Siepmann b502e52920
TASK: Add missing license
* Add license to file.
2017-04-25 08:20:08 +02:00
Daniel Hürtgen 99e38e43af Merge branch 'feature/cleanup' into 'develop'
TASK: Remove no longer used .scrutinizer.yml

See merge request !76
2017-04-13 23:48:18 +02:00
Daniel Siepmann 0b7828e6c5
TASK: Remove no longer used .scrutinizer.yml
* As we don't use Scrutinizer any longer, but our own CI on gitlab.
2017-04-13 19:06:30 +02:00
Daniel Hürtgen 851e81d194 Merge branch 'feature/improve-ci' into 'develop'
Improve CI file

See merge request !75
2017-04-13 17:58:04 +02:00
Daniel Hürtgen 0a212788fb Merge branch 'hotfix/add-readme-again' into 'develop'
TASK: Update readme

See merge request !73
2017-04-13 17:56:51 +02:00
Daniel Siepmann 42e04617bc
BUGFIX: CGL issue
* Follow CGL and fix issue.
2017-04-13 16:14:56 +02:00
Daniel Siepmann af43a99bfd
TASK: Use yaml references
* Don't repeat yourself.
* Make file shorter and easier to read.
* Also make it easier to change something.
2017-04-13 16:13:16 +02:00
Daniel Siepmann 7ed37db05f
TASK: Only generate one report
* As second report is not necessary and won't be generated since the
  first call will return exit > 0
2017-04-13 16:12:46 +02:00
Daniel Siepmann aabb7a5059
TASK: Generate multiple reports
* As no further calls are made once a call failed.
* Therefore call all reports in a single command.
2017-04-13 16:11:04 +02:00
Daniel Siepmann 498e00c6f0
TASK: Add missing phpdoc 2017-04-13 16:05:34 +02:00
Daniel Siepmann 6e602cf5f5
TASK: Add all remaining TypoScripts
Resolves: #54
2017-04-13 16:02:40 +02:00
Daniel Siepmann 5387e553c5
TASK: Add remaining TypoScript changes for 7.1
Relates: #54
2017-04-13 15:51:01 +02:00
Daniel Siepmann 74eb4dde20
TASK: Document yaml structure
* To ease contributions and modifications

Relates: #54
2017-04-13 15:44:52 +02:00
Daniel Siepmann 7c5d95d0e0
TASK: Update test
* Make sure test is running again with new additions of cObjects.
* Also fix description containing dot at the end.

Relates: #54
2017-04-13 15:30:42 +02:00
Daniel Siepmann 3e9d8c01c8
TASK: Rename TypoScript sniff
* As we not only check ObjectIdentifier's anymore, but also further
  parts, renamce sniff to be more generic.
* Also rename configuration and tests accordingly.

Relates: #54
2017-04-13 15:27:25 +02:00
Daniel Siepmann ca4d687155
FEATURE: Also check TypoScript objects
* Not only check paths, but also objects like cObjects.
* Update test input for verification.
* Add further breaking changes for 7.1
2017-04-13 15:22:38 +02:00