Work-Related/thuecat
Work-Related/thuecat
1
0
mirror of https://github.com/werkraum-media/thuecat.git synced 2024-06-26 13:28:56 +02:00
Code Issues Activity

Add tests for modified models

Browse source 
That's necessary as models grow.
Added features should be tested to not break with future changes.

The tests revealed an existing error in fallback which got fixed to make
new test pass.

Relates: #18
This commit is contained in:
Daniel Siepmann 2021-04-14 11:27:15 +02:00
parent 960d2debec
commit bbf7ada1d2
3 changed files with 283 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Classes/Domain/Model/Frontend/OpeningHour.php
View file

@ -83,7 +83,7 @@ class OpeningHour
return new self(
$rawData['opens'] ?? '',
$rawData['closes'] ?? '',
$rawData['daysOfWeek'] ?? '',
$rawData['daysOfWeek'] ?? [],
$from,
$through
);

174
Tests/Unit/Domain/Model/Frontend/OffersTest.php Normal file
View file

@ -0,0 +1,174 @@
<?php
declare(strict_types=1);
namespace WerkraumMedia\ThueCat\Tests\Unit\Domain\Model\Frontend;
/*
* Copyright (C) 2021 Daniel Siepmann <coding@daniel-siepmann.de>
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
* 02110-1301, USA.
*/
use PHPUnit\Framework\TestCase;
use WerkraumMedia\ThueCat\Domain\Model\Frontend\Offers;
/**
* @covers WerkraumMedia\ThueCat\Domain\Model\Frontend\Offers
* @testdox Frontend model for offers
*/
class OffersTest extends TestCase
{
/**
* @test
*/
public function canBeCreated(): void
{
$subject = new Offers('{}');
self::assertInstanceOf(Offers::class, $subject);
}
/**
* @test
*/
public function isCountable(): void
{
$subject = new Offers('{}');
self::assertInstanceOf(\Countable::class, $subject);
}
/**
* @test
*/
public function isIterator(): void
{
$subject = new Offers('{}');
self::assertInstanceOf(\Iterator::class, $subject);
}
/**
* @test
* @dataProvider forCount
* @testdox returns $expected for count
*/
public function returnsExpectedCount(string $serialized, int $expected): void
{
$subject = new Offers($serialized);
self::assertCount($expected, $subject);
}
public function forCount(): array
{
return [
'zero' => [
'serialized' => '{}',
'expected' => 0,
],
'one' => [
'serialized' => json_encode([
[
'title' => '',
'description' => '',
'prices' => [
[
'title' => '',
'description' => '',
'price' => 5.0,
'currency' => '',
'rule' => '',
],
],
],
]),
'expected' => 1,
],
'five' => [
'serialized' => json_encode([
[
'title' => '',
'description' => '',
'prices' => [
[
'title' => '',
'description' => '',
'price' => 5.0,
'currency' => '',
'rule' => '',
],
],
],
[
'title' => '',
'description' => '',
'prices' => [
[
'title' => '',
'description' => '',
'price' => 5.0,
'currency' => '',
'rule' => '',
],
],
],
[
'title' => '',
'description' => '',
'prices' => [
[
'title' => '',
'description' => '',
'price' => 5.0,
'currency' => '',
'rule' => '',
],
],
],
[
'title' => '',
'description' => '',
'prices' => [
[
'title' => '',
'description' => '',
'price' => 5.0,
'currency' => '',
'rule' => '',
],
],
],
[
'title' => '',
'description' => '',
'prices' => [
[
'title' => '',
'description' => '',
'price' => 5.0,
'currency' => '',
'rule' => '',
],
],
],
]),
'expected' => 5,
],
];
}
}

108
Tests/Unit/Domain/Model/Frontend/OpeningHoursTest.php Normal file
View file

@ -0,0 +1,108 @@
<?php
declare(strict_types=1);
namespace WerkraumMedia\ThueCat\Tests\Unit\Domain\Model\Frontend;
/*
* Copyright (C) 2021 Daniel Siepmann <coding@daniel-siepmann.de>
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
* 02110-1301, USA.
*/
use PHPUnit\Framework\TestCase;
use WerkraumMedia\ThueCat\Domain\Model\Frontend\OpeningHours;
/**
* @covers WerkraumMedia\ThueCat\Domain\Model\Frontend\OpeningHours
* @testdox Frontend model for offers
*/
class OpeningHoursTest extends TestCase
{
/**
* @test
*/
public function canBeCreated(): void
{
$subject = new OpeningHours('{}');
self::assertInstanceOf(OpeningHours::class, $subject);
}
/**
* @test
*/
public function isCountable(): void
{
$subject = new OpeningHours('{}');
self::assertInstanceOf(\Countable::class, $subject);
}
/**
* @test
*/
public function isIterator(): void
{
$subject = new OpeningHours('{}');
self::assertInstanceOf(\Iterator::class, $subject);
}
/**
* @test
* @dataProvider forCount
* @testdox returns $expected for count
*/
public function returnsExpectedCount(string $serialized, int $expected): void
{
$subject = new OpeningHours($serialized);
self::assertCount($expected, $subject);
}
public function forCount(): array
{
return [
'zero' => [
'serialized' => '{}',
'expected' => 0,
],
'one' => [
'serialized' => json_encode([
[
],
]),
'expected' => 1,
],
'five' => [
'serialized' => json_encode([
[
],
[
],
[
],
[
],
[
],
]),
'expected' => 5,
],
];
}
}