Remove API Key from site configuration (#72)

The key is configured via Extension Configuration.
Documentation and code match, but we still extended the site
configuration.

Resolves: #55

Configuration/SiteConfiguration/Overrides/sites.php

@@ -1,27 +0,0 @@
-<?php
-
-defined('TYPO3') or die();
-
-(static function (string $extensionKey, string $tableName) {
-    $languagePath = \WerkraumMedia\ThueCat\Extension::getLanguagePath() . 'locallang_be.xlf:' . $tableName . '.';
-
-    \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($GLOBALS['SiteConfiguration']['site'], [
-        'columns' => [
-            'thuecat_api_key' => [
-                'label' => $languagePath . 'thuecat_api_key',
-                'config' => [
-                    'type' => 'input',
-                ],
-            ],
-        ],
-        'types' => [
-            '0' => [
-                'showitem' => $GLOBALS['SiteConfiguration']['site']['types']['0']['showitem']
-                . ', ' . implode(',', [
-                    '--div--;' . $languagePath . 'div.thuecat',
-                    'thuecat_api_key',
-                ]),
-            ],
-        ],
-    ]);
-})(\WerkraumMedia\ThueCat\Extension::EXTENSION_KEY, 'site');

Documentation/Changelog/1.3.0.rst

@@ -19,7 +19,9 @@ Nothing
 Tasks
 -----
 
-Nothing
+Removed API Key from site configuration.
+The key was already moved to extension configuration as documented.
+Still we extended the site configuration, which is now cleaned up, see: https://github.com/werkraum-media/thuecat/issues/55
 
 Deprecation
 -----------

phpstan-baseline.neon

@@ -284,11 +284,6 @@ parameters:
 			count: 1
 			path: Classes/Frontend/DataProcessing/ResolveEntities.php
 
-		-
-			message: "#^Right side of \\|\\| is always false\\.$#"
-			count: 1
-			path: Configuration/SiteConfiguration/Overrides/sites.php
-
 		-
 			message: "#^Right side of \\|\\| is always false\\.$#"
 			count: 1