Work-Related/search_core
Work-Related/search_core
1
0
mirror of https://github.com/Codappix/search_core.git synced 2024-09-21 15:56:14 +02:00
Code Releases Activity

TASK: Improve ResultItemTest

Browse source 
Do not repeat content, use variable which is also better to read.
And do not add unnecessary, unused, variables.
This commit is contained in:
Daniel Siepmann 2018-03-06 13:04:42 +01:00
parent f0e58afe01
commit a893303939
Signed by: Daniel Siepmann
GPG key ID: 33D6629915560EF4
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Tests/Unit/Domain/Model/ResultItemTest.php
View file

@ -57,7 +57,7 @@ class ResultItemTest extends AbstractUnitTestCase
$subject = new ResultItem($originalData); $subject = new ResultItem($originalData);
$this->assertSame( $this->assertSame(
'Some title', $originalData['title'],
$subject['title'], $subject['title'],
'Could not retrieve title in array notation.' 'Could not retrieve title in array notation.'
); );
@ -72,7 +72,6 @@ class ResultItemTest extends AbstractUnitTestCase
'uid' => 10, 'uid' => 10,
'title' => 'Some title', 'title' => 'Some title',
]; ];
$expectedData = $originalData;
$subject = new ResultItem($originalData); $subject = new ResultItem($originalData);
$this->assertTrue(isset($subject['title']), 'Could not determine that title exists.'); $this->assertTrue(isset($subject['title']), 'Could not determine that title exists.');
@ -88,7 +87,6 @@ class ResultItemTest extends AbstractUnitTestCase
'uid' => 10, 'uid' => 10,
'title' => 'Some title', 'title' => 'Some title',
]; ];
$expectedData = $originalData;
$subject = new ResultItem($originalData); $subject = new ResultItem($originalData);
$this->expectException(\BadMethodCallException::class); $this->expectException(\BadMethodCallException::class);
@ -104,7 +102,6 @@ class ResultItemTest extends AbstractUnitTestCase
'uid' => 10, 'uid' => 10,
'title' => 'Some title', 'title' => 'Some title',
]; ];
$expectedData = $originalData;
$subject = new ResultItem($originalData); $subject = new ResultItem($originalData);
$this->expectException(\BadMethodCallException::class); $this->expectException(\BadMethodCallException::class);