mirror of
https://github.com/Codappix/search_core.git
synced 2024-12-22 12:16:10 +01:00
Merge branch 'develop' into feature/119-allow-range-queries-for-elasticsearch
This commit is contained in:
commit
7b336f3fa5
4 changed files with 88 additions and 14 deletions
|
@ -29,6 +29,11 @@ class FacetOption implements FacetOptionInterface
|
|||
*/
|
||||
protected $name = '';
|
||||
|
||||
/**
|
||||
* @var string
|
||||
*/
|
||||
protected $displayName = '';
|
||||
|
||||
/**
|
||||
* @var int
|
||||
*/
|
||||
|
@ -40,21 +45,21 @@ class FacetOption implements FacetOptionInterface
|
|||
public function __construct(array $bucket)
|
||||
{
|
||||
$this->name = $bucket['key'];
|
||||
$this->displayName = isset($bucket['key_as_string']) ? $bucket['key_as_string'] : $this->getName();
|
||||
$this->count = $bucket['doc_count'];
|
||||
}
|
||||
|
||||
/**
|
||||
* @return string
|
||||
*/
|
||||
public function getName()
|
||||
public function getName() : string
|
||||
{
|
||||
return $this->name;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return int
|
||||
*/
|
||||
public function getCount()
|
||||
public function getDisplayName() : string
|
||||
{
|
||||
return $this->displayName;
|
||||
}
|
||||
|
||||
public function getCount() : int
|
||||
{
|
||||
return $this->count;
|
||||
}
|
||||
|
|
|
@ -28,15 +28,17 @@ interface FacetOptionInterface
|
|||
/**
|
||||
* Returns the name of this option. Equivalent
|
||||
* to value used for filtering.
|
||||
*
|
||||
* @return string
|
||||
*/
|
||||
public function getName();
|
||||
public function getName() : string;
|
||||
|
||||
/**
|
||||
* If a pre-rendered name is provided, this will be returned.
|
||||
* Otherwise it's the same as getName().
|
||||
*/
|
||||
public function getDisplayName() : string;
|
||||
|
||||
/**
|
||||
* Returns the number of found results for this option.
|
||||
*
|
||||
* @return int
|
||||
*/
|
||||
public function getCount();
|
||||
public function getCount() : int;
|
||||
}
|
||||
|
|
64
Tests/Unit/Connection/Elasticsearch/FacetOptionTest.php
Normal file
64
Tests/Unit/Connection/Elasticsearch/FacetOptionTest.php
Normal file
|
@ -0,0 +1,64 @@
|
|||
<?php
|
||||
namespace Codappix\SearchCore\Tests\Unit\Connection\Elasticsearch;
|
||||
|
||||
/*
|
||||
* Copyright (C) 2018 Daniel Siepmann <coding@daniel-siepmann.de>
|
||||
*
|
||||
* This program is free software; you can redistribute it and/or
|
||||
* modify it under the terms of the GNU General Public License
|
||||
* as published by the Free Software Foundation; either version 2
|
||||
* of the License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with this program; if not, write to the Free Software
|
||||
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
|
||||
* 02110-1301, USA.
|
||||
*/
|
||||
|
||||
use Codappix\SearchCore\Connection\Elasticsearch\FacetOption;
|
||||
use Codappix\SearchCore\Tests\Unit\AbstractUnitTestCase;
|
||||
|
||||
class FacetOptionTest extends AbstractUnitTestCase
|
||||
{
|
||||
/**
|
||||
* @test
|
||||
*/
|
||||
public function displayNameIsReturnedAsExpected()
|
||||
{
|
||||
$bucket = [
|
||||
'key' => 'Name',
|
||||
'key_as_string' => 'DisplayName',
|
||||
'doc_count' => 10,
|
||||
];
|
||||
$subject = new FacetOption($bucket);
|
||||
|
||||
$this->assertSame(
|
||||
$bucket['key_as_string'],
|
||||
$subject->getDisplayName(),
|
||||
'Display name was not returned as expected.'
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @test
|
||||
*/
|
||||
public function displayNameIsReturnedAsExpectedIfNotProvided()
|
||||
{
|
||||
$bucket = [
|
||||
'key' => 'Name',
|
||||
'doc_count' => 10,
|
||||
];
|
||||
$subject = new FacetOption($bucket);
|
||||
|
||||
$this->assertSame(
|
||||
$bucket['key'],
|
||||
$subject->getDisplayName(),
|
||||
'Display name was not returned as expected.'
|
||||
);
|
||||
}
|
||||
}
|
|
@ -37,6 +37,9 @@
|
|||
]
|
||||
},
|
||||
"extra": {
|
||||
"branch-alias": {
|
||||
"dev-develop": "1.0.x-dev"
|
||||
},
|
||||
"typo3/cms": {
|
||||
"cms-package-dir": "{$vendor-dir}/typo3/cms",
|
||||
"web-dir": ".Build/web"
|
||||
|
|
Loading…
Reference in a new issue