Commit graph

245 commits

Author SHA1 Message Date
c506720689 Respect that interval is now always set within timeIntervals
The property will always be set in the future.
We no longer can use it as an indicator.

We switch to freq as new indicator.
We also ensure that start has to be given for a single date.

Relates: #9892
2022-04-25 07:47:47 +02:00
425da4bb33 Update phpstan issues 2022-04-21 09:36:51 +02:00
4ef67b9bae Refactor date creation during import
Split into own class to encapsulate the logic.
2022-04-21 09:30:23 +02:00
948f571f9d Extend functional test with daily and weekly frequency
Both are supported during import from destination data.
But both were not part of functional tests yet.
They are added in order to ensure that future changes wont break import
of that data
2022-04-21 08:29:45 +02:00
Dirk Koritnik
fe93eeeb48 Add new icon for configuration data 2022-02-03 15:54:27 +01:00
3d6bf0ac8a Add import configuration record
It is now possible to create "Import" records in TYPO3 system.
Those records can then be imported via two new commands.
There is no need to configure everything within the command itself.

That allows:
    * To allow editors to maintain import configuration.
    * Have proper labels, description, csh and UI to create import.
      It no longer is necessary to copy UIDs,
      instead proper wizards from TCA are available to select pages.

Relates: #9649
2022-01-27 15:50:36 +01:00
4bc4f34525 Add support for search query in DO import command
Relates: #9648
2022-01-27 07:57:05 +01:00
8044ddf30f Make use of prophesize cross version support 2022-01-26 15:56:28 +01:00
b5d095659a Use new import class and move url building and fetching 2022-01-26 15:15:15 +01:00
295ad8645a Don't break PHPStan due to updated dependencies type hints 2022-01-26 15:04:28 +01:00
c3333f0147 Fix example data to work for some years
There was still one entry which reached end of life and was increased.
2022-01-26 15:02:21 +01:00
dcb071fe3d Actually execute phpstan in phpstan 7.2 job, not phpunit 2022-01-26 15:02:20 +01:00
a55f685abc Support composer v2.2.x
The new LTS has a new allow-plugins feature which we configure.
2022-01-26 13:59:52 +01:00
3c4fff0879 Add changelog for upcoming 2.2.0 2021-12-20 10:34:22 +01:00
c6ca707b1c Fix warnings in higher PHP versions ending up in TYPO3 log 2021-12-20 10:20:47 +01:00
06d111e132 Do not trigger warning if no category was configured
The import already worked without category, but triggered a warning.
Tests were extended to always work with category, except in new test
case.
All tests were extended to check for empty logs in the end.

The import now checks whether category should be imported and ignores
further processing if not configured.

Relates: #9542
2021-12-20 10:15:26 +01:00
eecbb1feb4 Remove useless file
This got introduced somewhere during refactoring but was left empty
anyway.
2021-12-20 10:15:09 +01:00
ab9c3e0c4e Fix broken remove past data
Past data is now removed again.
A test ensures the functionality.
Data is no longer marked as deleted but is actually deleted.

Relates: #9543
2021-12-20 09:45:25 +01:00
a8c475fbd7 Reflect TYPO3 behaviour in tests
TYPO3 scheduler tasks always have a value for console commands.
Region uid will be an empty string if omitted within scheduler task.
We reflect that in our tests and adapt code to not break.
Furthermore tests call only with strings, as that's what TYPO3 does.
2021-12-16 14:34:17 +01:00
6aa4681cb9 Delete files which were referenced by events objects
Adjust existing code base to not use hardcoded file path.
Instead use info from database and check all files which have references
to event objects.

Also add test to cover feature.
2021-12-16 14:07:32 +01:00
f06f9c3303 Use empty image for tests
We do not need content, so no need for an actual image which uses space
and might have some license.
2021-12-16 13:20:43 +01:00
410f5ab534 Fix naming of test 2021-12-16 13:20:16 +01:00
fb2eceb5e6 Refactor tests to move common code into parent class
This keeps tests smaller and everyone can see the setup of the test and
assertions, without boilerplate code in between.
2021-12-16 10:12:26 +01:00
15dec49445 Remove usage of uploads folder, use transient API instead
Relates: #9533
2021-12-16 10:00:51 +01:00
de82e395e6 Fix Coding Guideline check on CI
The current setup actually fixed and didn't check or fail.
That's changed and code is fixed.
2021-12-16 09:13:15 +01:00
0e5cd38176 Add first basic functional test for import
The test ensures import runs with a small example set of events.

We needed to alter fetching of images, in order to properly mock
responses.
2021-12-16 09:08:16 +01:00
73161fa24e Make region optional during import 2021-12-14 17:31:56 +01:00
29c31375a5 Remove PHPStan issues
Most were fixed, some were ignored on top level.
2021-12-14 17:31:46 +01:00
a576709947 Use dependency injection within command
Do not fetch service with legacy API, instead use proper Dependency
Injection.

Relates: #9532
2021-12-14 16:09:42 +01:00
c2e648b2c5 Remove no longer existing ctrl entry 2021-12-13 09:42:24 +01:00
0d0c64f419 Fix PHPStan issues 2021-12-13 09:27:28 +01:00
b430993655 Remove execution rights from php file 2021-12-13 08:51:32 +01:00
c09c3ffb57 Add proper description to command output in v11 2021-12-13 08:48:44 +01:00
ff3a577935 Add TYPO3 v11 configurations 2021-12-13 08:48:34 +01:00
f44bcd5d04 Remove ExtensionBuilder related stuff 2021-12-13 08:48:22 +01:00
d99e690a98 Migrate readme to Documentation 2021-12-13 08:48:10 +01:00
a06ac46ae3 Add PHP 8.0 to CI 2021-12-13 08:29:20 +01:00
0764aa9f0f Add PHP 8.0 to CI 2021-12-13 08:29:16 +01:00
fb0cb60b97 Update changelog 2021-12-08 09:12:26 +01:00
2f2957ef6c Cleanup Documentation
Remove all boilerplate which was not touched anyway.
Migrate from Settings.yml to Settings.cfg.
2021-12-08 09:11:22 +01:00
34dff294ea Add proper Changelog to documentation from now on 2021-12-08 09:06:57 +01:00
ce3863619e Add query callback to date demand
This allows 3rd party to alter the query of dates when demand is used.
E.g. allow more complex filters specific for some situations like CEs.

Relates: #9505
2021-12-07 15:26:25 +01:00
30f030aab6 !!!|Show all coming + running dates by default
Only coming dates were shown by default.

Relates: #9505
2021-12-06 12:34:32 +01:00
bc6aa4d359 Apply stdWrap to date demand settings
Move to a dedicated factory for easier re use.
Add dependencies and apply stdWrap to properties.
That allows to dynamically set values like dates by using stdWrap
features.

E.g.:

    settings {
        end {
            strtotime = midnight +1 day
        }
    }

Relates: #9505
2021-12-06 12:34:32 +01:00
809ef032f4 Allow editing and creation of dates within event
Relates: #9471
2021-11-23 08:28:22 +01:00
c38241f351 Fix broken upcoming feature
Using a FlexForm results in stored Unixtimestamps.
Adding 00:00 and using strtotime will result in false, resulting in
null.

We now just keep the provided value as integer.
That way underlying code works as expected and delivers events from
given start date.

Relates: #9352, #8581
2021-10-11 11:33:52 +02:00
f0ee19cfae Fix CGL ordering of import statements
Update of dev dependency results in better sorting of UpperCamelCase.
2021-10-11 11:33:11 +02:00
de6c317602 Do not break PHPStan due to new PHPDoc in TYPO3 source
Update of TYPO3 results in the following error:

     ------ -----------------------------------------------------------------------
     Line   Classes/Service/DestinationDataImportService.php
    ------ -----------------------------------------------------------------------
     135    Property
            Wrm\Events\Service\DestinationDataImportService::$objectManager with
            generic class TYPO3\CMS\Extbase\Object\ObjectManager does not specify
            its types: T
            💡 You can turn this off by setting
            checkGenericClassInNonGenericObjectType: false in your
            phpstan.neon.
     160    Method Wrm\Events\Service\DestinationDataImportService::__construct()
            has parameter $objectManager with generic class
            TYPO3\CMS\Extbase\Object\ObjectManager but does not specify its
            types: T
            💡 You can turn this off by setting
            checkGenericClassInNonGenericObjectType: false in your
            phpstan.neon.
    ------ -----------------------------------------------------------------------

We disable the check for now.
2021-10-11 11:32:27 +02:00
Dirk Koritnik
d5ad0a66a8 Fix probems with catgories
* make sure no empty category is listed in search filter
* fix type error in dd import
2021-09-08 11:03:30 +00:00
22e75d4729 Do not load all dates of each event
Most of the time dates are fetched and shown.
They need the event to show info like title.
But they nearly never need further dates, except in detail view.

Turning this property lazy will save a lot of data fetching and mapping
and provides a huge performance impact.
2021-09-08 10:13:01 +02:00