Commit graph

154 commits

Author SHA1 Message Date
06d111e132 Do not trigger warning if no category was configured
The import already worked without category, but triggered a warning.
Tests were extended to always work with category, except in new test
case.
All tests were extended to check for empty logs in the end.

The import now checks whether category should be imported and ignores
further processing if not configured.

Relates: #9542
2021-12-20 10:15:26 +01:00
eecbb1feb4 Remove useless file
This got introduced somewhere during refactoring but was left empty
anyway.
2021-12-20 10:15:09 +01:00
ab9c3e0c4e Fix broken remove past data
Past data is now removed again.
A test ensures the functionality.
Data is no longer marked as deleted but is actually deleted.

Relates: #9543
2021-12-20 09:45:25 +01:00
a8c475fbd7 Reflect TYPO3 behaviour in tests
TYPO3 scheduler tasks always have a value for console commands.
Region uid will be an empty string if omitted within scheduler task.
We reflect that in our tests and adapt code to not break.
Furthermore tests call only with strings, as that's what TYPO3 does.
2021-12-16 14:34:17 +01:00
6aa4681cb9 Delete files which were referenced by events objects
Adjust existing code base to not use hardcoded file path.
Instead use info from database and check all files which have references
to event objects.

Also add test to cover feature.
2021-12-16 14:07:32 +01:00
15dec49445 Remove usage of uploads folder, use transient API instead
Relates: #9533
2021-12-16 10:00:51 +01:00
de82e395e6 Fix Coding Guideline check on CI
The current setup actually fixed and didn't check or fail.
That's changed and code is fixed.
2021-12-16 09:13:15 +01:00
0e5cd38176 Add first basic functional test for import
The test ensures import runs with a small example set of events.

We needed to alter fetching of images, in order to properly mock
responses.
2021-12-16 09:08:16 +01:00
73161fa24e Make region optional during import 2021-12-14 17:31:56 +01:00
29c31375a5 Remove PHPStan issues
Most were fixed, some were ignored on top level.
2021-12-14 17:31:46 +01:00
a576709947 Use dependency injection within command
Do not fetch service with legacy API, instead use proper Dependency
Injection.

Relates: #9532
2021-12-14 16:09:42 +01:00
0d0c64f419 Fix PHPStan issues 2021-12-13 09:27:28 +01:00
b430993655 Remove execution rights from php file 2021-12-13 08:51:32 +01:00
ce3863619e Add query callback to date demand
This allows 3rd party to alter the query of dates when demand is used.
E.g. allow more complex filters specific for some situations like CEs.

Relates: #9505
2021-12-07 15:26:25 +01:00
30f030aab6 !!!|Show all coming + running dates by default
Only coming dates were shown by default.

Relates: #9505
2021-12-06 12:34:32 +01:00
bc6aa4d359 Apply stdWrap to date demand settings
Move to a dedicated factory for easier re use.
Add dependencies and apply stdWrap to properties.
That allows to dynamically set values like dates by using stdWrap
features.

E.g.:

    settings {
        end {
            strtotime = midnight +1 day
        }
    }

Relates: #9505
2021-12-06 12:34:32 +01:00
c38241f351 Fix broken upcoming feature
Using a FlexForm results in stored Unixtimestamps.
Adding 00:00 and using strtotime will result in false, resulting in
null.

We now just keep the provided value as integer.
That way underlying code works as expected and delivers events from
given start date.

Relates: #9352, #8581
2021-10-11 11:33:52 +02:00
f0ee19cfae Fix CGL ordering of import statements
Update of dev dependency results in better sorting of UpperCamelCase.
2021-10-11 11:33:11 +02:00
Dirk Koritnik
d5ad0a66a8 Fix probems with catgories
* make sure no empty category is listed in search filter
* fix type error in dd import
2021-09-08 11:03:30 +00:00
22e75d4729 Do not load all dates of each event
Most of the time dates are fetched and shown.
They need the event to show info like title.
But they nearly never need further dates, except in detail view.

Turning this property lazy will save a lot of data fetching and mapping
and provides a huge performance impact.
2021-09-08 10:13:01 +02:00
Dirk Koritnik
ce6d50a7d7 Remove regions from cleanup 2021-09-07 19:01:47 +02:00
da87dc7644 Improve determination of "end" in db constraints
Some dates might not have an end date, but only start.
Those should be respected.
2021-09-07 16:03:54 +02:00
26cc0d3f8c Fix wrong converted condition
The condition was changed when types where properly added.
The actual meaning was changed by accident and is now fixed again.
2021-09-07 15:58:00 +02:00
6226fb32d4 Do not break import if region could not be found 2021-09-07 12:19:49 +02:00
1f769939b4 Extend cleanup
Properly cleanup system.

Delete further records when deleting everything.
Also respect further records when purging old entries.

Respect:

* sys_category_record_mm
* sys_file_reference
* sys_file_metadata
2021-09-07 12:19:09 +02:00
f618536ff9 Add PHPStan
In order to static analyze code and prevent bugs when changing code.
Fix issues in most of the files.
2021-09-07 11:07:55 +02:00
ebb668221e Support canceled attribute during import of destination data
Destination data provides an attribute "DETAILS_ABGESAGT" to mark an
event as canceled.
We now fetch that info and mark all dates of that event as canceled.

This also contains refactoring of creation of dates within import.
All dates had the same info, and are now created at a single place.

Relates: #9280
2021-09-07 09:29:38 +02:00
cbe4eda380 Add CI
* Add first basic CI with defaults.
* Add ecs for coding guideline.
* Fix invalid xliff files.
2021-09-07 09:26:59 +02:00
8ded245785 Fix Category type miss match during import
Extbase Category repository was used, while custom Category instances
were expected.
The repository didn't inherit from Extbase Repository and therefore
didn't provide expected findByUid method.
2021-09-07 08:40:09 +02:00
410a73052e Fix type miss match of object storages
The properties should always be ObjectStorage instances.
We streamline the annotation and initialization to ensure exactly that.

Also import needs small adjustment as it still expected null as possible
return type.
2021-09-07 07:54:43 +02:00
018fdc697e Fix RemoveAllCommand return type
The command should always return an integer as exit code.
The called method does not return anything, resulting in null to be
returned.
2021-09-07 07:54:43 +02:00
d0cb951550 Do not break performance when no postponed date exists
Some sites do not use postponed_date at all.
It would be a massive performance issue to still search for them for
each and every date instance that is created.

This small addition will solve the issue for those pages.
It will still once at least one internal reference is added.

We could then try to add proxies which are build and added, but don't
use the DB. That way the performance would still be okay, and data will
only be fetched when used.
2021-09-07 07:54:43 +02:00
3822b86df6 Fix Category type miss match during import
Extbase Category repository was used, while custom Category instances
were expected.
2021-09-07 07:54:41 +02:00
8ddbc2fb88 Handle missing target folder on import 2021-09-07 07:54:02 +02:00
39d4f628e3 Prevent broken event state when build from db result
The process will not call __construct, the object storages might not be
initialized. Therefore initializeObject is now implemented which is
calling the existing method to initialize object storages.
2021-09-07 07:52:30 +02:00
326378e2fc Allow to reference events from event
This might be useful to allow editors and integrators to create
something like "you might also be interested in" or "related events".
2021-09-07 07:52:29 +02:00
97bcbe2065 Add original date to dates if available
This is not possible via native API.
We therefore use the event to fetch and add the relation.

Relates: #8857
2021-09-07 07:52:29 +02:00
36ecc9bbe8 Add cObject data to fluid when available
Relates: #9012
2021-09-07 07:52:29 +02:00
5440ef4f72 Fix not available cache for events_category
Adjust cache name to match TYPO3 v10 convention without "cache_" prefix.
Add default configuration to prevent issue if integrator does not
configure cache.
2021-09-07 07:52:28 +02:00
1929a4a566 Use sorting of categories
Extbase will properly use mm sorting.
But categories can't be sorted within the TCA tree component.
Therefore it makes more sense to use actual sys_category sorting.
In order to do so, we add our own model and pass the sorting.
That way PHP can do the sorting.

That's the easiest approach.
Also events shouldn't contain to many categories.  A performance impact
should not be high.

Relates: #8459
2021-09-07 07:52:28 +02:00
Dirk Koritnik
2450f5c6b7 Switch to Storage Object for images 2021-09-07 07:52:27 +02:00
cbbe56775e Allow to add link for canceled dates
E.g. allow users to get info about refunds.

Relates: #8574
2021-09-07 07:52:26 +02:00
10b4c34fe6 Allow to define a new date if current is postponed
Relates: #8092
2021-09-07 07:52:25 +02:00
c65ae5023f Allow integrator to set start or end for date via settings
Respect start and end when creating demand from settings.
That way integrator can configure it via TypoScript, or provide an
FlexForm.

Also the query was adjusted. It now respects a single value and doesn't
need start and end.
That way upcoming events can be created.

Relates: #8581
2021-09-07 07:52:25 +02:00
cf2b571fda Support manual sorting in foreign language
Given: Website uses copy / free mode of localization.
       and Editor selects specific events to display.
Then:  Those events should be displayed as selected.

Before this change the sorting was applied on uid of objects,
which is the uid of default lanugage record. But editors might select
localized uids. Therefore a fallback is added in case no object was
found.

Relates: #8557
2021-09-07 07:52:25 +02:00
Dirk Koritnik
4a8abbe344 Add getter and setter for caceled 2021-09-07 07:52:24 +02:00
4e2f191030 Fix broken demand support for categories
This was broken since changes during update.
2021-09-07 07:52:22 +02:00
Dirk Koritnik
ce9a1e17e5 Add subtitle filed to event 2021-09-07 07:52:21 +02:00
ca7340782b Allow an date to be marked as canceled
That has no effect, the info is just available from model.
This can be used to display a canceled date in a different way, or
render a notice.

Relates: #8092
2021-09-07 07:52:19 +02:00
f111884299 Refactor and streamline event code
Make controller smaller, remove unused code.
Move creation of demand object into its own factory.
Reduce npath complexity in repository and move parts into named methods.
2021-09-07 07:52:18 +02:00
17bd83eedf Provide new "Event selected" plugin
Allow editors to select specific events to display.
Therefore add new necessary demand and setting for events and respect
them within repository.

Relates: #8092
2021-09-07 07:52:18 +02:00
8da7284e1f Allow f:debug for event models
Private properties lead to an exception when using f:debug in Fluid.

Relates: #8092
2021-09-07 07:52:18 +02:00
43d8a1c0d6 Add partner
Add new record type partner.
This can be something like a media partner or something else.

Allow an event to have zero or more partner.
Add necessary files and models with relations.

Relates: #8092
2021-09-07 07:52:17 +02:00
38b4844a9d Add pages to events
Allow editor to reference TYPO3 page records from events.
E.g. used to provide further internal information links.

Also those pages are resolved via DataProcessing.
That allows integrators to be 100% flexible to resolve those page info.
By default a menu is generated and media is resolved.

Also validation is ignored, as this improves performance and allows to
use the new class as injected property without validation fails.
Models are not managed via frontend and therefore don't need validation.

Relates: #8092
2021-09-07 07:52:17 +02:00
acc0c2bdc5 Manually migrate cascade annotation
Relates: #8092
2021-09-07 07:52:17 +02:00
0c58be43ff Manual CGL adjustments
Not covered by PSR / phpcs

Relates: #8092
2021-09-07 07:52:15 +02:00
b7adb97cbc Adjust code and config to pass php code sniffer
Relates: #8092
2021-09-07 07:51:36 +02:00
59272afffd Add php code sniffer to follow PSR-12
Also apply ./vendor/bin/phpcbf to auto migrate what is possible.

Relates: #8092
2021-09-07 07:51:36 +02:00
b829a25738 Auto migrate code base to TYPO3 v10
Using:

    ./vendor/bin/typo3-rector process Classes Configuration ext_*

Relates: #8092
2021-09-07 07:50:09 +02:00
Dirk Koritnik
a5cef0ac8f Merge branch 'feature/category-filter' into 'master'
Add categories filter

See merge request typo3/events!7
2021-08-12 09:56:43 +00:00
52f1fe8dc1 Add categories filter
Relates: #9171
2021-07-14 11:07:44 +02:00
e82df315a7 Apply search word search to categories titles 2021-07-13 14:04:56 +02:00
a332bffc25 Add synonym feature for date search
Allow configuration of synonyms via TypoScript.
This is taken into account when searching dates via submitted demand.

The configuration looks like the following:

    plugin.tx_events {
        settings {
            synonyms {
                10 {
                    word = Stadtführung
                    synonyms = Tour, Stadtführungen, Führung
                }
            }
        }
    }

The 10, 11, … is necessary as umlauts won't work as keys.
So `synonyms.Stadtführung = Tour, Stadtführungen` will not work.

Relates: #9158
2021-07-13 13:13:15 +02:00
Dirk Koritnik
fa507c1351 Fix ticket import 2020-10-01 09:51:15 +02:00
Dirk Koritnik
5e272178a5 Modify ticket link import 2020-10-01 09:45:32 +02:00
Dirk Koritnik
61cd617130 Fix lang uid var name 2020-10-01 08:56:44 +02:00
Dirk Koritnik
9464ad6018 Add lanuage handling 2020-10-01 08:34:13 +02:00
Dirk
f2973a4a99 Merge branch 'dev' of ssh://gitlab.werkraum-media.de:21512/typo3/events into dev 2020-08-19 11:30:21 +02:00
Dirk
3e643176a3 Add social links 2020-08-19 11:30:13 +02:00
Dirk
fbf9d55985 Remove strtolower 2020-08-18 15:22:34 +02:00
Dirk
e490feae93 Fix filename handling 2020-08-18 14:27:44 +02:00
Dirk
552986b2aa Merge 2020-08-17 14:26:38 +02:00
Dirk
3f55a189eb Add location name 2020-08-17 14:21:03 +02:00
Dirk
c95a84d52d Import price info 2020-03-16 14:06:03 +01:00
Dirk
93545bd171 Change address import 2020-03-16 13:52:58 +01:00
Dirk
b5d89ce7c4 Make untilDate to requirement 2020-03-16 12:10:01 +01:00
Dirk
d299990765 Add rest mode to destination data import 2020-02-19 09:08:15 +01:00
Dirk
c150158a17 Fix date demand 2019-12-11 15:13:59 +01:00
Dirk
e388ece205 Fix date constraint for same days 2019-12-11 09:15:07 +01:00
Dirk
38a76b26f9 Add show plugin, prepare consider date 2019-11-13 10:46:21 +01:00
Dirk
2426267567 Refactoring 2019-11-11 12:43:50 +01:00
Dirk
890dcd4b35 Make default image configurable 2019-11-07 14:16:28 +01:00
Dirk
b632a32fe7 Remove cat parent uid from arguments 2019-11-07 10:25:09 +01:00
Dirk
bd4409fd76 [TASK] Fix DateTime Issue 2019-10-11 15:12:07 +02:00
Dirk
bc5801452b [FIX] Fix crazy die error 2019-10-09 15:03:58 +02:00
Dirk
9a10874963 [TASK] Switch to method POST 2019-09-27 07:42:45 +02:00
Dirk
525ebf0f8e [TASK] Remove lat lng from set address 2019-09-23 15:43:15 +02:00
Dirk
3d4f9d5088 [TASK] Seperate lat lng in function 2019-09-23 15:41:41 +02:00
208c0cfbfa Refactor code
Split large code base into separate classes.
Use Service as a controller, in order to define tasks to execute.
2019-09-19 12:11:21 +02:00
412b59d77f WIP Remove files
Remove files from sys_file db table and filesystem.
Add this to delete all, in order to delete all matching files.
But also add to past cleanup, to only remove files which do no longer
have relations. This last part was not tested, due to missing testing
environment.
2019-09-19 10:47:37 +02:00
8ed5bd9970 Add command to remove all past dates and events
It will search for all dates within the past and remove them. Afterwards
all events with no dates are searched and removed.

As DataHandler is used for deletion of events, there is already logging
within TYPO3, as well as recursive deletion for sys_file_references.

To speedup for large data sets, deletion of dates is done without
DataHandler.
2019-09-19 09:09:42 +02:00
ca4d7d3a01 Add basic cleanup command
Allows to remove all existing records regarding events.
It will search for all pages providing either organizer or events, and
will delete both types of records.

As DataHandler is used for deletion, there is already logging within
TYPO3, as well as recursive deletion for dates and sys_file_references.

To speedup for large data sets, truncate organizer and dates, as they
don't have recursive deletions, e.g. to sys_file_references. Also add
keys to database.
2019-09-18 18:04:29 +02:00
Dirk
f51017325f Added datepicker 2019-08-14 18:40:04 +02:00
Dirk
f1cbba74c1 Implement date search 2019-08-14 17:22:01 +02:00
Dirk
8821bb4639 Added conditions in iport to prevent errors 2019-08-13 11:52:34 +02:00
Dirk
e9745ebd85 Rename plugin settings 2019-08-13 11:41:41 +02:00
Dirk
662b088daa Refactoring Import Service 2019-08-13 11:17:34 +02:00
Dirk
f6a46012a7 Make Pid of categories configurable 2019-08-13 10:10:00 +02:00
Dirk
7ab18bce50 Removed old ImportCommand 2019-08-13 09:32:46 +02:00
Dirk
f2fcf646f8 Small changes to load file function 2019-08-13 09:12:30 +02:00