Work-Related/events
Work-Related/events
1
0
mirror of https://github.com/werkraum-media/events.git synced 2024-10-18 11:56:10 +02:00
Code Issues Activity

Maintenance (#59)

Browse source 
* Add missing dependency to composer package `typo3/cms-install`.

As UpgradeWizards use API of the package.

* Migrate deprecated PHPStan configuration options

* Adapt expected HTML output within functional tests

As TYPO3 changed actual generated HTML.
This commit is contained in:
Daniel Siepmann 2024-06-27 09:48:33 +02:00 committed by GitHub
parent f35af812c9
commit 15d233c834
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 65 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
Documentation/Changelog/4.0.1.rst Normal file
View file

@ -0,0 +1,33 @@
4.0.1
=====
Breaking
--------
Nothing
Features
--------
Nothing
Fixes
-----
* Add missing dependency to composer package `typo3/cms-install`.
As UpgradeWizards use API of the package.
* Migrate deprecated PHPStan configuration options.
* Adapt expected HTML output within functional tests.
As TYPO3 changed actual generated HTML.
Tasks
-----
Nothing
Deprecation
-----------
Nothing

18
Tests/Functional/Frontend/DatesTest.php
View file

@ -198,8 +198,8 @@ class DatesTest extends AbstractFunctionalTestCase
self::assertSame(200, $response->getStatusCode()); self::assertSame(200, $response->getStatusCode());
$html = (string)$response->getBody(); $html = (string)$response->getBody();
self::assertStringContainsString('<meta name="description" content="Teaser of Event" />', $html); self::assertStringContainsString('<meta name="description" content="Teaser of Event">', $html);
self::assertStringContainsString('<meta name="keywords" content="Gewölbe, Goethe, Horst Damm, Kästner, Theater" />', $html); self::assertStringContainsString('<meta name="keywords" content="Gewölbe, Goethe, Horst Damm, Kästner, Theater">', $html);
} }
#[Test] #[Test]
@ -211,9 +211,9 @@ class DatesTest extends AbstractFunctionalTestCase
self::assertSame(200, $response->getStatusCode()); self::assertSame(200, $response->getStatusCode());
$html = (string)$response->getBody(); $html = (string)$response->getBody();
self::assertStringContainsString('<meta property="og:title" content="Title of Event 15.02.2023 00:00" />', $html); self::assertStringContainsString('<meta property="og:title" content="Title of Event 15.02.2023 00:00">', $html);
self::assertStringContainsString('<meta property="og:type" content="website" />', $html); self::assertStringContainsString('<meta property="og:type" content="website">', $html);
self::assertStringContainsString('<meta property="og:image" content="http://example.com/fileadmin/user_uploads/example-for-event.gif" />', $html); self::assertStringContainsString('<meta property="og:image" content="http://example.com/fileadmin/user_uploads/example-for-event.gif">', $html);
} }
#[Test] #[Test]
@ -225,10 +225,10 @@ class DatesTest extends AbstractFunctionalTestCase
self::assertSame(200, $response->getStatusCode()); self::assertSame(200, $response->getStatusCode());
$html = (string)$response->getBody(); $html = (string)$response->getBody();
self::assertStringContainsString('<meta name="twitter:card" content="summary" />', $html); self::assertStringContainsString('<meta name="twitter:card" content="summary">', $html);
self::assertStringContainsString('<meta name="twitter:title" content="Title of Event 15.02.2023 00:00" />', $html); self::assertStringContainsString('<meta name="twitter:title" content="Title of Event 15.02.2023 00:00">', $html);
self::assertStringContainsString('<meta name="twitter:description" content="Teaser of Event" />', $html); self::assertStringContainsString('<meta name="twitter:description" content="Teaser of Event">', $html);
self::assertStringContainsString('<meta name="twitter:image" content="http://example.com/fileadmin/user_uploads/example-for-event.gif" />', $html); self::assertStringContainsString('<meta name="twitter:image" content="http://example.com/fileadmin/user_uploads/example-for-event.gif">', $html);
} }
#[Test] #[Test]

18
Tests/Functional/Frontend/EventsTest.php
View file

@ -54,8 +54,8 @@ class EventsTest extends AbstractFunctionalTestCase
self::assertSame(200, $response->getStatusCode()); self::assertSame(200, $response->getStatusCode());
$html = (string)$response->getBody(); $html = (string)$response->getBody();
self::assertStringContainsString('<meta name="description" content="Teaser of Event" />', $html); self::assertStringContainsString('<meta name="description" content="Teaser of Event">', $html);
self::assertStringContainsString('<meta name="keywords" content="Gewölbe, Goethe, Horst Damm, Kästner, Theater" />', $html); self::assertStringContainsString('<meta name="keywords" content="Gewölbe, Goethe, Horst Damm, Kästner, Theater">', $html);
} }
#[Test] #[Test]
@ -67,9 +67,9 @@ class EventsTest extends AbstractFunctionalTestCase
self::assertSame(200, $response->getStatusCode()); self::assertSame(200, $response->getStatusCode());
$html = (string)$response->getBody(); $html = (string)$response->getBody();
self::assertStringContainsString('<meta property="og:title" content="Title of Event" />', $html); self::assertStringContainsString('<meta property="og:title" content="Title of Event">', $html);
self::assertStringContainsString('<meta property="og:type" content="website" />', $html); self::assertStringContainsString('<meta property="og:type" content="website">', $html);
self::assertStringContainsString('<meta property="og:image" content="http://example.com/fileadmin/user_uploads/example-for-event.gif" />', $html); self::assertStringContainsString('<meta property="og:image" content="http://example.com/fileadmin/user_uploads/example-for-event.gif">', $html);
} }
#[Test] #[Test]
@ -81,10 +81,10 @@ class EventsTest extends AbstractFunctionalTestCase
self::assertSame(200, $response->getStatusCode()); self::assertSame(200, $response->getStatusCode());
$html = (string)$response->getBody(); $html = (string)$response->getBody();
self::assertStringContainsString('<meta name="twitter:card" content="summary" />', $html); self::assertStringContainsString('<meta name="twitter:card" content="summary">', $html);
self::assertStringContainsString('<meta name="twitter:title" content="Title of Event" />', $html); self::assertStringContainsString('<meta name="twitter:title" content="Title of Event">', $html);
self::assertStringContainsString('<meta name="twitter:description" content="Teaser of Event" />', $html); self::assertStringContainsString('<meta name="twitter:description" content="Teaser of Event">', $html);
self::assertStringContainsString('<meta name="twitter:image" content="http://example.com/fileadmin/user_uploads/example-for-event.gif" />', $html); self::assertStringContainsString('<meta name="twitter:image" content="http://example.com/fileadmin/user_uploads/example-for-event.gif">', $html);
} }
#[Test] #[Test]

3
composer.json
View file

@ -27,7 +27,8 @@
"typo3/cms-filelist": "^12.4", "typo3/cms-filelist": "^12.4",
"typo3/cms-filemetadata": "^12.4", "typo3/cms-filemetadata": "^12.4",
"typo3/cms-fluid": "^12.4", "typo3/cms-fluid": "^12.4",
"typo3/cms-frontend": "^12.4" "typo3/cms-frontend": "^12.4",
"typo3/cms-install": "^12.4"
}, },
"autoload": { "autoload": {
"psr-4": { "psr-4": {

2
ext_emconf.php
View file

@ -9,7 +9,7 @@ $EM_CONF['events'] = [
'author' => 'Dirk Koritnik, Daniel Siepmann', 'author' => 'Dirk Koritnik, Daniel Siepmann',
'author_email' => 'koritnik@werkraum-media.de, coding@daniel-siepmann.de', 'author_email' => 'koritnik@werkraum-media.de, coding@daniel-siepmann.de',
'state' => 'stable', 'state' => 'stable',
'version' => '4.0.0', 'version' => '4.0.1',
'constraints' => [ 'constraints' => [
'depends' => [ 'depends' => [
'typo3' => '', 'typo3' => '',

18
phpstan.neon
View file

@ -1,10 +1,14 @@
includes: includes:
- phpstan-baseline.neon - phpstan-baseline.neon
parameters: parameters:
level: max level: max
paths: paths:
- Classes - Classes
- Configuration - Configuration
checkMissingIterableValueType: false reportUnmatchedIgnoredErrors: true
checkGenericClassInNonGenericObjectType: false
reportUnmatchedIgnoredErrors: true ignoreErrors:
-
identifier: missingType.generics
-
identifier: missingType.iterableValue