Commit graph

61 commits

Author SHA1 Message Date
d38ce3dc41
BUGFIX: Fix identifier for removed extension
* Due to copy and paste the identifier was not indicating a removed
  extension.
* Identifier and tests were adjusted accordingly.

Relates: #44
2017-05-09 11:33:55 +02:00
9b028d24e6
TASK: Update IsACallSniff tests to reflect added removed extension
Relates: #44
2017-05-09 11:31:15 +02:00
3503a5b63a
TASK: Update PhpDocCommentSniff tests to reflect added removed extension
Relates: #44
2017-05-09 11:25:54 +02:00
af50ddfd99
TASK: Update StaticCallSniff tests to reflect added removed extension
* Also update getBefore method of AbstractClassnameChecker to make
  lookups before, like in StaticCallSniff work.

Relates: #44
2017-05-09 11:20:45 +02:00
b32fc01110
TASK: Add test for TypeHintCatchExceptionSniff
* Check that the sniff works with new feature of removed extension.

Relates: #44
2017-05-09 10:55:17 +02:00
3034f3fec4
FEATURE: Add removed extension to type hint sniff
* Integrate feature and adjust code as needed.
* We need to find the class names inside of type hints more accurate.
* Also tests need to cover the new feature.

Relates: #44
2017-05-09 10:34:58 +02:00
633a714043
FEATURE: Implement removed extension into use sniff.
* Detect removed extensions in use statements.

Relates: #44
2017-05-09 08:41:38 +02:00
c7ddbc4aef
TASK: Finish removed extension test
* Adjust expected result to match result.
* Remove example usage of "use" as this is part of a feature and not
  this sniff.

Relates: #44
2017-05-09 08:35:58 +02:00
5adbac1a25
TASK: Implement basic structure
* Adjust to latest develop state of project.
* Provide basic implementation.

Relates: #44
2017-05-04 16:43:09 +02:00
c7112c0fae
Merge remote-tracking branch 'origin/develop' into feature/44-add-checks-for-deprecated-removed-extensions 2017-05-04 16:04:51 +02:00
e789311862
TASK: Migrate added test
* As test was added to develop, also migrate it.
2017-05-04 08:30:14 +02:00
a16390d227
Merge branch 'develop' into feature/seperate-tests 2017-05-04 08:29:21 +02:00
Daniel Hürtgen
95da568935 Merge branch 'develop' into 'feature/74-check-removed-typoscript-constants'
# Conflicts:
#   Documentation/source/features.rst
2017-05-02 22:12:23 +02:00
ea0dc99e14
TASK: Use test class for each sniff.
* Allow executing tests for single sniff through phpunit '--filter'.
* Provide structure to add further tests for a single sniff.
* Make output more clear, which sniff was tested.
2017-05-02 15:08:21 +02:00
299c33a075
FEATURE: Add warning for removed TypoScript Constants
* Configure removed constants in TYPO3 7.x.
* Add code / sniff.
* Add test.
* Update docs.

Resolves: #74
2017-05-02 12:44:04 +02:00
0e3f487681
TASK: Add removed classes in 7.0
Relates: #41
2017-04-27 16:10:28 +02:00
b9bdd5dd3b
TASK: Migrate RemovedClassFeature
* Also migrate RemovedClassFeature to new structure with
  AbstractYamlRemovedUsage

Relates: #71
2017-04-27 14:05:05 +02:00
84dd380a3c
TASK: Migrate GenericFunctionCallSniff
* Migrate GenericFunctionCallSniff to new architecture.
* Provide new abstract class for php removed functions and constants.
* Fix TypoScriptSniff not always returning array.
* Adjust warnings in Expected.json

Relates: #71
2017-04-27 13:23:51 +02:00
f972533e04 WIP|FEATURE: Check for removed php classes.
* Add feature to existing code base and logic, see #72 .
* Add first removed classes for TYPO3 7.0 as example.
* Adjust first test to make sure basic implementation works.

Relates: #41
2017-04-27 11:23:29 +02:00
Daniel Hürtgen
01af1eaf4b Merge branch 'feature/54-add-checks-for-typoscript' into 'develop'
Feature/54 add checks for typoscript

Closes #54

See merge request !74
2017-04-27 10:45:13 +02:00
e4f26abe71
TASK: Add test case
* Also test that we don't modify working parts
2017-04-25 16:36:41 +02:00
7f7a7aa38d
TASK: Add missing docs 2017-04-25 16:35:54 +02:00
69bb97ad94
Merge branch 'feature/72-refactor-sniff-architecture' into feature/54-add-checks-for-typoscript 2017-04-25 15:50:04 +02:00
14c82e4a10 TASK: Migrate IsACallSniff
* Add further tests with quotes.
* Handle prefix in strings.
* Remove old originalTokenContent which is no longer in use, as we use
  str_replace, introduced in earlier commit.

Relates: #72
2017-04-25 14:36:19 +02:00
d12990f6e1
TASK: Streamline test output on error 2017-04-25 14:16:59 +02:00
efd5d9114f
TASK: Migrate MissingNamespaceSniff
* Make MissingNamespaceSniff work again.
* Move to old namespace as it's a custom sniff, not a general one.
* Do not use new feature here, implement logic internal.
* Remove message from ruleset, use it directly.

Relates: #72
2017-04-25 14:11:40 +02:00
8572740fd1
TASK: Shorten test output
* Remove unnecessary information to shorten output.
* This should make it easier to get the actual issue.
2017-04-25 13:41:36 +02:00
0c6bb133a1
TASK: Make some tests pass again
* All tests where only file name in diff was wrong are working again.

Relates: #72
2017-04-25 13:28:09 +02:00
c4c8faacd2
WIP: Fix TypeHintSniff
* Make TypeHintSniff tests pass again.
* Fix typo in class name preventing new feature mechanism from matching.

Relates: #72
2017-04-25 13:25:48 +02:00
94df1f2ad1
WIP: Fix use sniff
* Make use sniff tests pass again.

Relates: #72
2017-04-25 13:16:58 +02:00
2b1a1a0f19
WIP: Fix broken MissingVendorForPluginsAndModulesSniff tests
Relates: #72
2017-04-25 13:05:48 +02:00
2f6dc2304a
WIP: Refactor code to new architecture
* Migrate class names.
* Add new architecture of "Features".
* Configure old assignments for new features.
* Rename necessary parts.

Relates: #72
2017-04-25 12:58:19 +02:00
7c5d95d0e0
TASK: Update test
* Make sure test is running again with new additions of cObjects.
* Also fix description containing dot at the end.

Relates: #54
2017-04-13 15:30:42 +02:00
3e9d8c01c8
TASK: Rename TypoScript sniff
* As we not only check ObjectIdentifier's anymore, but also further
  parts, renamce sniff to be more generic.
* Also rename configuration and tests accordingly.

Relates: #54
2017-04-13 15:27:25 +02:00
ca4d687155
FEATURE: Also check TypoScript objects
* Not only check paths, but also objects like cObjects.
* Update test input for verification.
* Add further breaking changes for 7.1
2017-04-13 15:22:38 +02:00
e1b3f31c78
FEATURE: Add second TypoScript check
* Extend test to show what's possible and covered and what is not
  covered yet.

Relates: #54
2017-04-13 14:20:36 +02:00
154fe43582
FEATURE: Allow multiple files to be used as insert for tests
* Detect file for php and TS out of the box.
* Keep old handling to configure file name.
* Also detect file format, e.g. TypoScript, and configure phpcs
  tokenizer accordingly.

Relates: #54
2017-04-13 13:39:08 +02:00
7a999212e2
FEATURE: Add first TypoScript sniff
* Add configuration for removed object identifiers.
* Add sniff for removed object identifiers.

Relates: #54
2017-04-13 13:32:20 +02:00
6a3d18ecfc
TASK: Add further test cases to GenericConstantUsageSniff
* To show what's also working and what will potentially provide non
  helpful warnings.

Relates: #64
2017-04-13 12:02:44 +02:00
9a905c492a
TASK: Add missing test for GenericFunctionCallSniff
Resolves: #64
2017-04-13 11:56:52 +02:00
34e616355f
TASK: Add missing test for GenericConstantUsageSniff
Relates: #64
2017-04-13 11:49:53 +02:00
Daniel Hürtgen
4461e116db FEATURE: Test for removed extension key sniff added 2017-04-11 13:01:37 +02:00
Daniel Hürtgen
be4b76c192 BUGFIX: Adjust TYPO3 docs urls 2017-04-11 12:53:02 +02:00
e48cbe712e
BUGFIX: Allow phpunit tests to run even if phpcs.xml.dist is provided
* By adding Coding Standard to calls, phpcs will not lookup the standard
  to use in our phpcs.xml.dist, which is used to check the project
  itself.
* Instead it will use the provided standard.
2017-04-10 13:32:44 +02:00
a16ae7b8d4
TASK: Update to latest TypoScript tokenizer
* As official project does no longer modify the file to tokenize.
* Add tests to test integration.
2017-04-09 20:14:16 +02:00
6528c391b2
FEATURE: Make each sniff run as a new test
* Allows running all further sniffs, even if a single sniff fails.
* Shows all issues at once in output.
* Use native SplFileInfo instead of Symfony, as we have no need for the
  dependency.

Relates: #46
2017-04-09 13:40:10 +02:00
0b21535f87
BUGFIX: Allow multiple runtime-set per test
Relates: #46
2017-04-06 16:11:29 +02:00
e957e5fe18
TASK: Refactor, follow CS and add more info on error
Relates: #46
2017-04-06 16:00:44 +02:00
65512dcd1d
FEATURE: Add tests for MissingNamespaceSniff
Relates: #46
2017-04-06 15:53:03 +02:00
958086da24
FEATURE: Add tests for MissingVendorForPluginsAndModulesSniff
* With custom vendor and default vendor.

Relates: #46
2017-04-06 15:48:37 +02:00