Commit graph

159 commits

Author SHA1 Message Date
e5d7f5ac01
Merge branch 'develop' into feature/66-ts-structure 2017-05-04 08:21:11 +02:00
Daniel Hürtgen
95da568935 Merge branch 'develop' into 'feature/74-check-removed-typoscript-constants'
# Conflicts:
#   Documentation/source/features.rst
2017-05-02 22:12:23 +02:00
Daniel Hürtgen
475e38e3fc Merge branch 'develop' into 'feature/41-check-removed-classes'
# Conflicts:
#   Documentation/source/features.rst
2017-05-02 22:06:02 +02:00
299c33a075
FEATURE: Add warning for removed TypoScript Constants
* Configure removed constants in TYPO3 7.x.
* Add code / sniff.
* Add test.
* Update docs.

Resolves: #74
2017-05-02 12:44:04 +02:00
3126004854
TASK: Remove unnecessary method call 2017-05-02 10:54:22 +02:00
31d66c17d0
TASK: Fix cgl
* Fix phpcs and phpmd issues.
2017-05-02 10:52:53 +02:00
dffcac2bd5
FEATURE: Add FQObjectIdentifier to TypoScript tokens
* To make later checks easier, add the fully qualified object
  identifier, to all object identifier tokens while tokenizing
  TypoScript.
* Adjust tests accordingly.
* Add necessary autoloading.

Closes: #66
2017-05-02 10:48:43 +02:00
9e3f7ac1e5
TASK: Fix MR issues
* Remove construct from interface.
* Fix wrong type hints.
* Keep naming of variable in sync.
* Also keep conditions format in sync.

Relates: #71
2017-05-02 08:09:10 +02:00
4fdc15d715
TASK: Add removed classes for TYPO3 7.5
Relates: #41
2017-04-27 16:41:22 +02:00
cfdf58f7d4
TASK: Add removed classes for TYPO3 7.5
Relates: #41
2017-04-27 16:33:55 +02:00
3663af3755
TASK: Add removed classes for TYPO3 7.3
Relates: #41
2017-04-27 16:33:36 +02:00
98b9331652
TASK: Add removed classes for TYPO3 7.3
Relates: #41
2017-04-27 16:20:14 +02:00
0e3f487681
TASK: Add removed classes in 7.0
Relates: #41
2017-04-27 16:10:28 +02:00
11db09a303
TASK: Update phpdocs
* Remove unnecessary docs.
* Add necessary docs.
2017-04-27 15:40:02 +02:00
003609342e
TASK: Refactor DRY
* Don't duplicate code and logic.
* Move common code to parent class.

Relates: #71
2017-04-27 14:37:24 +02:00
510774a3cc
TASK: Support at least PHP 5.6
* Adjust CI , composer and docs.
* Migrate modern code to 5.6 supported code.

Relates: #71
2017-04-27 14:16:22 +02:00
b9bdd5dd3b
TASK: Migrate RemovedClassFeature
* Also migrate RemovedClassFeature to new structure with
  AbstractYamlRemovedUsage

Relates: #71
2017-04-27 14:05:05 +02:00
bcbd1f96bc
TASK: Migrate GenericConstantUsageSniff
* Migrate GenericConstantUsageSniff to new architecture.
* Move non common functionality from AbstractGenericPhpUsage to concrete
  classes.

Relates: #71
2017-04-27 13:33:28 +02:00
84dd380a3c
TASK: Migrate GenericFunctionCallSniff
* Migrate GenericFunctionCallSniff to new architecture.
* Provide new abstract class for php removed functions and constants.
* Fix TypoScriptSniff not always returning array.
* Adjust warnings in Expected.json

Relates: #71
2017-04-27 13:23:51 +02:00
2659066e21
WIP|TASK: Migrate Typo3Update_Sniffs_Removed_TypoScriptSniff
* Refactor yaml based removed check architecture.
* Migrate TypoScriptSniff to new architecture.

Relates: #71
2017-04-27 12:51:16 +02:00
fad2a4e498
FEATURE: Allow empty feature yaml files
* Handle empty yaml files for features in options class.
2017-04-27 11:48:59 +02:00
f972533e04 WIP|FEATURE: Check for removed php classes.
* Add feature to existing code base and logic, see #72 .
* Add first removed classes for TYPO3 7.0 as example.
* Adjust first test to make sure basic implementation works.

Relates: #41
2017-04-27 11:23:29 +02:00
Daniel Hürtgen
01af1eaf4b Merge branch 'feature/54-add-checks-for-typoscript' into 'develop'
Feature/54 add checks for typoscript

Closes #54

See merge request !74
2017-04-27 10:45:13 +02:00
Daniel Hürtgen
7398caa099 TASK: Simplfy “features" iterator 2017-04-27 10:23:02 +02:00
Daniel Hürtgen
cecfe983e0 TASK: Simplfy feature support trait 2017-04-27 10:17:05 +02:00
370015e7c0
TASK: Refactor code
* Reduce indentation.
* Provide internal API to add new feature with necessary checks.
2017-04-25 16:36:12 +02:00
7f7a7aa38d
TASK: Add missing docs 2017-04-25 16:35:54 +02:00
69bb97ad94
Merge branch 'feature/72-refactor-sniff-architecture' into feature/54-add-checks-for-typoscript 2017-04-25 15:50:04 +02:00
2cc21fdafa
TASK: Cleanup code
* Remove unnecessary documentation.
* Remove unused code.
* Add missing documentation.

Relates: #72
2017-04-25 15:20:35 +02:00
21cf62b949
TASK: migrate InheritanceSniff
Relates: #72
2017-04-25 15:09:32 +02:00
14c82e4a10 TASK: Migrate IsACallSniff
* Add further tests with quotes.
* Handle prefix in strings.
* Remove old originalTokenContent which is no longer in use, as we use
  str_replace, introduced in earlier commit.

Relates: #72
2017-04-25 14:36:19 +02:00
efd5d9114f
TASK: Migrate MissingNamespaceSniff
* Make MissingNamespaceSniff work again.
* Move to old namespace as it's a custom sniff, not a general one.
* Do not use new feature here, implement logic internal.
* Remove message from ruleset, use it directly.

Relates: #72
2017-04-25 14:11:40 +02:00
d3b612790c
TASK: Make inline replacements work again
* As sometimes not the whole token should be replaces, but only the
  classname within the token, we replace them always this way.
* Before the refactoring, that was done in the concrete sniffs.
* Affected are e.g. php doc comments.

Relates: #72
2017-04-25 13:45:46 +02:00
c91dc8065f
TASK: Make TypeHintCatchExceptionSniff work again
* Fix wrong class name, to allow features to match.

Relates: #72
2017-04-25 13:33:56 +02:00
c4c8faacd2
WIP: Fix TypeHintSniff
* Make TypeHintSniff tests pass again.
* Fix typo in class name preventing new feature mechanism from matching.

Relates: #72
2017-04-25 13:25:48 +02:00
94df1f2ad1
WIP: Fix use sniff
* Make use sniff tests pass again.

Relates: #72
2017-04-25 13:16:58 +02:00
cc0be4a5b4
WIP: Move features to own namespace
* Have all feature related classes in a single namespace.

Relates: #72
2017-04-25 13:03:36 +02:00
2f6dc2304a
WIP: Refactor code to new architecture
* Migrate class names.
* Add new architecture of "Features".
* Configure old assignments for new features.
* Rename necessary parts.

Relates: #72
2017-04-25 12:58:19 +02:00
b502e52920
TASK: Add missing license
* Add license to file.
2017-04-25 08:20:08 +02:00
42e04617bc
BUGFIX: CGL issue
* Follow CGL and fix issue.
2017-04-13 16:14:56 +02:00
498e00c6f0
TASK: Add missing phpdoc 2017-04-13 16:05:34 +02:00
6e602cf5f5
TASK: Add all remaining TypoScripts
Resolves: #54
2017-04-13 16:02:40 +02:00
5387e553c5
TASK: Add remaining TypoScript changes for 7.1
Relates: #54
2017-04-13 15:51:01 +02:00
7c5d95d0e0
TASK: Update test
* Make sure test is running again with new additions of cObjects.
* Also fix description containing dot at the end.

Relates: #54
2017-04-13 15:30:42 +02:00
3e9d8c01c8
TASK: Rename TypoScript sniff
* As we not only check ObjectIdentifier's anymore, but also further
  parts, renamce sniff to be more generic.
* Also rename configuration and tests accordingly.

Relates: #54
2017-04-13 15:27:25 +02:00
ca4d687155
FEATURE: Also check TypoScript objects
* Not only check paths, but also objects like cObjects.
* Update test input for verification.
* Add further breaking changes for 7.1
2017-04-13 15:22:38 +02:00
12fcc704dc
TASK: Fix php syntax issue
* It's not even a warning, but still wrong
2017-04-13 15:21:59 +02:00
2e7f155b8d
TASK: Configure all 7.0 breaking changed for ObjectIdentifier
Relates: #54
2017-04-13 14:57:33 +02:00
e1b3f31c78
FEATURE: Add second TypoScript check
* Extend test to show what's possible and covered and what is not
  covered yet.

Relates: #54
2017-04-13 14:20:36 +02:00
920c923ed7
FEATURE: Add missing method to make tests pass.
* Retrieve yaml files for removed typoscript object identifier.

Relates: #54
2017-04-13 13:40:04 +02:00