Commit graph

45 commits

Author SHA1 Message Date
7a16dac529
FEATURE: Allow auto migration of classes in strings
* We now check class names case sensitive in strings.
* This will prevent issues with stuff like TCA, as class names mathing
  table names are written in lower case.
* Also add further tests and fix issues.
* Extend test to check that lower version is not replaced but mentioned
  as warning.
* Expected class names in Tx_ format are reported as fixable error.

Resolves: #15
2017-05-04 13:35:02 +02:00
aa5cc51043
Merge branch 'feature/seperate-tests' into feature/15-check-all-possible-occurences-of-class 2017-05-04 08:41:23 +02:00
a16390d227
Merge branch 'develop' into feature/seperate-tests 2017-05-04 08:29:21 +02:00
34bf941a21 Merge branch 'develop' into feature/15-check-all-possible-occurences-of-class 2017-05-04 08:21:37 +02:00
Daniel Hürtgen
95da568935 Merge branch 'develop' into 'feature/74-check-removed-typoscript-constants'
# Conflicts:
#   Documentation/source/features.rst
2017-05-02 22:12:23 +02:00
ea0dc99e14
TASK: Use test class for each sniff.
* Allow executing tests for single sniff through phpunit '--filter'.
* Provide structure to add further tests for a single sniff.
* Make output more clear, which sniff was tested.
2017-05-02 15:08:21 +02:00
299c33a075
FEATURE: Add warning for removed TypoScript Constants
* Configure removed constants in TYPO3 7.x.
* Add code / sniff.
* Add test.
* Update docs.

Resolves: #74
2017-05-02 12:44:04 +02:00
afd6f78196
FEATURE: Detect classes in strings
* Detect class names in strings.
* Attach feature to new detection.
* Only add warnings for classes in strings, they might be table names.

Closes: #15
2017-05-02 11:52:42 +02:00
0e3f487681
TASK: Add removed classes in 7.0
Relates: #41
2017-04-27 16:10:28 +02:00
b9bdd5dd3b
TASK: Migrate RemovedClassFeature
* Also migrate RemovedClassFeature to new structure with
  AbstractYamlRemovedUsage

Relates: #71
2017-04-27 14:05:05 +02:00
84dd380a3c
TASK: Migrate GenericFunctionCallSniff
* Migrate GenericFunctionCallSniff to new architecture.
* Provide new abstract class for php removed functions and constants.
* Fix TypoScriptSniff not always returning array.
* Adjust warnings in Expected.json

Relates: #71
2017-04-27 13:23:51 +02:00
f972533e04 WIP|FEATURE: Check for removed php classes.
* Add feature to existing code base and logic, see #72 .
* Add first removed classes for TYPO3 7.0 as example.
* Adjust first test to make sure basic implementation works.

Relates: #41
2017-04-27 11:23:29 +02:00
Daniel Hürtgen
01af1eaf4b Merge branch 'feature/54-add-checks-for-typoscript' into 'develop'
Feature/54 add checks for typoscript

Closes #54

See merge request !74
2017-04-27 10:45:13 +02:00
e4f26abe71
TASK: Add test case
* Also test that we don't modify working parts
2017-04-25 16:36:41 +02:00
7f7a7aa38d
TASK: Add missing docs 2017-04-25 16:35:54 +02:00
69bb97ad94
Merge branch 'feature/72-refactor-sniff-architecture' into feature/54-add-checks-for-typoscript 2017-04-25 15:50:04 +02:00
14c82e4a10 TASK: Migrate IsACallSniff
* Add further tests with quotes.
* Handle prefix in strings.
* Remove old originalTokenContent which is no longer in use, as we use
  str_replace, introduced in earlier commit.

Relates: #72
2017-04-25 14:36:19 +02:00
efd5d9114f
TASK: Migrate MissingNamespaceSniff
* Make MissingNamespaceSniff work again.
* Move to old namespace as it's a custom sniff, not a general one.
* Do not use new feature here, implement logic internal.
* Remove message from ruleset, use it directly.

Relates: #72
2017-04-25 14:11:40 +02:00
0c6bb133a1
TASK: Make some tests pass again
* All tests where only file name in diff was wrong are working again.

Relates: #72
2017-04-25 13:28:09 +02:00
c4c8faacd2
WIP: Fix TypeHintSniff
* Make TypeHintSniff tests pass again.
* Fix typo in class name preventing new feature mechanism from matching.

Relates: #72
2017-04-25 13:25:48 +02:00
94df1f2ad1
WIP: Fix use sniff
* Make use sniff tests pass again.

Relates: #72
2017-04-25 13:16:58 +02:00
2b1a1a0f19
WIP: Fix broken MissingVendorForPluginsAndModulesSniff tests
Relates: #72
2017-04-25 13:05:48 +02:00
2f6dc2304a
WIP: Refactor code to new architecture
* Migrate class names.
* Add new architecture of "Features".
* Configure old assignments for new features.
* Rename necessary parts.

Relates: #72
2017-04-25 12:58:19 +02:00
7c5d95d0e0
TASK: Update test
* Make sure test is running again with new additions of cObjects.
* Also fix description containing dot at the end.

Relates: #54
2017-04-13 15:30:42 +02:00
3e9d8c01c8
TASK: Rename TypoScript sniff
* As we not only check ObjectIdentifier's anymore, but also further
  parts, renamce sniff to be more generic.
* Also rename configuration and tests accordingly.

Relates: #54
2017-04-13 15:27:25 +02:00
ca4d687155
FEATURE: Also check TypoScript objects
* Not only check paths, but also objects like cObjects.
* Update test input for verification.
* Add further breaking changes for 7.1
2017-04-13 15:22:38 +02:00
e1b3f31c78
FEATURE: Add second TypoScript check
* Extend test to show what's possible and covered and what is not
  covered yet.

Relates: #54
2017-04-13 14:20:36 +02:00
7a999212e2
FEATURE: Add first TypoScript sniff
* Add configuration for removed object identifiers.
* Add sniff for removed object identifiers.

Relates: #54
2017-04-13 13:32:20 +02:00
6a3d18ecfc
TASK: Add further test cases to GenericConstantUsageSniff
* To show what's also working and what will potentially provide non
  helpful warnings.

Relates: #64
2017-04-13 12:02:44 +02:00
9a905c492a
TASK: Add missing test for GenericFunctionCallSniff
Resolves: #64
2017-04-13 11:56:52 +02:00
34e616355f
TASK: Add missing test for GenericConstantUsageSniff
Relates: #64
2017-04-13 11:49:53 +02:00
Daniel Hürtgen
be4b76c192 BUGFIX: Adjust TYPO3 docs urls 2017-04-11 12:53:02 +02:00
0b21535f87
BUGFIX: Allow multiple runtime-set per test
Relates: #46
2017-04-06 16:11:29 +02:00
65512dcd1d
FEATURE: Add tests for MissingNamespaceSniff
Relates: #46
2017-04-06 15:53:03 +02:00
958086da24
FEATURE: Add tests for MissingVendorForPluginsAndModulesSniff
* With custom vendor and default vendor.

Relates: #46
2017-04-06 15:48:37 +02:00
0703167315
FEATURE: Allow to overwrite cli arguments for test
* Enable overwriting using Arguments.php.
* Add multiple sub tests for AjaxRegistrationSniff.

Relates: #46
2017-04-06 15:37:55 +02:00
63d48e01fa
FEATURE: Add all remaining tests
Relates: #46
2017-04-06 14:23:32 +02:00
bfda1cfec4
FEATURE: Add further test
Relates: #46
2017-04-06 12:42:17 +02:00
03f321c865
FEATURE: Add tests and fix issues
* Add test for IsACallSniff.
* Fix doublicate finds in IsACallSniff and
  InstantiationWithObjectManagerSniff.
* Both didn't stop looking for class at end of expression.

Relates: #46
2017-04-06 12:35:44 +02:00
af74a5db21
FEATURE: Add further tests
Relates: #46
2017-04-06 12:11:31 +02:00
d7911cccee
BUGFIX: Keep line ending for inline comments
* As test showed, line ending was removed for inline comments "//".
* This line ending is now kept.
* Test does not fail anymore.

Relates: #46, #3
2017-04-06 11:57:00 +02:00
a78d94ab13
WIP|FEATURE: Add further tests
* Add new tests and improve existing

Relates: #46
2017-04-06 11:44:15 +02:00
b23ee6ef8b
TASK: Improve tests
* Allow phpcbf / diff to be optional, as not all tests are fixable.
* Provide more information in case of error.
* Provide phpunit dist to run phpunit without anything special.

Relates: #46
2017-04-06 11:14:32 +02:00
7c35998c62
FEATURE: Also enable testing phpcbf
* Add diff to test actual fixes.

Relates: #46
2017-04-06 10:55:17 +02:00
1b309bd709
WIP|FEATURE: First working test
* Parses fixtures to auto run tests for sniffs.
* Compares actual result for fixture input against expected result from
  fixture.

Relates: #46
2017-04-06 10:39:24 +02:00