Commit graph

75 commits

Author SHA1 Message Date
61c4a7b9eb
TASK: Migrate configuration fixture
* As old globals are not used anymore, we use the API to use our fixture
  file to be returned for tests.

Relates: #82
2017-06-01 08:20:19 +02:00
f8afc920a4
TASK: Migrate code base and tests
* Use namespace in configuration, as classes are now namespaced.
* Also use namespace in code for referenced to own sniffs.
* Do not use identifiers with further dots as this is no longer
  supported, use ":" instead.

Relates: #82
2017-05-30 15:42:21 +02:00
Daniel Hürtgen
0c91d7b22c Merge branch 'feature/15-check-all-possible-occurences-of-class' into 'develop'
FEATURE: Detect classes in strings

Closes #15 and #43

See merge request !84
2017-05-16 15:32:55 +02:00
Daniel Hürtgen
ec7a4634c9 Merge branch 'hotfix/allow-phpdoc-to-substitute-all-classnames' into 'develop'
BUGFIX: Allow PhpDocCommentSniff to work find all classnames in comment

See merge request !92
2017-05-16 14:44:56 +02:00
Daniel Hürtgen
8d93512b20 Merge branch 'feature/improve-namespaces' into 'develop'
FEATURE: Improve namespace migration

See merge request !91
2017-05-16 14:42:46 +02:00
Daniel Hürtgen
5aac278ba9 Merge branch 'feature/66-ts-structure' into 'develop'
FEATURE: Add FQObjectIdentifier to TypoScript tokens

Closes #66

See merge request !83
2017-05-16 14:39:57 +02:00
2d3165e8f4
BUGFIX: Also allow to fix validator classnames 2017-05-16 10:36:27 +02:00
f2910b02b2
BUGFIX: Allow PhpDocCommentSniff to work find all classnames in comment
* Before only the first classname was returned.
* All class names are returned now.
* This allows to fix Extbase type annotations for relations.
2017-05-11 11:17:46 +02:00
53d727fa4b
FEATURE: Make sure namespaces are only applied for Tx_ class definitions
* E.g. prevent migration for ux_ classes which do not follow the
  convention.
* Add test to make sure it works as expected.
2017-05-11 08:59:37 +02:00
7a16dac529
FEATURE: Allow auto migration of classes in strings
* We now check class names case sensitive in strings.
* This will prevent issues with stuff like TCA, as class names mathing
  table names are written in lower case.
* Also add further tests and fix issues.
* Extend test to check that lower version is not replaced but mentioned
  as warning.
* Expected class names in Tx_ format are reported as fixable error.

Resolves: #15
2017-05-04 13:35:02 +02:00
b69c262288
TASK: Improve tests and fix issues
* Configure code coverage for new tested class.
* Fix usage of class with new insensitivity lookup.
* Add further tests.
2017-05-04 12:46:39 +02:00
666bbdb26a
TASK: Add tests for mapping class
* Add minimum phpdoc.
* Add tests.
* Fix issue in class.
* Fix phpmd issues.
2017-05-04 11:58:49 +02:00
8db7a8bb1f
TASK: Split legacy mapping into two files
* One files is provided by us for TYPO3 mappings.
* Second one keeps as is and contains the generated mappings.

Relates: #43
2017-05-04 10:44:49 +02:00
cacd15029d
Merge branch 'feature/seperate-tests' into feature/66-ts-structure 2017-05-04 08:45:58 +02:00
470910b07a
Merge branch 'feature/seperate-tests' into feature/45-removed-signals 2017-05-04 08:45:10 +02:00
aa5cc51043
Merge branch 'feature/seperate-tests' into feature/15-check-all-possible-occurences-of-class 2017-05-04 08:41:23 +02:00
e789311862
TASK: Migrate added test
* As test was added to develop, also migrate it.
2017-05-04 08:30:14 +02:00
a16390d227
Merge branch 'develop' into feature/seperate-tests 2017-05-04 08:29:21 +02:00
34bf941a21 Merge branch 'develop' into feature/15-check-all-possible-occurences-of-class 2017-05-04 08:21:37 +02:00
e5d7f5ac01
Merge branch 'develop' into feature/66-ts-structure 2017-05-04 08:21:11 +02:00
Daniel Hürtgen
dcc0c13dd8 Merge branch 'develop' into 'feature/45-removed-signals'
# Conflicts:
#   Documentation/source/features.rst
2017-05-02 22:15:52 +02:00
Daniel Hürtgen
95da568935 Merge branch 'develop' into 'feature/74-check-removed-typoscript-constants'
# Conflicts:
#   Documentation/source/features.rst
2017-05-02 22:12:23 +02:00
4d7aeea5ae
FEATURE: Implement removed hook sniff.
* Update docs, add sniff and test.
* Add first configuration.

Relates: #45
2017-05-02 15:43:29 +02:00
2a6bf4f45b Merge branch 'feature/seperate-tests' into feature/45-removed-signals 2017-05-02 15:19:31 +02:00
ea0dc99e14
TASK: Use test class for each sniff.
* Allow executing tests for single sniff through phpunit '--filter'.
* Provide structure to add further tests for a single sniff.
* Make output more clear, which sniff was tested.
2017-05-02 15:08:21 +02:00
83239ddeee
FEATURE: Add check for removed signals
* Add docs, sniff, tests.
* Add first configuration.

Relates: #45
2017-05-02 14:24:59 +02:00
299c33a075
FEATURE: Add warning for removed TypoScript Constants
* Configure removed constants in TYPO3 7.x.
* Add code / sniff.
* Add test.
* Update docs.

Resolves: #74
2017-05-02 12:44:04 +02:00
afd6f78196
FEATURE: Detect classes in strings
* Detect class names in strings.
* Attach feature to new detection.
* Only add warnings for classes in strings, they might be table names.

Closes: #15
2017-05-02 11:52:42 +02:00
31d66c17d0
TASK: Fix cgl
* Fix phpcs and phpmd issues.
2017-05-02 10:52:53 +02:00
dffcac2bd5
FEATURE: Add FQObjectIdentifier to TypoScript tokens
* To make later checks easier, add the fully qualified object
  identifier, to all object identifier tokens while tokenizing
  TypoScript.
* Adjust tests accordingly.
* Add necessary autoloading.

Closes: #66
2017-05-02 10:48:43 +02:00
0e3f487681
TASK: Add removed classes in 7.0
Relates: #41
2017-04-27 16:10:28 +02:00
b9bdd5dd3b
TASK: Migrate RemovedClassFeature
* Also migrate RemovedClassFeature to new structure with
  AbstractYamlRemovedUsage

Relates: #71
2017-04-27 14:05:05 +02:00
84dd380a3c
TASK: Migrate GenericFunctionCallSniff
* Migrate GenericFunctionCallSniff to new architecture.
* Provide new abstract class for php removed functions and constants.
* Fix TypoScriptSniff not always returning array.
* Adjust warnings in Expected.json

Relates: #71
2017-04-27 13:23:51 +02:00
f972533e04 WIP|FEATURE: Check for removed php classes.
* Add feature to existing code base and logic, see #72 .
* Add first removed classes for TYPO3 7.0 as example.
* Adjust first test to make sure basic implementation works.

Relates: #41
2017-04-27 11:23:29 +02:00
Daniel Hürtgen
01af1eaf4b Merge branch 'feature/54-add-checks-for-typoscript' into 'develop'
Feature/54 add checks for typoscript

Closes #54

See merge request !74
2017-04-27 10:45:13 +02:00
e4f26abe71
TASK: Add test case
* Also test that we don't modify working parts
2017-04-25 16:36:41 +02:00
7f7a7aa38d
TASK: Add missing docs 2017-04-25 16:35:54 +02:00
69bb97ad94
Merge branch 'feature/72-refactor-sniff-architecture' into feature/54-add-checks-for-typoscript 2017-04-25 15:50:04 +02:00
14c82e4a10 TASK: Migrate IsACallSniff
* Add further tests with quotes.
* Handle prefix in strings.
* Remove old originalTokenContent which is no longer in use, as we use
  str_replace, introduced in earlier commit.

Relates: #72
2017-04-25 14:36:19 +02:00
d12990f6e1
TASK: Streamline test output on error 2017-04-25 14:16:59 +02:00
efd5d9114f
TASK: Migrate MissingNamespaceSniff
* Make MissingNamespaceSniff work again.
* Move to old namespace as it's a custom sniff, not a general one.
* Do not use new feature here, implement logic internal.
* Remove message from ruleset, use it directly.

Relates: #72
2017-04-25 14:11:40 +02:00
8572740fd1
TASK: Shorten test output
* Remove unnecessary information to shorten output.
* This should make it easier to get the actual issue.
2017-04-25 13:41:36 +02:00
0c6bb133a1
TASK: Make some tests pass again
* All tests where only file name in diff was wrong are working again.

Relates: #72
2017-04-25 13:28:09 +02:00
c4c8faacd2
WIP: Fix TypeHintSniff
* Make TypeHintSniff tests pass again.
* Fix typo in class name preventing new feature mechanism from matching.

Relates: #72
2017-04-25 13:25:48 +02:00
94df1f2ad1
WIP: Fix use sniff
* Make use sniff tests pass again.

Relates: #72
2017-04-25 13:16:58 +02:00
2b1a1a0f19
WIP: Fix broken MissingVendorForPluginsAndModulesSniff tests
Relates: #72
2017-04-25 13:05:48 +02:00
2f6dc2304a
WIP: Refactor code to new architecture
* Migrate class names.
* Add new architecture of "Features".
* Configure old assignments for new features.
* Rename necessary parts.

Relates: #72
2017-04-25 12:58:19 +02:00
7c5d95d0e0
TASK: Update test
* Make sure test is running again with new additions of cObjects.
* Also fix description containing dot at the end.

Relates: #54
2017-04-13 15:30:42 +02:00
3e9d8c01c8
TASK: Rename TypoScript sniff
* As we not only check ObjectIdentifier's anymore, but also further
  parts, renamce sniff to be more generic.
* Also rename configuration and tests accordingly.

Relates: #54
2017-04-13 15:27:25 +02:00
ca4d687155
FEATURE: Also check TypoScript objects
* Not only check paths, but also objects like cObjects.
* Update test input for verification.
* Add further breaking changes for 7.1
2017-04-13 15:22:38 +02:00