Work-Related/automated-typo3-update
Work-Related/automated-typo3-update
1
0
Code Issues Activity

BUGFIX: Fix identifier for removed extension

Browse source 
* Due to copy and paste the identifier was not indicating a removed
  extension.
* Identifier and tests were adjusted accordingly.

Relates: #44
This commit is contained in:
Daniel Siepmann 2017-05-09 11:33:55 +02:00
parent 9b028d24e6
commit d38ce3dc41
Signed by: Daniel Siepmann
GPG key ID: 33D6629915560EF4
7 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Standards/Typo3Update/Feature/RemovedExtensionFeature.php
View file

@ -55,7 +55,7 @@ class RemovedExtensionFeature extends AbstractYamlRemovedUsage
foreach ($typo3Versions as $typo3Version => $removals) { foreach ($typo3Versions as $typo3Version => $removals) {
foreach ($removals as $removed => $config) { foreach ($removals as $removed => $config) {
$config['name'] = $removed; $config['name'] = $removed;
$config['identifier'] = 'RemovedClass.' . str_replace('\\', '_', ltrim($removed, '\\')); $config['identifier'] = 'RemovedExtension.' . str_replace('\\', '_', ltrim($removed, '\\'));
$config['versionRemoved'] = $typo3Version; $config['versionRemoved'] = $typo3Version;
$config['oldUsage'] = $removed; $config['oldUsage'] = $removed;

2
tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/IsACallSniff/Expected.json
View file

@ -45,7 +45,7 @@
"line": 38, "line": 38,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.IsACall.RemovedClass.perm", "source": "Typo3Update.Classname.IsACall.RemovedExtension.perm",
"type": "WARNING" "type": "WARNING"
} }
], ],

2
tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/PhpDocCommentSniff/Expected.json
View file

@ -36,7 +36,7 @@
"line": 33, "line": 33,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.PhpDocComment.RemovedClass.perm", "source": "Typo3Update.Classname.PhpDocComment.RemovedExtension.perm",
"type": "WARNING" "type": "WARNING"
}, },
{ {

4
tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/StaticCallSniff/Expected.json
View file

@ -63,7 +63,7 @@
"line": 33, "line": 33,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.StaticCall.RemovedClass.perm", "source": "Typo3Update.Classname.StaticCall.RemovedExtension.perm",
"type": "WARNING" "type": "WARNING"
}, },
{ {
@ -72,7 +72,7 @@
"line": 38, "line": 38,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.StaticCall.RemovedClass.perm", "source": "Typo3Update.Classname.StaticCall.RemovedExtension.perm",
"type": "WARNING" "type": "WARNING"
} }
], ],

2
tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/TypeHintCatchExceptionSniff/Expected.json
View file

@ -27,7 +27,7 @@
"line": 48, "line": 48,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.TypeHintCatchException.RemovedClass.perm", "source": "Typo3Update.Classname.TypeHintCatchException.RemovedExtension.perm",
"type": "WARNING" "type": "WARNING"
} }
], ],

6
tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/TypeHintSniff/Expected.json
View file

@ -63,7 +63,7 @@
"line": 63, "line": 63,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.TypeHint.RemovedClass.perm", "source": "Typo3Update.Classname.TypeHint.RemovedExtension.perm",
"type": "WARNING" "type": "WARNING"
}, },
{ {
@ -72,7 +72,7 @@
"line": 63, "line": 63,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.TypeHint.RemovedClass.perm", "source": "Typo3Update.Classname.TypeHint.RemovedExtension.perm",
"type": "WARNING" "type": "WARNING"
}, },
{ {
@ -81,7 +81,7 @@
"line": 66, "line": 66,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.TypeHint.RemovedClass.perm", "source": "Typo3Update.Classname.TypeHint.RemovedExtension.perm",
"type": "WARNING" "type": "WARNING"
} }
], ],

6
tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/UseSniff/Expected.json
View file

@ -27,7 +27,7 @@
"line": 26, "line": 26,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.Use.RemovedClass.perm", "source": "Typo3Update.Classname.Use.RemovedExtension.perm",
"type": "WARNING" "type": "WARNING"
}, },
{ {
@ -36,7 +36,7 @@
"line": 27, "line": 27,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.Use.RemovedClass.perm", "source": "Typo3Update.Classname.Use.RemovedExtension.perm",
"type": "WARNING" "type": "WARNING"
}, },
{ {
@ -45,7 +45,7 @@
"line": 28, "line": 28,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html", "message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.Use.RemovedClass.perm", "source": "Typo3Update.Classname.Use.RemovedExtension.perm",
"type": "WARNING" "type": "WARNING"
} }
], ],