Work-Related/automated-typo3-update
Work-Related/automated-typo3-update
1
0
Code Issues Activity

TASK: Rename method

Browse source 
* To follow CGL

Relates: #33
This commit is contained in:
Daniel Siepmann 2017-03-21 13:30:04 +01:00
parent 21c72c8b96
commit 9a13223d62
Signed by: Daniel Siepmann
GPG key ID: 33D6629915560EF4
2 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/Standards/Typo3Update/Sniffs/LegacyClassnames/AbstractClassnameChecker.php
View file

@ -21,7 +21,7 @@ namespace Typo3Update\Sniffs\LegacyClassnames;
*/ */
use PHP_CodeSniffer as PhpCs; use PHP_CodeSniffer as PhpCs;
use PHP_CodeSniffer_File as PhpcsFile; use PHP_CodeSniffer_File as PhpCsFile;
use PHP_CodeSniffer_Sniff as PhpCsSniff; use PHP_CodeSniffer_Sniff as PhpCsSniff;
/** /**
@ -78,7 +78,7 @@ abstract class AbstractClassnameChecker implements PhpCsSniff
* *
* @return bool * @return bool
*/ */
protected function findPrev() protected function shouldLookBefore()
{ {
return false; return false;
} }
@ -90,13 +90,13 @@ abstract class AbstractClassnameChecker implements PhpCsSniff
* the class name. This way only the register method has to be registered * the class name. This way only the register method has to be registered
* in default cases. * in default cases.
* *
* @param PHP_CodeSniffer_File $phpcsFile The file where the token was found. * @param PhpCsFile $phpcsFile The file where the token was found.
* @param int $stackPtr The position in the stack where * @param int $stackPtr The position in the stack where
* the token was found. * the token was found.
* *
* @return void * @return void
*/ */
public function process(PhpcsFile $phpcsFile, $stackPtr) public function process(PhpCsFile $phpcsFile, $stackPtr)
{ {
$tokens = $phpcsFile->getTokens(); $tokens = $phpcsFile->getTokens();
@ -163,11 +163,11 @@ abstract class AbstractClassnameChecker implements PhpCsSniff
/** /**
* Add an fixable error if given $classname is legacy. * Add an fixable error if given $classname is legacy.
* *
* @param PhpcsFile $phpcsFile * @param PhpCsFile $phpcsFile
* @param int $classnamePosition * @param int $classnamePosition
* @param string $classname * @param string $classname
*/ */
public function addFixableError(PhpcsFile $phpcsFile, $classnamePosition, $classname) public function addFixableError(PhpCsFile $phpcsFile, $classnamePosition, $classname)
{ {
$classname = trim($classname, '\\\'"'); // Remove trailing slash, and quotes. $classname = trim($classname, '\\\'"'); // Remove trailing slash, and quotes.
$this->addMaybeWarning($phpcsFile, $classnamePosition, $classname); $this->addMaybeWarning($phpcsFile, $classnamePosition, $classname);
@ -191,11 +191,11 @@ abstract class AbstractClassnameChecker implements PhpCsSniff
/** /**
* Add an warning if given $classname is maybe legacy. * Add an warning if given $classname is maybe legacy.
* *
* @param PhpcsFile $phpcsFile * @param PhpCsFile $phpcsFile
* @param int $classnamePosition * @param int $classnamePosition
* @param string $classname * @param string $classname
*/ */
private function addMaybeWarning(PhpcsFile $phpcsFile, $classnamePosition, $classname) private function addMaybeWarning(PhpCsFile $phpcsFile, $classnamePosition, $classname)
{ {
if ($this->isLegacyClassname($classname) || $this->isMaybeLegacyClassname($classname) === false) { if ($this->isLegacyClassname($classname) || $this->isMaybeLegacyClassname($classname) === false) {
return; return;
@ -212,11 +212,11 @@ abstract class AbstractClassnameChecker implements PhpCsSniff
/** /**
* Replaces the classname at $classnamePosition with $classname in $phpcsFile. * Replaces the classname at $classnamePosition with $classname in $phpcsFile.
* *
* @param PhpcsFile $phpcsFile * @param PhpCsFile $phpcsFile
* @param int $classnamePosition * @param int $classnamePosition
* @param string $classname * @param string $classname
*/ */
protected function replaceLegacyClassname(PhpcsFile $phpcsFile, $classnamePosition, $classname, $forceEmptyPrefix = false) protected function replaceLegacyClassname(PhpCsFile $phpcsFile, $classnamePosition, $classname, $forceEmptyPrefix = false)
{ {
$prefix = '\\'; $prefix = '\\';
if ($forceEmptyPrefix || $phpcsFile->getTokens()[$classnamePosition -1]['code'] === T_NS_SEPARATOR) { if ($forceEmptyPrefix || $phpcsFile->getTokens()[$classnamePosition -1]['code'] === T_NS_SEPARATOR) {

2
src/Standards/Typo3Update/Sniffs/LegacyClassnames/StaticCallSniff.php
View file

@ -32,7 +32,7 @@ class Typo3Update_Sniffs_LegacyClassnames_StaticCallSniff implements PHP_CodeSni
* *
* @return bool * @return bool
*/ */
protected function findPrev() protected function shouldLookBefore()
{ {
return true; return true;
} }