Work-Related/automated-typo3-update
Work-Related/automated-typo3-update
1
0
Code Issues Activity

TASK: Update InstantiationWithMakeInstanceSniff tests

Browse source 
Relates: #44
This commit is contained in:
Daniel Siepmann 2017-05-09 12:07:12 +02:00
parent e3dd6013ba
commit 8dd569a6a6
Signed by: Daniel Siepmann
GPG key ID: 33D6629915560EF4
2 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstantiationWithMakeInstanceSniff/Expected.json
View file

@ -11,14 +11,23 @@
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.InstantiationWithMakeInstance.legacyClassname", "source": "Typo3Update.Classname.InstantiationWithMakeInstance.legacyClassname",
"type": "ERROR" "type": "ERROR"
},
{
"column": 25,
"fixable": false,
"line": 27,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5,
"source": "Typo3Update.Classname.InstantiationWithMakeInstance.RemovedExtension.perm",
"type": "WARNING"
} }
], ],
"warnings": 0 "warnings": 1
} }
}, },
"totals": { "totals": {
"errors": 1, "errors": 1,
"fixable": 1, "fixable": 1,
"warnings": 0 "warnings": 1
} }
} }

2
tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/InstantiationWithMakeInstanceSniff/InputFileForIssues.php
View file

@ -23,3 +23,5 @@ t3lib_div::makeInstance('Tx_Extbase_Command_HelpCommandController');
t3lib_div::makeInstance(\TYPO3\CMS\Core\Resource\Service\IndexerService::class); t3lib_div::makeInstance(\TYPO3\CMS\Core\Resource\Service\IndexerService::class);
// Not handled by this sniff, but StaticCallSniff, as this uses double colon. // Not handled by this sniff, but StaticCallSniff, as this uses double colon.
t3lib_div::makeInstance(Tx_Extbase_Command_HelpCommandController::class); t3lib_div::makeInstance(Tx_Extbase_Command_HelpCommandController::class);
t3lib_div::makeInstance('TYPO3\CMS\Perm\Controller\PermissionAjaxController');