TASK: Configure phpmd

* Make phpmd pass.
* Comment supressions with a reason.

phpmd.xml

@@ -10,10 +10,18 @@
         My custom rule set that checks my code...
     </description>
 
-    <rule ref="rulesets/cleancode.xml" />
+    <rule ref="rulesets/cleancode.xml">
-    <rule ref="rulesets/codesize.xml" />
+        <exclude name="StaticAccess" />
-    <rule ref="rulesets/controversial.xml" />
+    </rule>
-    <rule ref="rulesets/design.xml" />
+    <rule ref="rulesets/codesize.xml">
-    <rule ref="rulesets/naming.xml" />
+    </rule>
-    <rule ref="rulesets/unusedcode.xml" />
+    <rule ref="rulesets/controversial.xml">
+        <exclude name="CamelCaseClassName" />
+    </rule>
+    <rule ref="rulesets/design.xml">
+    </rule>
+    <rule ref="rulesets/naming.xml">
+    </rule>
+    <rule ref="rulesets/unusedcode.xml">
+    </rule>
 </ruleset>

src/CodeSniffer/Tokenizers/TypoScript.php

@@ -65,6 +65,8 @@ class PHP_CodeSniffer_Tokenizers_TYPOSCRIPT
      * @param string $eolChar The EOL character to use for splitting strings.
      *
      * @return void
+     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter) We need to match the signature.
      */
     public function processAdditional(&$tokens, $eolChar)
     {

src/Standards/Typo3Update/Sniffs/LegacyClassnames/AbstractClassnameChecker.php

@@ -82,6 +82,8 @@ abstract class AbstractClassnameChecker implements PhpCsSniff
      *                                        the token was found.
      *
      * @return void
+     *
+     * @SuppressWarnings(PHPMD.ElseExpression) This is for performance reason.
      */
     public function process(PhpCsFile $phpcsFile, $stackPtr)
     {
@@ -217,6 +219,8 @@ abstract class AbstractClassnameChecker implements PhpCsSniff
      * @param int $classnamePosition
      * @param string $classname
      * @param bool $forceEmptyPrefix Defines whether '\\' prefix should be checked or always be left out.
+     *
+     * @SuppressWarnings(PHPMD.BooleanArgumentFlag)
      */
     protected function replaceLegacyClassname(
         PhpCsFile $phpcsFile,
@@ -243,6 +247,8 @@ abstract class AbstractClassnameChecker implements PhpCsSniff
      * @param string $originalClassname
      * @param PhpCsFile $phpcsFile
      * @return string
+     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter) We need to match the signature.
      */
     protected function getTokenForReplacement($newClassname, $originalClassname, PhpCsFile $phpcsFile)
     {

src/Standards/Typo3Update/Sniffs/LegacyClassnames/Mapping.php

@@ -48,6 +48,9 @@ final class Mapping
     private function __clone()
     {
     }
+    /**
+     * @SuppressWarnings(PHPMD.UnusedPrivateMethod) We just want to implement singleton pattern.
+     */
     private function __wakeup()
     {
     }

src/Standards/Typo3Update/Sniffs/LegacyClassnames/MissingNamespaceSniff.php

@@ -95,6 +95,8 @@ class Typo3Update_Sniffs_LegacyClassnames_MissingNamespaceSniff extends Abstract
      * @param int $classnamePosition
      * @param string $classname
      * @param bool $forceEmptyPrefix Defines whether '\\' prefix should be checked or always be left out.
+     *
+     * @SuppressWarnings(PHPMD.BooleanArgumentFlag)
      */
     protected function replaceLegacyClassname(
         PhpCsFile $phpcsFile,

src/Standards/Typo3Update/Sniffs/LegacyClassnames/UseSniff.php

@@ -46,6 +46,8 @@ class Typo3Update_Sniffs_LegacyClassnames_UseSniff extends AbstractClassnameChec
      * @param int $classnamePosition
      * @param string $classname
      * @param bool $forceEmptyPrefix Defines whether '\\' prefix should be checked or always be left out.
+     *
+     * @SuppressWarnings(PHPMD.BooleanArgumentFlag)
      */
     protected function replaceLegacyClassname(
         PhpCsFile $phpcsFile,

src/Standards/Typo3Update/Sniffs/Removed/AbstractGenericUsage.php

@@ -29,8 +29,9 @@ use Typo3Update\Sniffs\Options;
 /**
  * Contains common functionality for removed code like constants or functions.
  *
- * Removed parts are configured using YAML-Files, for examples see src/Standards/Typo3Update/Configuration/Removed/Constants/7.0.yaml
+ * Removed parts are configured using YAML-Files, for examples see
- * Also check out the configuration options in Readme.rst.
+ * src/Standards/Typo3Update/Configuration/Removed/Constants/7.0.yaml Also
+ * check out the configuration options in Readme.rst.
  */
 abstract class AbstractGenericUsage implements PhpCsSniff
 {