Work-Related/automated-typo3-update
Work-Related/automated-typo3-update
1
0
Code Issues Activity

BUGFIX: Make tests work in gitlab ci env

Browse source
This commit is contained in:
Daniel Siepmann 2017-04-08 23:04:16 +02:00
parent 92c973c7f4
commit 3e33096a47
Signed by: Daniel Siepmann
GPG key ID: 33D6629915560EF4
1 changed files with 13 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
tests/SniffsTest.php
View file

@ -23,7 +23,6 @@ namespace Typo3Update\Tests;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Symfony\Component\Finder\Finder; use Symfony\Component\Finder\Finder;
use Symfony\Component\Finder\SplFileInfo;
/** /**
* Will test all sniffs where fixtures are available. * Will test all sniffs where fixtures are available.
@ -64,29 +63,29 @@ class SniffsTest extends TestCase
/** /**
* Execute sniff using subfolders. * Execute sniff using subfolders.
* *
* @param SplFileInfo $folder * @param \SplFileInfo $folder
* @param array $arguments * @param array $arguments
* @return void * @return void
*/ */
protected function executeSniffSubfolders(SplFileInfo $folder, array $arguments = []) protected function executeSniffSubfolders(\SplFileInfo $folder, array $arguments = [])
{ {
$finder = new Finder(); $finder = new Finder();
$finder->in($folder->getRealPath()); $finder->in($folder->getRealPath());
foreach ($arguments as $subFolder => $values) { foreach ($arguments as $subFolder => $values) {
$folderName = $folder->getRealPath() . DIRECTORY_SEPARATOR . $subFolder; $folderName = $folder->getRealPath() . DIRECTORY_SEPARATOR . $subFolder;
$this->executeSniff(new SplFileInfo($folderName, $folderName, $folderName), $values); $this->executeSniff(new \SplFileInfo($folderName), $values);
} }
} }
/** /**
* Execute phpunit assertion for sniff based on $folder. * Execute phpunit assertion for sniff based on $folder.
* *
* @param SplFileInfo $folder * @param \SplFileInfo $folder
* @param array $arguments * @param array $arguments
* @return void * @return void
*/ */
protected function executeSniff(SplFileInfo $folder, array $arguments = []) protected function executeSniff(\SplFileInfo $folder, array $arguments = [])
{ {
$internalArguments = array_merge_recursive([ $internalArguments = array_merge_recursive([
'runtime-set' => [ 'runtime-set' => [
@ -133,10 +132,10 @@ class SniffsTest extends TestCase
/** /**
* Get expected json output for comparison. * Get expected json output for comparison.
* *
* @param SplFileInfo $folder * @param \SplFileInfo $folder
* @return array * @return array
*/ */
protected function getExpectedJsonOutput(SplFileInfo $folder) protected function getExpectedJsonOutput(\SplFileInfo $folder)
{ {
$file = $folder->getPathname() . DIRECTORY_SEPARATOR . 'Expected.json'; $file = $folder->getPathname() . DIRECTORY_SEPARATOR . 'Expected.json';
if (!is_file($file)) { if (!is_file($file)) {
@ -149,12 +148,12 @@ class SniffsTest extends TestCase
/** /**
* Returns absolute file path to diff file containing expected output. * Returns absolute file path to diff file containing expected output.
* *
* @param SplFileInfo $folder * @param \SplFileInfo $folder
* @return string * @return string
* *
* @throws FileNotFoundException * @throws FileNotFoundException
*/ */
protected function getExpectedDiffOutput(SplFileInfo $folder) protected function getExpectedDiffOutput(\SplFileInfo $folder)
{ {
$file = $folder->getRealPath() . DIRECTORY_SEPARATOR . 'Expected.diff'; $file = $folder->getRealPath() . DIRECTORY_SEPARATOR . 'Expected.diff';
if (!is_file($file)) { if (!is_file($file)) {
@ -167,10 +166,10 @@ class SniffsTest extends TestCase
/** /**
* Returns PHPCS Sniff name for given folder. * Returns PHPCS Sniff name for given folder.
* *
* @param SplFileInfo $folder * @param \SplFileInfo $folder
* @return string * @return string
*/ */
protected function getSniffByFolder(SplFileInfo $folder) protected function getSniffByFolder(\SplFileInfo $folder)
{ {
$folderParts = array_filter(explode(DIRECTORY_SEPARATOR, $folder->getPathName())); $folderParts = array_filter(explode(DIRECTORY_SEPARATOR, $folder->getPathName()));
$sniffNamePosition; $sniffNamePosition;
@ -194,10 +193,10 @@ class SniffsTest extends TestCase
/** /**
* Get absolute file path to file containing further arguments. * Get absolute file path to file containing further arguments.
* *
* @param SplFileInfo $folder * @param \SplFileInfo $folder
* @return string * @return string
*/ */
protected function getArgumentsFile(SplFileInfo $folder) protected function getArgumentsFile(\SplFileInfo $folder)
{ {
return $folder->getRealPath() . DIRECTORY_SEPARATOR . 'Arguments.php'; return $folder->getRealPath() . DIRECTORY_SEPARATOR . 'Arguments.php';
} }