Work-Related/automated-typo3-update
Work-Related/automated-typo3-update
1
0
Code Issues Activity

TASK: Update PhpDocCommentSniff tests to reflect added removed extension

Browse source 
Relates: #44
This commit is contained in:
Daniel Siepmann 2017-05-09 11:25:54 +02:00
parent af50ddfd99
commit 3503a5b63a
Signed by: Daniel Siepmann
GPG key ID: 33D6629915560EF4
3 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/PhpDocCommentSniff/Expected.diff
View file

@ -1,6 +1,6 @@
--- tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/PhpDocCommentSniff/InputFileForIssues.php --- tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/PhpDocCommentSniff/InputFileForIssues.php
+++ PHP_CodeSniffer +++ PHP_CodeSniffer
@@ -22,20 +22,20 @@ @@ -22,21 +22,21 @@
class InputFileForIssues class InputFileForIssues
{ {
/** /**
@ -14,6 +14,7 @@
- * @param t3lib_div - * @param t3lib_div
+ * @param \TYPO3\CMS\Core\Utility\GeneralUtility + * @param \TYPO3\CMS\Core\Utility\GeneralUtility
* @param \TYPO3\CMS\Backend\Template\MediumDocumentTemplate * @param \TYPO3\CMS\Backend\Template\MediumDocumentTemplate
* @param \TYPO3\CMS\Perm\Controller\PermissionAjaxController
* *
- * @return Tx_Extbase_Configuration_Configurationmanager - * @return Tx_Extbase_Configuration_Configurationmanager
+ * @return \TYPO3\CMS\Extbase\Configuration\ConfigurationManager + * @return \TYPO3\CMS\Extbase\Configuration\ConfigurationManager

17
tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/PhpDocCommentSniff/Expected.json
View file

@ -30,10 +30,19 @@
"source": "Typo3Update.Classname.PhpDocComment.RemovedClass.TYPO3_CMS_Backend_Template_MediumDocumentTemplate", "source": "Typo3Update.Classname.PhpDocComment.RemovedClass.TYPO3_CMS_Backend_Template_MediumDocumentTemplate",
"type": "WARNING" "type": "WARNING"
}, },
{
"column": 15,
"fixable": false,
"line": 33,
"message": "Calls to removed code are not allowed; found perm. Removed in 7.0. The logic is moved into EXT:beuser. See: https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-62339-MoveExtPermIntoExtBeuser.html",
"severity": 5,
"source": "Typo3Update.Classname.PhpDocComment.RemovedClass.perm",
"type": "WARNING"
},
{ {
"column": 16, "column": 16,
"fixable": true, "fixable": true,
"line": 34, "line": 35,
"message": "Legacy classes are not allowed; found \"Tx_Extbase_Configuration_Configurationmanager\", use \"TYPO3\\CMS\\Extbase\\Configuration\\ConfigurationManager\" instead", "message": "Legacy classes are not allowed; found \"Tx_Extbase_Configuration_Configurationmanager\", use \"TYPO3\\CMS\\Extbase\\Configuration\\ConfigurationManager\" instead",
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.PhpDocComment.legacyClassname", "source": "Typo3Update.Classname.PhpDocComment.legacyClassname",
@ -42,19 +51,19 @@
{ {
"column": 18, "column": 18,
"fixable": true, "fixable": true,
"line": 38, "line": 39,
"message": "Legacy classes are not allowed; found \"t3lib_div\", use \"TYPO3\\CMS\\Core\\Utility\\GeneralUtility\" instead", "message": "Legacy classes are not allowed; found \"t3lib_div\", use \"TYPO3\\CMS\\Core\\Utility\\GeneralUtility\" instead",
"severity": 5, "severity": 5,
"source": "Typo3Update.Classname.PhpDocComment.legacyClassname", "source": "Typo3Update.Classname.PhpDocComment.legacyClassname",
"type": "ERROR" "type": "ERROR"
} }
], ],
"warnings": 1 "warnings": 2
} }
}, },
"totals": { "totals": {
"errors": 4, "errors": 4,
"fixable": 4, "fixable": 4,
"warnings": 1 "warnings": 2
} }
} }

1
tests/Fixtures/Standards/Typo3Update/Sniffs/Classname/PhpDocCommentSniff/InputFileForIssues.php
View file

@ -30,6 +30,7 @@ class InputFileForIssues
/** /**
* @param t3lib_div * @param t3lib_div
* @param \TYPO3\CMS\Backend\Template\MediumDocumentTemplate * @param \TYPO3\CMS\Backend\Template\MediumDocumentTemplate
* @param \TYPO3\CMS\Perm\Controller\PermissionAjaxController
* *
* @return Tx_Extbase_Configuration_Configurationmanager * @return Tx_Extbase_Configuration_Configurationmanager
*/ */