Fix wrong adoption of static HTML

* Do use proper counting of skills for skill set
* Do not use example brand logo, but logo provided by API
  (once implemented in toolkit)
* Open verification in new tab
* Do not use pending state.
This commit is contained in:
Daniel Siepmann 2020-10-19 15:43:09 +02:00
parent 060d432f15
commit 8137b7678b
Signed by: Daniel Siepmann
GPG key ID: 33D6629915560EF4
4 changed files with 10 additions and 6 deletions

View file

@ -7,20 +7,22 @@
<span class="sd-title">{title}</span>
<div class="sd-info">
<f:if condition="{count}">
<span>{skillSet.skills -> f:count()}</span>
<a href="{detailUrl}" target="_blank">View on SkillDisplay</a>
<div class="sd-brand">
<img src="{f:uri.resource(extensionName: 'skilldisplay', path: 'Images/htl3r.jpg')}" />
<f:if condition="{brandLogoUrl}">
<div class="sd-brand">
<img src="{brandLogoUrl}" />
<p class="sd-description">{description -> f:format.html()}</p>
<div class="sd-buttons">
<a href="{verificationUrl}" class="sd-button sd-learner sd-verified">
<a href="{verificationUrl}" target="_blank" class="sd-button sd-learner">
<div class="sd-hint">
<f:image src="{f:uri.resource(extensionName: 'skilldisplay', path: 'Images/pending.svg')}" title="Pending" alt="Indicates self assessment is pending" />
<f:image src="{f:uri.resource(extensionName: 'skilldisplay', path: 'Images/default.svg')}" title="Not learned yet" alt="Indicates self assessment is not done yet" />
<div class="sd-type">Self Assessment</div>

View file

@ -6,6 +6,7 @@
count: '{skillSet.skills -> f:count()}',
detailUrl: '{}',
brandLogoUrl: skillSet.mediaPublicUrl,
verificationUrl: '{sd:verification.url(skillSet:}',
description: skillSet.description

View file

@ -5,6 +5,7 @@
{f:render(partial: 'VerificationBox', arguments: {
title: skill.title,
detailUrl: '{}/0',
brandLogoUrl: skill.mediaPublicUrl,
verificationUrl: '{sd:verification.url(skill:}',
description: skill.description

Binary file not shown.


Width:  |  Height:  |  Size: 60 KiB