From d15bd079d6e3eda4808da57e7b884dc60ce4cfc7 Mon Sep 17 00:00:00 2001 From: Oliver Klee Date: Sun, 19 Nov 2023 22:34:02 +0100 Subject: [PATCH] [TASK] Migrate DB queries to CSV assertions in the functional tests (#998) This makes the corresponding test a lot more concise and easier to read. --- .../Repository/Fixtures/Product/PersistedTea.csv | 3 +++ .../Domain/Repository/Product/TeaRepositoryTest.php | 11 +---------- 2 files changed, 4 insertions(+), 10 deletions(-) create mode 100644 Tests/Functional/Domain/Repository/Fixtures/Product/PersistedTea.csv diff --git a/Tests/Functional/Domain/Repository/Fixtures/Product/PersistedTea.csv b/Tests/Functional/Domain/Repository/Fixtures/Product/PersistedTea.csv new file mode 100644 index 0000000..6384ffe --- /dev/null +++ b/Tests/Functional/Domain/Repository/Fixtures/Product/PersistedTea.csv @@ -0,0 +1,3 @@ +"tx_tea_domain_model_product_tea" +,"uid","title" +,1,"Godesberger Burgtee" diff --git a/Tests/Functional/Domain/Repository/Product/TeaRepositoryTest.php b/Tests/Functional/Domain/Repository/Product/TeaRepositoryTest.php index 1fe5ee9..176539e 100644 --- a/Tests/Functional/Domain/Repository/Product/TeaRepositoryTest.php +++ b/Tests/Functional/Domain/Repository/Product/TeaRepositoryTest.php @@ -119,16 +119,7 @@ final class TeaRepositoryTest extends FunctionalTestCase $this->subject->add($model); $this->persistenceManager->persistAll(); - $connection = $this->getConnectionPool()->getConnectionForTable('tx_tea_domain_model_product_tea'); - $databaseRow = $connection - ->executeQuery( - 'SELECT * FROM tx_tea_domain_model_product_tea WHERE uid = :uid', - ['uid' => $model->getUid()] - ) - ->fetchAssociative(); - - self::assertIsArray($databaseRow); - self::assertSame($title, $databaseRow['title']); + $this->assertCSVDataSet(__DIR__ . '/../Fixtures/Product/PersistedTea.csv'); } /**