From b8cf63d358e91c465e5b8bc274aad39051955f9f Mon Sep 17 00:00:00 2001 From: Oliver Klee Date: Fri, 22 May 2020 11:38:45 +0200 Subject: [PATCH] [BUGFIX] Use the PHP version from the matrix in the CI (#48) For GitHub actions, an explicit step is required to use a specific PHP version. If this is not done, a default version will be used (which makes the builds unpredictable). --- .github/workflows/ci.yml | 30 ++++++++++++++++++++++++++++++ CHANGELOG.md | 1 + 2 files changed, 31 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0d92dcc..dcfd345 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,6 +21,11 @@ jobs: - name: Checkout uses: actions/checkout@v1 + - name: Install PHP + uses: shivammathur/setup-php@v2 + with: + php-version: ${{ matrix.php-version }} + - name: Run PHP lint run: composer ci:php:lint @@ -29,10 +34,20 @@ jobs: runs-on: ubuntu-latest + strategy: + matrix: + php-version: + - 7.3 + steps: - name: Checkout uses: actions/checkout@v1 + - name: Install PHP + uses: shivammathur/setup-php@v2 + with: + php-version: ${{ matrix.php-version }} + - name: "Cache dependencies installed with composer" uses: actions/cache@v1 with: @@ -52,10 +67,20 @@ jobs: runs-on: ubuntu-latest + strategy: + matrix: + php-version: + - 7.3 + steps: - name: Checkout uses: actions/checkout@v1 + - name: Install PHP + uses: shivammathur/setup-php@v2 + with: + php-version: ${{ matrix.php-version }} + - name: "Cache dependencies installed with composer" uses: actions/cache@v1 with: @@ -92,6 +117,11 @@ jobs: - name: Checkout uses: actions/checkout@v1 + - name: Install PHP + uses: shivammathur/setup-php@v2 + with: + php-version: ${{ matrix.php-version }} + - name: "Cache dependencies installed with composer" uses: actions/cache@v1 with: diff --git a/CHANGELOG.md b/CHANGELOG.md index e1c9446..d064f62 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,6 +48,7 @@ This project adheres to [Semantic Versioning](https://semver.org/). - Drop the dependency of `roave/security-advisories` ### Fixed +- Use the PHP version from the matrix in the CI (#48) - Re-add the static TypoScript registration (#41) - Keep the global namespace clean in `ext_localconf.php` (#40) - Update the badge URLs in the `README` (#29, #22)