From 849087af9566c172064c1cb46eca6a476644972a Mon Sep 17 00:00:00 2001 From: Oliver Klee Date: Mon, 2 Sep 2024 19:05:19 +0200 Subject: [PATCH] [TASK] Switch to the Coveralls GitHub action (#1430) Unfortunately, with the GitHub Action, we need to go back to using the path `build/logs/clover.xml` for the combined coverage file. Closes #1431 --- .github/workflows/codecoverage.yml | 11 +++++++---- .gitignore | 2 +- composer.json | 5 ++--- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/.github/workflows/codecoverage.yml b/.github/workflows/codecoverage.yml index 5ae539a..a0404a4 100644 --- a/.github/workflows/codecoverage.yml +++ b/.github/workflows/codecoverage.yml @@ -75,12 +75,15 @@ jobs: run: "ls -lahR .Build/coverage/" - name: "Merge coverage results" run: composer ci:coverage:merge - - name: "Show generated coverage files" - run: "ls -lahR .Build/coverage/" + - name: "Show combined coverage files" + run: "ls -lahR build/logs/" - name: "Upload coverage results to Coveralls" + uses: coverallsapp/github-action@v2 env: - COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: .Build/bin/php-coveralls --coverage_clover=.Build/coverage/combined.xml --json_path=.Build/coverage/coveralls-upload.json -v + github-token: ${{ secrets.GITHUB_TOKEN }} + # Note: This is the only path that the Coveralls GitHub Action supports. + # So we cannot use something like .Build/coverage/clover.xml here. + file: build/logs/clover.xml strategy: fail-fast: false matrix: diff --git a/.gitignore b/.gitignore index 41dbb4a..bb4fe5d 100644 --- a/.gitignore +++ b/.gitignore @@ -5,7 +5,7 @@ /.php-cs-fixer.cache /.phpunit.result.cache /Documentation-GENERATED-temp/ -/clover.xml +/build /composer.lock /generate-documentation.sh /nbproject diff --git a/composer.json b/composer.json index dca5d62..3b0b428 100644 --- a/composer.json +++ b/composer.json @@ -51,7 +51,6 @@ "friendsofphp/php-cs-fixer": "^3.64.0", "helmich/typo3-typoscript-lint": "^3.1.1", "icanhazstring/composer-unused": "^0.8.11", - "php-coveralls/php-coveralls": "^2.7.0", "php-parallel-lint/php-parallel-lint": "^1.4", "phpmd/phpmd": "^2.15.0", "phpstan/extension-installer": "^1.4.2", @@ -132,7 +131,7 @@ ], "ci:coverage:merge": [ "@coverage:create-directories", - "@php tools/phpcov merge --clover=.Build/coverage/combined.xml .Build/coverage/" + "@php tools/phpcov merge --clover=build/logs/clover.xml .Build/coverage/" ], "ci:coverage:unit": [ "@coverage:create-directories", @@ -171,7 +170,7 @@ "ci:typoscript:lint": "typoscript-lint -c Configuration/TsLint.yml --ansi -n --fail-on-warnings -vvv Configuration/TypoScript", "ci:xliff:lint": "php Build/xliff/xliff-lint lint:xliff Resources/Private/Language", "ci:yaml:lint": "find . ! -path '*.Build/*' ! -path '*node_modules/*' \\( -name '*.yaml' -o -name '*.yml' \\) | xargs -r php ./.Build/bin/yaml-lint", - "coverage:create-directories": "mkdir -p .Build/coverage", + "coverage:create-directories": "mkdir -p .Build/coverage build/logs", "docs:generate": "docker run --rm --pull always -v $(pwd):/project -it ghcr.io/typo3-documentation/render-guides:latest --config=Documentation", "fix:composer:normalize": "@composer normalize --no-check-lock", "fix:php": [