From bb52944347059c332fa1852402be012a19dff172 Mon Sep 17 00:00:00 2001 From: mostwanted Date: Thu, 2 Jan 2014 00:00:34 +0100 Subject: [PATCH 1/6] Add @return void annotation to test methods --- Tests/Unit/Domain/Model/AdditionTest.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Tests/Unit/Domain/Model/AdditionTest.php b/Tests/Unit/Domain/Model/AdditionTest.php index 7dcde51..96915bc 100644 --- a/Tests/Unit/Domain/Model/AdditionTest.php +++ b/Tests/Unit/Domain/Model/AdditionTest.php @@ -46,6 +46,7 @@ class AdditionTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function getTitleInitiallyReturnsEmptyString() { $this->assertSame( @@ -56,6 +57,7 @@ class AdditionTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function setTitleSetsTitle() { $this->subject->setTitle('foo bar'); @@ -65,4 +67,4 @@ class AdditionTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { $this->subject->getTitle() ); } -} \ No newline at end of file +} From 956e8b5a09ecf16967df787c009aec37da5319f8 Mon Sep 17 00:00:00 2001 From: mostwanted Date: Thu, 2 Jan 2014 00:01:54 +0100 Subject: [PATCH 2/6] Add @return void annotation to test methods --- Tests/Unit/Domain/Model/TeaBeverageTest.php | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Tests/Unit/Domain/Model/TeaBeverageTest.php b/Tests/Unit/Domain/Model/TeaBeverageTest.php index f4dd1eb..80b79e9 100644 --- a/Tests/Unit/Domain/Model/TeaBeverageTest.php +++ b/Tests/Unit/Domain/Model/TeaBeverageTest.php @@ -46,6 +46,7 @@ class TeaBeverageTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function getSizeInitiallyReturnsZero() { $this->assertSame( @@ -56,6 +57,7 @@ class TeaBeverageTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function setSizeSetsSize() { $this->subject->setSize(1234.56); @@ -68,6 +70,7 @@ class TeaBeverageTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function getTypeInitiallyReturnsNull() { $this->assertNull( @@ -77,6 +80,7 @@ class TeaBeverageTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function setTypeSetsType() { $type = new \OliverKlee\Tea\Domain\Model\TeaType(); @@ -90,6 +94,7 @@ class TeaBeverageTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function getAdditionsInitiallyReturnsEmptyStorage() { $this->assertEquals( @@ -100,6 +105,7 @@ class TeaBeverageTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function setAdditionsSetsAdditions() { $items = new \TYPO3\CMS\Extbase\Persistence\ObjectStorage(); @@ -113,6 +119,7 @@ class TeaBeverageTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function addAdditionAddsAddition() { $items = new \TYPO3\CMS\Extbase\Persistence\ObjectStorage(); @@ -128,6 +135,7 @@ class TeaBeverageTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function removeAdditionRemovesAddition() { $items = new \TYPO3\CMS\Extbase\Persistence\ObjectStorage(); @@ -144,6 +152,7 @@ class TeaBeverageTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function getTestimonialsInitiallyReturnsEmptyStorage() { $this->assertEquals( @@ -154,6 +163,7 @@ class TeaBeverageTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function setTestimonialsSetsTestimonials() { $items = new \TYPO3\CMS\Extbase\Persistence\ObjectStorage(); @@ -167,6 +177,7 @@ class TeaBeverageTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function addTestimonialAddsTestimonial() { $items = new \TYPO3\CMS\Extbase\Persistence\ObjectStorage(); @@ -182,6 +193,7 @@ class TeaBeverageTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function removeTestimonialRemovesTestimonial() { $items = new \TYPO3\CMS\Extbase\Persistence\ObjectStorage(); @@ -195,4 +207,4 @@ class TeaBeverageTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { $this->subject->getTestimonials()->contains($newItem) ); } -} \ No newline at end of file +} From a64094be3d2f45f9970d1683eaaddfaecfa2a11a Mon Sep 17 00:00:00 2001 From: mostwanted Date: Thu, 2 Jan 2014 00:02:47 +0100 Subject: [PATCH 3/6] Add @return void annotation to test methods --- Tests/Unit/Domain/Model/TestimonialTest.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Tests/Unit/Domain/Model/TestimonialTest.php b/Tests/Unit/Domain/Model/TestimonialTest.php index 2ea6ed8..317fdcf 100644 --- a/Tests/Unit/Domain/Model/TestimonialTest.php +++ b/Tests/Unit/Domain/Model/TestimonialTest.php @@ -46,6 +46,7 @@ class TestimonialTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function getDateOfPostingInitiallyReturnsNull() { $this->assertNull( @@ -55,6 +56,7 @@ class TestimonialTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function setDateOfPostingSetsDateOfPosting() { $date = new \DateTime(); @@ -68,6 +70,7 @@ class TestimonialTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function getNumberOfConsumedCupsInitiallyReturnsZero() { $this->assertSame( @@ -78,6 +81,7 @@ class TestimonialTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function setNumberOfConsumedCupsSetsNumberOfConsumedCups() { $this->subject->setNumberOfConsumedCups(123456); @@ -90,6 +94,7 @@ class TestimonialTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function getTextInitiallyReturnsEmptyString() { $this->assertSame( @@ -100,6 +105,7 @@ class TestimonialTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { /** * @test + * @return void */ public function setTextSetsText() { $this->subject->setText('foo bar'); @@ -109,4 +115,4 @@ class TestimonialTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase { $this->subject->getText() ); } -} \ No newline at end of file +} From e2732e2533453c34a54249081a4796371a7e78c7 Mon Sep 17 00:00:00 2001 From: mostwanted Date: Thu, 2 Jan 2014 00:03:12 +0100 Subject: [PATCH 4/6] Add @return void annotation to test methods --- Tests/Unit/Domain/Repository/TeaBeverageRepositoryTest.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Tests/Unit/Domain/Repository/TeaBeverageRepositoryTest.php b/Tests/Unit/Domain/Repository/TeaBeverageRepositoryTest.php index 34b691b..214f524 100644 --- a/Tests/Unit/Domain/Repository/TeaBeverageRepositoryTest.php +++ b/Tests/Unit/Domain/Repository/TeaBeverageRepositoryTest.php @@ -53,10 +53,11 @@ class TeaBeverageRepositoryTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCa /** * @test + * @return void */ public function canBeInstantiated() { $this->assertNotNull( $this->subject ); } -} \ No newline at end of file +} From 64303b35b228fcbfca7ebb9a66d1759808ce427e Mon Sep 17 00:00:00 2001 From: mostwanted Date: Thu, 2 Jan 2014 00:03:30 +0100 Subject: [PATCH 5/6] Add @return void annotation to test methods --- Tests/Unit/Domain/Repository/TestimonialRepositoryTest.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Tests/Unit/Domain/Repository/TestimonialRepositoryTest.php b/Tests/Unit/Domain/Repository/TestimonialRepositoryTest.php index 185d73b..f8fe1ef 100644 --- a/Tests/Unit/Domain/Repository/TestimonialRepositoryTest.php +++ b/Tests/Unit/Domain/Repository/TestimonialRepositoryTest.php @@ -53,10 +53,11 @@ class TestimonialRepositoryTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCa /** * @test + * @return void */ public function canBeInstantiated() { $this->assertNotNull( $this->subject ); } -} \ No newline at end of file +} From 9343053ab643d43828b052e1e4a30c9a84f6c258 Mon Sep 17 00:00:00 2001 From: mostwanted Date: Thu, 2 Jan 2014 00:04:01 +0100 Subject: [PATCH 6/6] Add @return void annotation to test methods --- Tests/Unit/Controller/TestimonialControllerTest.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Tests/Unit/Controller/TestimonialControllerTest.php b/Tests/Unit/Controller/TestimonialControllerTest.php index 4004313..968e406 100644 --- a/Tests/Unit/Controller/TestimonialControllerTest.php +++ b/Tests/Unit/Controller/TestimonialControllerTest.php @@ -70,6 +70,7 @@ class TestimonialControllerTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCa /** * @test + * @return void */ public function indexActionCanBeCalled() { $this->subject->indexAction(); @@ -77,6 +78,7 @@ class TestimonialControllerTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCa /** * @test + * @return void */ public function indexActionPassesAllTestimonialsAsTestimonialsToView() { $allTestimonials = new ObjectStorage(); @@ -87,4 +89,4 @@ class TestimonialControllerTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCa $this->subject->indexAction(); } -} \ No newline at end of file +}