From a91063ae99c1c96b37f537023a4352458ee37025 Mon Sep 17 00:00:00 2001
From: Daniel Siepmann <coding@daniel-siepmann.de>
Date: Fri, 31 Jan 2020 11:26:57 +0100
Subject: [PATCH] [BUGFIX] Display edit icons in frontend

Do not hide them via inline display none.
Instead provide necessary CSS via static TypoScript.
---
 Classes/FrontendEditPanel.php                | 2 +-
 Configuration/TCA/Overrides/sys_template.php | 8 ++++++++
 Configuration/TypoScript/setup.typoscript    | 8 ++++++++
 3 files changed, 17 insertions(+), 1 deletion(-)
 create mode 100644 Configuration/TCA/Overrides/sys_template.php
 create mode 100644 Configuration/TypoScript/setup.typoscript

diff --git a/Classes/FrontendEditPanel.php b/Classes/FrontendEditPanel.php
index e79ed21..53bcb6c 100644
--- a/Classes/FrontendEditPanel.php
+++ b/Classes/FrontendEditPanel.php
@@ -302,7 +302,7 @@ class FrontendEditPanel
         $width = MathUtility::forceIntegerInRange($this->backendUser->getTSConfig()['options.']['feedit.']['popupWidth'] ?? 690, 690, 5000, 690);
         $height = MathUtility::forceIntegerInRange($this->backendUser->getTSConfig()['options.']['feedit.']['popupHeight'] ?? 500, 500, 5000, 500);
         $onclick = 'vHWin=window.open(' . GeneralUtility::quoteJSvalue($url . '&returnUrl=' . rawurlencode(PathUtility::getAbsoluteWebPath(GeneralUtility::getFileAbsFileName('EXT:backend/Resources/Public/Html/Close.html')))) . ',\'FEquickEditWindow\',\'width=' . $width . ',height=' . $height . ',status=0,menubar=0,scrollbars=1,resizable=1\');vHWin.focus();return false;';
-        return '<a href="#" class="typo3-editPanel-btn typo3-editPanel-btn-default frontEndEditIconLinks ' . htmlspecialchars($additionalClasses) . '" onclick="' . htmlspecialchars($onclick) . '" style="display: none;">' . $string . '</a>';
+        return '<a href="#" class="typo3-editPanel-btn typo3-editPanel-btn-default frontEndEditIconLinks ' . htmlspecialchars($additionalClasses) . '" onclick="' . htmlspecialchars($onclick) . '">' . $string . '</a>';
     }
 
     /**
diff --git a/Configuration/TCA/Overrides/sys_template.php b/Configuration/TCA/Overrides/sys_template.php
new file mode 100644
index 0000000..e8079cc
--- /dev/null
+++ b/Configuration/TCA/Overrides/sys_template.php
@@ -0,0 +1,8 @@
+<?php
+defined('TYPO3_MODE') or die();
+
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addStaticFile(
+    'feedit',
+    'Configuration/TypoScript',
+    'Frontend Editing'
+);
diff --git a/Configuration/TypoScript/setup.typoscript b/Configuration/TypoScript/setup.typoscript
new file mode 100644
index 0000000..5327c4b
--- /dev/null
+++ b/Configuration/TypoScript/setup.typoscript
@@ -0,0 +1,8 @@
+plugin.tx_feedit._CSS_DEFAULT_STYLE (
+    .typo3-editPanel-btn .icon-size-small {
+        display: inline-block;
+        height: 16px;
+        line-height: 16px;
+        width: 16px;
+    }
+)