Recent Commits to typo3:main

[BUGFIX] Fix capitalization in recordlist heading

2023-02-15T21:00:05Z

[BUGFIX] Fix capitalization in recordlist heading

Resolves: #99968
Releases: main
Change-Id: Ie54a76fadf1000e8506ad512e14caa165c41ca86
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77876
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>

[BUGFIX] Fix typo for a fe_users language key

2023-02-15T16:25:02Z

[BUGFIX] Fix typo for a fe_users language key

personelData -> personalData

Resolves: #99964
Releases: main
Change-Id: If59a501b2faef95c4800995fc8ba985bba343134
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77873
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Josef Glatz <typo3@josefglatz.at>
Reviewed-by: Josef Glatz <typo3@josefglatz.at>

[BUGFIX] Add type cast for potential mountpoint information

2023-02-15T15:59:05Z

[BUGFIX] Add type cast for potential mountpoint information

Avoid exceptions by adding a type cast to string for the mount point
information. An additional early return avoids additional calls to
`\TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode()`.

Resolves: #99946
Releases: main, 11.5
Change-Id: I18ea15c0f3e2c884e3333e55877e0f6dbe56c859
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77860
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Jochen <rothjochen@gmail.com>

[BUGFIX] Get the correct next stage for moved elements in workspace

2023-02-15T15:58:23Z

[BUGFIX] Get the correct next stage for moved elements in workspace

The method TYPO3\CMS\Workspaces\Service\StageService->getNextStageForElementCollection relies on the field t3ver_stage to calculate the next stage for changed elements in a workspace. Without it, it falls back to 0 (zero), meaning the current stage is "Editing". This fix provides the neccessary field so the next stage can be calculated correct.

Resolves: #98916
Releases: main, 11.5
Change-Id: I3b87c54b24c3cfe5eb2417fc582f3c4a3fb18ffc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76525
Tested-by: Josua Vogel <j.vogel97@web.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Josua Vogel <j.vogel97@web.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>

[BUGFIX] Position sidebar in image cropping correctly on the right

2023-02-15T15:41:03Z

[BUGFIX] Position sidebar in image cropping correctly on the right

Currently, the sidebar containing the cropVariants
is always positioned below.

This has been fixed by adding a missing display flex
to the modal on sm-viewport and up.

On top of that the undefined this.cropBox error
on modal load was fixed by adding a empty JQuery object
on initialization.

Resolves: #99953
Releases: main
Change-Id: I679b188e38add5e06ad8e6334ddc15de01a42e60
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77865
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

[TASK] Refine LiveSearch form behavior

2023-02-15T15:09:45Z

[TASK] Refine LiveSearch form behavior

The behavior of the LiveSearch form used in the modal window is refined
in several ways.

The most important change is the usage of `SearchDemand` to pre-fill the
search form. This required to add a `form` tag and to rename the
`searchField` field to `query` to align with the `SearchDemand`
requirements. Also, the `q` argument is renamed to `query` as well.

Instead of directly triggering the search at several locations, a form
submit is request. This allows to call `search()` only once and to
provide a `FormData` object, containing all fields and values for the
underlying AJAX request. With this, there is no need to store the values
in properties anymore (`this.searchTerm` and `this.searchProperties`),
which are dropped now.

Resolves: #99954
Releases: main
Change-Id: Ibeb8c45048f8cc6c4801df648a19c0ecf7afb883
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77853
Tested-by: core-ci <typo3@b13.com>
Tested-by: Frank Nägler <frank.naegler@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.com>

[TASK] Move PageTsBackendLayoutDataProvider namespace

2023-02-15T12:31:49Z

[TASK] Move PageTsBackendLayoutDataProvider namespace

Class
\TYPO3\CMS\Backend\Provider\PageTsBackendLayoutDataProvider
is moved to more appropriate
\TYPO3\CMS\Backend\View\BackendLayout\PageTsBackendLayoutDataProvider

Resolves: #99958
Releases: main
Change-Id: I57e329ead23deff4bd3a8c7c68b25c8b6ad79799
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77862
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

[BUGFIX] Handle FormData passed to AjaxRequest API properly

2023-02-15T12:06:58Z

[BUGFIX] Handle FormData passed to AjaxRequest API properly

The AjaxRequest API is now able to cope with `FormData` objects passed
as first argument in either `post()`, `put()` or `delete()`.
Previously, a workaround was necessary that submitted
`{body: formData}` as `RequestInit` to fulfill this task. Since this
workaround is not required anymore, usages are adapted accordingly.

Resolves: #99955
Releases: main
Change-Id: I8e04040d262c874e9d51bff58eb1f7c378b05a18
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77861
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

[TASK] Avoid GU::_GP() in DataHandler

2023-02-15T12:05:11Z

[TASK] Avoid GU::_GP() in DataHandler

DataHandler should of course *not* have a dependency
to _GET or _POST: All data should be hand over as
"command" and "data" array.

Flex form handling violates this for section container
deletion and sorting by using GeneralUtility::_GP().

The patch changes the logic to carry the "_ACTION"
information within the flex data array. This simplifies
the flex form handling logic a bit, we can get rid
of a recursion along the way.

Resolves: #99952
Releases: main
Change-Id: Ifaa15162d018725fe3ba8ae7b1a05655a0cffb36
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77856
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

[TASK] Avoid GU::_GP() in PageTsBackendLayoutDataProvider

2023-02-15T11:29:02Z

[TASK] Avoid GU::_GP() in PageTsBackendLayoutDataProvider

The method using GU::_GP() can get more data
hand over to always have the pageId available
already. Do this and avoid another call to
GeneralUtility::_GP().

Note the entire backend layout handling carries
far too much state, is complex in general and
hard to follow. It should be streamlined and
simplified.

Resolves: #99948
Releases: main
Change-Id: I13a70a234dae0a20256e4a932de891a49531c9af
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77852
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

[TASK] Add delete action for usergroup list

2023-02-15T10:17:08Z

[TASK] Add delete action for usergroup list

Currently, the list of usergroups does not
contain a delete button but the user list does.

A delete button was added to have a consistent
ui for user and group listing.

Resolves: #99867
Releases: main
Change-Id: I7e5de8091fb053a182d6c45c73ccb7af69485221
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77772
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

[BUGFIX] Guard ConstantEditor with copy operator in constants

2023-02-14T12:13:44Z

[BUGFIX] Guard ConstantEditor with copy operator in constants

If copy operator '<' is used in TypoScript constants for a
constant with a constant editor configuration comment, the
"Call to member function getType() on null" exception is
emitted.

Example TypoScript constants:

>  # cat=custom/a; type=color; label=Primary Color
>  plugin.tx_example.primaryColor = #282E31
>
>  # cat=custom/a; type=color; label=Other Color
>  plugin.tx_example.otherColor < plugin.tx_example.primaryColor

This may happen when a comment token stream is
handled multiple times without being reset properly.

Resolves: #99906
Related: #97816
Releases: main
Change-Id: I5c15a9bf194f8c24e7306213218e1b801fe7cb72
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77808
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Bartsch <bo@cedev.de>

[TASK] Deprecate PageRenderer->enableDebugMode()

2023-02-14T11:25:55Z

[TASK] Deprecate PageRenderer->enableDebugMode()

PageRenderer->enableDebugMode() is only called in
backend by the core. The properties set by the
method do not have any effect in BE during further
processing.

The method is typically not called in Frontend,
any calls can be moved to the single setters
instead.

The patch deprecates PageRenderer->enableDebugMode().

Resolves: #99932
Releases: main
Change-Id: Iddef89c9e97f721a7b33ccc838d20f17b03471f4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77831
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>

[TASK] Deprecate the limit parameter for GU::intExplode

2023-02-14T10:09:09Z

[TASK] Deprecate the limit parameter for GU::intExplode

Passing a limit to `GU::intExplode` will cause the method to
potentially return a string as the last array element, which
is not documented and directly contradicts the method contract
(which states that an array of integers will be returned).

The deprecated parameter is not used in the Core at all.

Resolves: #99900
Releases: main
Change-Id: Ic175fcef56f78c9bc237850fc7c7b1d31701d6f8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77806
Tested-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

[TASK] Refine LiveSearch search demand

2023-02-14T08:46:18Z

[TASK] Refine LiveSearch search demand

The search demand implementation used by the LiveSearch is refined to be
more flexible. Instead of a hard-coded list of properties, the
constructor now receives a list of `DemandProperty` instances that
accept everything that is backed by the `DemandPropertyName` enum,
allowing to pass only the required properties.

The `SearchDemand` class is immutable by design, it's API must not
allow modification by 3rd parties. However, there is an internal
`MutableSearchDemand` acting as a helper that allows to add / override
properties. A `SearchDemand` object may be constructed from a request
object, where it's payload must contain properties from the
aforementioned `DemandPropertyName` enum.

Resolves: #99941
Releases: main
Change-Id: I880855943a67237fa765cd3da94333e8aaa3a2a2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77842
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>

[BUGFIX] Toolbar link to environment opens in iframe

2023-02-13T18:28:45Z

[BUGFIX] Toolbar link to environment opens in iframe

Toolbar > SystemInformation has a link to
Environment module that opens without module
menu and toolbar, just the main iframe.

Links from within the top iframe are managed
by JS and need some magic to trigger this
properly.

Resolves: #99854
Releases: main
Change-Id: Ic824e3dc3e409b8f86108654af6b540061de05f0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77838
Tested-by: Jasmina Ließmann <minapokhalo+typo3@gmail.com>
Reviewed-by: Jasmina Ließmann <minapokhalo+typo3@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

[TASK] Make extbase repository generic (phpstan-wise)

2023-02-13T18:27:52Z

[TASK] Make extbase repository generic (phpstan-wise)

This patch introduces template tags on the extbase repository
interface, the extbase repository class and the abstract resource
repository class (File, ProcessedFile etc.) to let static code
analyzers and modern IDE's know what that those repositories are
generic.

This patch also introduces extends tags on actual reposities to
let static code analysis know what kind of object the repository
deals with.

As a byproduct, a few phpdoc params and return types have been
fixed or specified.

Releases: main
Resolves: #99931
Change-Id: I0056e420406fa84693d4104db9d7a9ec362c33d7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77825
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>

[TASK] Eliminate double serialization in ApcuBackend

2023-02-13T18:15:26Z

[TASK] Eliminate double serialization in ApcuBackend

APCu can store arbitrary PHP data; it serializes all
values when they are stored, and it has a pluggable
serializer interface which can use serializers that
are better than serialize(), such as "igbinary",
see [1] and [2].

By not implementing TransientBackendInterface, the
ApcuBackend forces class VariableFrontend to serialize
all values into a string, but APCu serializes the
string again.

This adds TransientBackendInterface and removes the
is_string() check. Double serialization is eliminated
by this change.

Additionally, the unit tests are turned into
functionals, the backend is declared final, gets
some more type hints and uses the quicker xxh3 hash.

[1] https://www.php.net/manual/en/book.igbinary.php
[2] https://pecl.php.net/package/igbinary

Releases: main
Resolves: #99851
Change-Id: I8663deefd1ffeb249376119287191bcec9ef2420
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77717
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

[BUGFIX] Handle array access in LocalImageProcessor

2023-02-13T18:04:14Z

[BUGFIX] Handle array access in LocalImageProcessor

Handle missing image dimensions (width, height)
without throwing an exception.

In same cases, image dimension may not be able to be
set properly.

Resolves: #99406
Releases: main, 11.5
Change-Id: I81124dcaf29932448a87b69ab5bf6445eeb7469c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77844
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>