Work-Related/search_core
Work-Related/search_core
1
0
mirror of https://github.com/Codappix/search_core.git synced 2024-11-22 07:56:11 +01:00
Code Releases Activity

Merge pull request #171 from Codappix/feature/170-do-not-specify-the-pluginname

Browse source 
TASK: Make multiple plugins with flexform settings possible
This commit is contained in:
Justus Moroni 2018-11-06 18:09:29 +01:00 committed by GitHub
commit 8eecdff01e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Classes/Configuration/ConfigurationContainer.php
View file

@ -45,8 +45,7 @@ class ConfigurationContainer implements ConfigurationContainerInterface
{ {
$this->settings = $configurationManager->getConfiguration( $this->settings = $configurationManager->getConfiguration(
ConfigurationManagerInterface::CONFIGURATION_TYPE_SETTINGS, ConfigurationManagerInterface::CONFIGURATION_TYPE_SETTINGS,
'SearchCore', 'SearchCore'
'search'
); );
if ($this->settings === null) { if ($this->settings === null) {
throw new NoConfigurationException('Could not fetch configuration.', 1484226842); throw new NoConfigurationException('Could not fetch configuration.', 1484226842);

1
Documentation/source/changelog.rst
View file

@ -14,3 +14,4 @@ Changelog
changelog/20180308-introduce-php70-type-hints changelog/20180308-introduce-php70-type-hints
changelog/20180306-120-facet-configuration changelog/20180306-120-facet-configuration
changelog/20180926-163-allow-zero-as-typoscript-filter-value changelog/20180926-163-allow-zero-as-typoscript-filter-value
changelog/20181106-170-do-not-specify-the-pluginname-in-configurationcontainer

17
Documentation/source/changelog/20181106-170-do-not-specify-the-pluginname-in-configurationcontainer.rst Normal file
View file

@ -0,0 +1,17 @@
Feature 170 "Do not specify the pluginName in ConfigurationContainer"
===============================================================================
Prior to the change it was not possible to create a second plugin in a
separate extension. The pluginName for the configuration was set to `search`.
The problem was that the plugin specific settings could not be fetched.
The configuration in `plugin.tx_exampleextension_pluginkey.settings {..}` and
from flexform were not fetched.
Now the pluginName is not set and the ConfigurationManager checks which plugin
is used in the current context.
It is now possible to create a second plugin. For example if you want to cache
the output of your query or the filters you specified.
See :issue:`170`.