From 6c46a2016049dc725acb3f373ea67b4bda18a882 Mon Sep 17 00:00:00 2001
From: Justus Moroni <developer@leonmrni.com>
Date: Tue, 6 Nov 2018 17:34:56 +0100
Subject: [PATCH] TASK: Make multiple plugins with flexform settings possible

Remove the specified pluginName in the
ConfigurationContainer so the correct settings for the
context can be fetched.

Resolves: #170
---
 .../Configuration/ConfigurationContainer.php    |  3 +--
 Documentation/source/changelog.rst              |  1 +
 ...the-pluginname-in-configurationcontainer.rst | 17 +++++++++++++++++
 3 files changed, 19 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/source/changelog/20181106-170-do-not-specify-the-pluginname-in-configurationcontainer.rst

diff --git a/Classes/Configuration/ConfigurationContainer.php b/Classes/Configuration/ConfigurationContainer.php
index eab76e0..88aa414 100644
--- a/Classes/Configuration/ConfigurationContainer.php
+++ b/Classes/Configuration/ConfigurationContainer.php
@@ -45,8 +45,7 @@ class ConfigurationContainer implements ConfigurationContainerInterface
     {
         $this->settings = $configurationManager->getConfiguration(
             ConfigurationManagerInterface::CONFIGURATION_TYPE_SETTINGS,
-            'SearchCore',
-            'search'
+            'SearchCore'
         );
         if ($this->settings === null) {
             throw new NoConfigurationException('Could not fetch configuration.', 1484226842);
diff --git a/Documentation/source/changelog.rst b/Documentation/source/changelog.rst
index 2cad89f..0bde72f 100644
--- a/Documentation/source/changelog.rst
+++ b/Documentation/source/changelog.rst
@@ -14,3 +14,4 @@ Changelog
    changelog/20180308-introduce-php70-type-hints
    changelog/20180306-120-facet-configuration
    changelog/20180926-163-allow-zero-as-typoscript-filter-value
+   changelog/20181106-170-do-not-specify-the-pluginname-in-configurationcontainer
diff --git a/Documentation/source/changelog/20181106-170-do-not-specify-the-pluginname-in-configurationcontainer.rst b/Documentation/source/changelog/20181106-170-do-not-specify-the-pluginname-in-configurationcontainer.rst
new file mode 100644
index 0000000..7bca897
--- /dev/null
+++ b/Documentation/source/changelog/20181106-170-do-not-specify-the-pluginname-in-configurationcontainer.rst
@@ -0,0 +1,17 @@
+Feature 170 "Do not specify the pluginName in ConfigurationContainer"
+===============================================================================
+
+Prior to the change it was not possible to create a second plugin in a
+separate extension. The pluginName for the configuration was set to `search`.
+The problem was that the plugin specific settings could not be fetched.
+
+The configuration in `plugin.tx_exampleextension_pluginkey.settings {..}` and
+from flexform were not fetched.
+
+Now the pluginName is not set and the ConfigurationManager checks which plugin
+is used in the current context.
+
+It is now possible to create a second plugin. For example if you want to cache
+the output of your query or the filters you specified.
+
+See :issue:`170`.